TUN-8425: Remove ICMP binding for quick tunnels

DevinCarr · DevinCarr · commit e9f010111d3e · 2024-05-23T18:16:30.000Z
diff --git a/cmd/cloudflared/tunnel/cmd.go b/cmd/cloudflared/tunnel/cmd.go
@@ -409,6 +409,11 @@ func StartServer(
 		}
 	}
 
+	// Disable ICMP packet routing for quick tunnels
+	if quickTunnelURL != "" {
+		tunnelConfig.PacketConfig = nil
+	}
+
 	internalRules := []ingress.Rule{}
 	if features.Contains(features.FeatureManagementLogs) {
 		serviceIP := c.String("service-op-ip")

Original file line number	Diff line number	Diff line change
`@@ -409,6 +409,11 @@ func StartServer(`
`409`	`409`	`}`
`410`	`410`	`}`
`411`	`411`
	`412`	`+ // Disable ICMP packet routing for quick tunnels`
	`413`	`+ if quickTunnelURL != "" {`
	`414`	`+ tunnelConfig.PacketConfig = nil`
	`415`	`+ }`
	`416`	`+`
`412`	`417`	`internalRules := []ingress.Rule{}`
`413`	`418`	`if features.Contains(features.FeatureManagementLogs) {`
`414`	`419`	`serviceIP := c.String("service-op-ip")`