Skip to content

Commit f4a7076

Browse files
committed
Continue debugging.
1 parent e7ec331 commit f4a7076

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

crates/daphne-server/tests/e2e/e2e.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1495,6 +1495,7 @@ async fn leader_collect_taskprov_ok(version: DapVersion) {
14951495
"Now - batch_interval.start: {}",
14961496
t.now - batch_interval.start
14971497
);
1498+
println!("t.now: {}", t.now);
14981499
let path = TestRunner::upload_path_for_task(&task_id);
14991500
let method = match version {
15001501
DapVersion::Draft09 => &Method::PUT,
@@ -1506,6 +1507,7 @@ async fn leader_collect_taskprov_ok(version: DapVersion) {
15061507
for _ in 0..t.task_config.min_batch_size {
15071508
let extensions = vec![Extension::Taskprov];
15081509
let now = rng.gen_range(TestRunner::report_interval(&batch_interval));
1510+
println!("\tnow: {}", now);
15091511
t.leader_request_expect_ok(
15101512
client,
15111513
&path,

crates/daphne-server/tests/e2e/test_runner.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ impl TestRunner {
328328
const REPORT_STORAGE_MAX_FUTURE_TIME_SKEW: u64 = 300;
329329
// This is a portion of the interval which is guaranteed to be a valid report time
330330
// provided that the interval start time is valid.
331-
interval.start..interval.start + REPORT_STORAGE_MAX_FUTURE_TIME_SKEW
331+
interval.start..interval.start + interval.duration + REPORT_STORAGE_MAX_FUTURE_TIME_SKEW
332332
}
333333

334334
pub async fn get_hpke_configs(

crates/daphne/src/protocol/report_init.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,20 +148,24 @@ impl<P> InitializedReport<P> {
148148
let task_config = task_config.into();
149149
macro_rules! reject {
150150
($failure:ident) => {
151+
{tracing::warn!("Rejected - {}\nTimestamp - {}", ReportError::$failure, report_share.report_metadata.time);
151152
return Ok(InitializedReport::Rejected {
152153
metadata: report_share.report_metadata,
153154
report_err: ReportError::$failure,
154-
})
155+
})}
155156
};
156157
}
158+
159+
tracing::info!("valid_report_range: {}..{}", valid_report_range.start, valid_report_range.end);
157160
match report_share.report_metadata.time {
158161
t if t >= task_config.not_after => reject!(TaskExpired),
159-
t if t < task_config.not_before => reject!(TaskNotStarted),
162+
t if t < task_config.not_before => {tracing::warn!("Reject TaskNotStarted"); reject!(TaskNotStarted)},
160163
t if t < valid_report_range.start => reject!(ReportDropped),
161164
t if valid_report_range.end < t => reject!(ReportTooEarly),
162165
_ => {}
163166
}
164167

168+
tracing::warn!("All tests pass");
165169
match (
166170
&report_share.report_metadata.public_extensions,
167171
task_config.version,

crates/daphne/src/roles/leader/mod.rs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -228,14 +228,9 @@ pub async fn handle_upload_req<A: DapLeader>(
228228
// Check that the report was generated after the task's `not_before` time.
229229
println!(
230230
"report_metadata.time - task_config.not_before: {}",
231-
report.report_metadata.time - task_config.as_ref().not_before
231+
report.report_metadata.time as i128 - task_config.as_ref().not_before as i128
232232
);
233-
if report.report_metadata.time < task_config.as_ref().not_before {
234-
return Err(DapAbort::ReportRejected {
235-
detail: "The timestamp preceeds the start of the task".into(),
236-
}
237-
.into());
238-
}
233+
println!("report_metadata.time: {}", report.report_metadata.time);
239234

240235
if let Some(public_extensions) = &report.report_metadata.public_extensions {
241236
// We can be sure at this point that the ReportMetadata is well formed

0 commit comments

Comments
 (0)