Add compile-time validation for histogram buckets in foundations-macros #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaHoffmann
approved these changes
Jul 17, 2025
fisherdarling
approved these changes
Aug 27, 2025
TheJokr
approved these changes
Aug 27, 2025
fisherdarling
force-pushed
the
histogram-bucket-validation
branch
from
99ad34d to
5187e99
Compare
|
rebased |
fisherdarling
force-pushed
the
histogram-bucket-validation
branch
from
5187e99 to
d672501
Compare
|
fixed some clippy issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had a bug in a service using foundations where the buckets in my histogram were not in ascending order because of a typo. Instead of this being detected and handled in any way, I just had a broken metric.
This change adds compile time checks when using the metrics proc macro to, if the buckets are provided directly, check the ordering. It doesn't check if they're passed from a variable or function or any other method, and I think the only way to do that would be runtime validation - the binary would consistently fail to start immediately, but have kept this constrained to a compile-time check for now to get thoughts/feedback.