Changing transport to not drop but keep retrying, mostly indefinitly

Ian Pye · Ian Pye · commit 5f6e7b505978 · 2013-09-09T12:39:36.000-07:00
diff --git a/transport/client.go b/transport/client.go
@@ -14,8 +14,8 @@ import (
 	"time"
 )
 
-const RETRIES = 3
 const ACK_TIMEOUT_MS = 10000
+const RETRY_MAX = 100
 
 type Client struct {
 	*stream.HardStopChannelCloser
@@ -81,13 +81,14 @@ func (src *Client) Run() error {
 		}
 	}(stream.Name(src), src)
 
-	for src.retries < 3 {
+	for src.retries < RETRY_MAX {
 		err := src.connect()
 		if err == nil {
 			slog.Logf(logger.Levels.Warn, "Connection failed without error")
 			return err
 		} else {
 			slog.Logf(logger.Levels.Error, "Connection failed with error, retrying: %s", err)
+			time.Sleep(1 * time.Second)
 		}
 	}
 	slog.Logf(logger.Levels.Error, "Connection failed retries exceeded. Leftover: %d", src.buf.Len())

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,8 @@ import (`
`14`	`14`	`"time"`
`15`	`15`	`)`
`16`	`16`
`17`		`-const RETRIES = 3`
`18`	`17`	`const ACK_TIMEOUT_MS = 10000`
	`18`	`+const RETRY_MAX = 100`
`19`	`19`
`20`	`20`	`type Client struct {`
`21`	`21`	`*stream.HardStopChannelCloser`
`@@ -81,13 +81,14 @@ func (src *Client) Run() error {`
`81`	`81`	`}`
`82`	`82`	`}(stream.Name(src), src)`
`83`	`83`
`84`		`- for src.retries < 3 {`
	`84`	`+ for src.retries < RETRY_MAX {`
`85`	`85`	`err := src.connect()`
`86`	`86`	`if err == nil {`
`87`	`87`	`slog.Logf(logger.Levels.Warn, "Connection failed without error")`
`88`	`88`	`return err`
`89`	`89`	`} else {`
`90`	`90`	`slog.Logf(logger.Levels.Error, "Connection failed with error, retrying: %s", err)`
	`91`	`+ time.Sleep(1 * time.Second)`
`91`	`92`	`}`
`92`	`93`	`}`
`93`	`94`	`slog.Logf(logger.Levels.Error, "Connection failed retries exceeded. Leftover: %d", src.buf.Len())`