Test throws in async handlers and many async handlers for write

Author: mrbbot

src/asyncify.js

@@ -92,7 +92,6 @@ async function wrap(rewriter, fn, ...args) {
   assertNoneState();
   let result = fn(...args);
 
-  // TODO: add test for this, if write triggers multiple async handlers?
   while (wasm.asyncify_get_state() === State.UNWINDING) {
     wasm.asyncify_stop_unwind();
 

test/misc.spec.ts

@@ -79,7 +79,18 @@ test("rethrows error thrown in handler", async (t) => {
   await t.throwsAsync(promise, { message: "Whoops!" });
 });
 
-test("handles concurrent rewriters with async handlers", async (t) => {
+test("rethrows error thrown in async handler", async (t) => {
+  const rewriter = new RawHTMLRewriter(() => {}).on("p", {
+    async element() {
+      throw new Error("Whoops!");
+    },
+  });
+
+  const promise = rewriter.write(new TextEncoder().encode("<p>test</p>"));
+  await t.throwsAsync(promise, { message: "Whoops!" });
+});
+
+test.serial("handles concurrent rewriters with async handlers", async (t) => {
   // Note this test requires the "safe" HTMLRewriter, see comments in
   // src/modules/rewriter.ts for more details
   const rewriter = (i: number) =>
@@ -103,6 +114,24 @@ test("handles concurrent rewriters with async handlers", async (t) => {
   t.deepEqual(texts, ["<p>new 3</p>", "<p>new 4</p>"]);
 });
 
+test.serial("handles many async handlers for single chunk write", async (t) => {
+  const rewriter = new HTMLRewriter();
+  rewriter.on("h1", {
+    async element(element) {
+      await wait(50);
+      element.setInnerContent("new h1");
+    },
+  });
+  rewriter.on("p", {
+    async element(element) {
+      await wait(50);
+      element.setInnerContent("new p");
+    },
+  });
+  const res = await rewriter.transform("<h1>old h1</h1><p>old p</p>");
+  t.is(res, "<h1>new h1</h1><p>new p</p>");
+});
+
 test("rewriter allows chaining", (t) => {
   const rewriter = new RawHTMLRewriter(() => {});
   t.is(rewriter.on("p", {}), rewriter);