improve calculations

Author: Ankcorn

apps/workers-observability/src/tools/observability.ts

@@ -54,6 +54,9 @@ This tool provides three primary views of your Worker data:
 - Before applying filters, use the observability_keys and observability_values tools to confirm available filter fields and the correct filter value to add unless you have the data in a response from a previous query.
 - Common filter fields:  $metadata.service, $metadata.trigger, $metadata.message, $metadata.level, $metadata.requestId,
 
+## Calculation Best Practices
+- Before applying calculations, use the observability_keys tools to confirm key that should be used for the calculation
+
 ## Troubleshooting
 - If no results are returned, suggest broadening the time range or relaxing filters
 - For errors about invalid fields, recommend using observability_keys to see available options

packages/mcp-common/src/types/workers-logs-schemas.ts

@@ -59,18 +59,14 @@ export const zQueryFilter = z.object({
 
     • DO NOT guess keys - always use verified keys from either:
       - Previous query results
-      - The '/keys' endpoint response
+      - The observability_keys response
 
     • PREFERRED KEYS (faster & always available):
       - $metadata.service: Worker service name
 			- $metadata.origin: Trigger type (e.g., fetch, scheduled, etc.)
 			- $metadata.trigger: Trigger type (e.g., GET /users, POST /orders, etc.)
       - $metadata.message: Log message text (present in nearly all logs)
       - $metadata.error: Error message (when applicable)
-
-    • ADVANCED USAGE:
-      When using the '/keys' endpoint, set limit=1000+ to retrieve comprehensive key options
-      without needing additional filtering
 `),
 	operation: zQueryOperation,
 	value: zPrimitiveUnion.optional().describe(`Filter comparison value. IMPORTANT:
@@ -99,7 +95,12 @@ export const zQueryFilter = z.object({
 	`)
 
 export const zQueryCalculation = z.object({
-	key: z.string().optional(),
+	key: z.string().optional().describe(`The key to use for the calculation. This key must exist in the logs.
+Use the Keys endpoint to confirm that this key exists
+
+• DO NOT guess keys - always use verified keys from either:
+- Previous query results
+- The observability_keys response`),
 	keyType: z.enum(['string', 'number', 'boolean']).optional(),
 	operator: zQueryOperator,
 	alias: z.string().optional(),
@@ -393,7 +394,9 @@ export const zKeysRequest = z.object({
 		.default([])
 		.describe('Leave this empty to use the default datasets'),
 	filters: z.array(zQueryFilter).default([]),
-	limit: z.number().optional(),
+	limit: z.number().optional().describe(`
+    • ADVANCED USAGE:
+      set limit=1000+ to retrieve comprehensive key options without needing additional filtering`),
 	needle: zSearchNeedle.optional(),
 	keyNeedle: zSearchNeedle.optional()
 		.describe(`If the user makes a suggestion for a key, use this to narrow down the list of keys returned.