pr feedback

Author: cmsparks

apps/sandbox-container/package.json

@@ -13,9 +13,9 @@
 		"postinstall": "mkdir -p workdir",
 		"test": "vitest",
 		"types": "wrangler types",
-		"eval:dev": "start-server-and-test --expect 404 eval:server http://localhost:8976 'vitest --config vitest.config.evals.ts'",
+		"eval:dev": "start-server-and-test --expect 404 eval:server http://localhost:8976 'vitest --testTimeout=60000 --config vitest.config.evals.ts'",
 		"eval:server": "concurrently \"tsx container/index.ts\" \"wrangler dev --var \"ENVIRONMENT:test\"\"",
-		"eval:ci": "start-server-and-test --expect 404 eval:server http://localhost:8976 'vitest run --config vitest.config.evals.ts'"
+		"eval:ci": "start-server-and-test --expect 404 eval:server http://localhost:8976 'vitest run --testTimeout=60000 --config vitest.config.evals.ts'"
 	},
 	"dependencies": {
 		"@cloudflare/workers-oauth-provider": "0.0.2",

packages/mcp-common/src/cloudflare-oauth-handler.ts

@@ -179,11 +179,13 @@ export function createAuthHandlers({
 
 				return Response.redirect(res.authUrl, 302)
 			} catch (e) {
-				metrics.logEvent(
-					new AuthUser({
-						errorMessage: `Authorize Error: ${(e as any).toString()}`,
-					})
-				)
+				if (e instanceof Error) {
+					metrics.logEvent(
+						new AuthUser({
+							errorMessage: `Authorize Error: ${e.name}: ${e.message}`,
+						})
+					)
+				}
 				if (e instanceof McpError) {
 					return c.text(e.message, { status: e.code })
 				}
@@ -253,12 +255,14 @@ export function createAuthHandlers({
 
 				return Response.redirect(redirectTo, 302)
 			} catch (e) {
-				console.error(e)
-				metrics.logEvent(
-					new AuthUser({
-						errorMessage: `Callback Error: ${(e as any).toString()}`,
-					})
-				)
+				if (e instanceof Error) {
+					console.error(e)
+					metrics.logEvent(
+						new AuthUser({
+							errorMessage: `Callback Error: ${e.name}: ${e.message}`,
+						})
+					)
+				}
 				if (e instanceof McpError) {
 					return c.text(e.message, { status: e.code })
 				}

packages/mcp-common/src/server.ts

@@ -56,7 +56,7 @@ export class CloudflareMCPServer extends McpServer {
 								)
 								return r
 							})
-							.catch((e: any) => {
+							.catch((e: unknown) => {
 								// promise throws
 								this.trackToolCallError(e, name, userId)
 								throw e
@@ -71,7 +71,7 @@ export class CloudflareMCPServer extends McpServer {
 						)
 						return toolCall
 					}
-				} catch (e: any) {
+				} catch (e: unknown) {
 					// non-promise throws
 					this.trackToolCallError(e, name, userId)
 					throw e
@@ -84,7 +84,8 @@ export class CloudflareMCPServer extends McpServer {
 		}
 	}
 
-	private trackToolCallError(e: any, toolName: string, userId?: string) {
+	private trackToolCallError(e: unknown, toolName: string, userId?: string) {
+		// placeholder error code
 		let errorCode = -1
 		if (e instanceof McpError) {
 			errorCode = e.code

packages/mcp-common/vitest.config.ts

@@ -20,7 +20,5 @@ export default defineWorkersProject({
 				},
 			},
 		},
-		// evals are slow!
-		testTimeout: 60000,
 	},
 })

packages/typescript-config/workers.json

@@ -16,8 +16,7 @@
 		"types": [
 			"./worker-configuration.d.ts",
 			"@cloudflare/vitest-pool-workers",
-			"@cloudflare/workers-types/2023-07-01",
-			"@types/node"
+			"@cloudflare/workers-types/2023-07-01"
 		],
 		"resolveJsonModule": true,
 		"allowJs": true,