CASB MCP Server Support #73

frankmeszaros · 2025-04-24T23:20:32Z

MCP Inspector

What

Core CASB MCP Server tool support
Integrations: List All, Get By ID
Assets: List All, Search by Keyword, Filter by Integration Id, Filter by Asset Category

Open questions

Stylistic: does this conform to de facto stylistic guidelines
Tooling implementation: is there a way to make some of my tool calls more re-usable (i struggled to handle optional query params but I'm new to zod and probably didn't iterate on it enough, open to revisions to make this more MCP-conformant if the agent implementations feel like anti-patterns).

Copilot

Pull Request Overview

This PR adds support for the CASB MCP Server by introducing new schemas for integrations and assets along with corresponding API handlers and tool definitions. Key changes include:

Definition of new Zod schemas for integrations, assets, and asset categories.
Implementation of API calls and handlers to support various CASB operations.
Registration of integration tool definitions and updated configuration for testing and deployment.

Reviewed Changes

Copilot reviewed 11 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/mcp-common/src/schemas/cf1-integrations.ts	Added Zod schemas for integrations, assets, and asset categories.
packages/mcp-common/src/api/cf1-integration.ts	Implemented API call functions and handlers for integrations and assets.
apps/cloudflare-one-casb/vitest.config.ts	Configured Vitest for Workers.
apps/cloudflare-one-casb/src/tools/integrations.ts	Defined and registered tool handlers for integration-related operations.
apps/cloudflare-one-casb/src/index.ts	Updated entry point with OAuth provider and tool registration.
apps/cloudflare-one-casb/README.md	Documented MCP server setup and deployment instructions.
apps/cloudflare-one-casb/.eslintrc.cjs	Added ESLint configuration for project consistency.

Files not reviewed (4)

apps/cloudflare-one-casb/.dev.vars.example: Language not supported
apps/cloudflare-one-casb/package.json: Language not supported
apps/cloudflare-one-casb/tsconfig.json: Language not supported
apps/cloudflare-one-casb/wrangler.jsonc: Language not supported

apps/cloudflare-one-casb/README.md

apps/cloudflare-one-casb/package.json

Maximo-Guk · 2025-04-25T00:15:51Z

apps/cloudflare-one-casb/src/index.ts

+export type State = { activeAccountId: string | null }
+export class MyMCP extends McpAgent<Env, State, Props> {
+	// @ts-ignore
+	server = new McpServer({


@cmsparks recently implemented a nifty CloudflareMCPServer which gives us automatic metrics for all tool calls, and changed a bunch of things in our server's index.ts #69

You'll likely want to rebase ontop of latest staging and pull in the changes to index.ts that @cmsparks made to existing apps like workers-observability for ex! , you'll also want to add the analytics binding to your wrangler.jsonc

Yeah I’ll write a quick guide on this tomorrow!

ok i think i have this hooked up (mostly)

apps/cloudflare-one-casb/src/index.ts

Maximo-Guk · 2025-04-25T00:22:23Z

apps/cloudflare-one-casb/src/tools/integrations.ts

+}
+
+// Helper function to handle common error cases and account ID checks
+const withAccountCheck = <T extends Record<string, any>>(agent: MyMCP, handler: ToolHandler<T>) => {


This is pretty cool!!! Wonder if there's any way we could make these types not "any"/ more strict, maybe using typescript generics or something; Also would be pretty cool if we could move this to mcp-common and accept the CloudflareMcpAgent interface, so we can reuse this across other mcp servers!

yeah this was a "vibe coding" addition, i can explore how to add some type strictness around this.

apps/cloudflare-one-casb/src/index.ts

packages/mcp-common/src/api/cf1-integration.ts

apps/cloudflare-one-casb/wrangler.jsonc

…oudflare into fm/v0

wip

…oudflare into fm/v0

Connect Metrics

Fm/v0

packages/mcp-common/src/api/account.ts

frankmeszaros · 2025-04-25T18:46:39Z

apps/cloudflare-one-casb/wrangler.jsonc

+ * For more details on how to configure Wrangler, refer to:
+ * https://developers.cloudflare.com/workers/wrangler/configuration/
+ */
+{


@cmsparks @Maximo-Guk this should be re-factored to have all the metrics bindings included now 👍

packages/mcp-common/src/api/account.ts

cmsparks · 2025-04-25T18:49:09Z

apps/cloudflare-one-casb/src/index.ts

+
+export type State = { activeAccountId: string | null }
+export class CASBMCP extends McpAgent<Env, State, Props> {
+	server = new CloudflareMCPServer(undefined, env.MCP_METRICS, {


Ty for figuring this out without my write up!

One small thing, could you move this into the init function and pass in the userId with this.props.user.id like we do in the observability server: https://github.com/cloudflare/mcp-server-cloudflare/blob/main/apps/workers-observability/src/index.ts#L34-L59

Otherwise, lgtm!

packages/mcp-common/src/api/account.ts

Fix Metrics Server Init

Maximo-Guk · 2025-04-26T01:46:00Z

apps/cloudflare-one-casb/src/index.ts

+			version: this.env.MCP_SERVER_VERSION,
+		})
+
+		registerAccountTools(this as unknown as CloudflareMcpAgent)


Curious why you're having to cast this as unknown? It looks like your CASBMCP agent should line up with the CloudflareMCPAgent interface 🤔

…oudflare

frankmeszaros and others added 4 commits April 23, 2025 20:16

Initial Commit

246f60f

adding common files

b476309

Working MCP Inspector CF1 CASB Toolchain

5827f18

fixes

3db8c64

frankmeszaros added the enhancement New feature or request label Apr 24, 2025

frankmeszaros self-assigned this Apr 24, 2025

frankmeszaros requested review from Maximo-Guk, cf-ml, cmsparks and Copilot April 24, 2025 23:22

Copilot AI reviewed Apr 24, 2025

View reviewed changes

Maximo-Guk reviewed Apr 25, 2025

View reviewed changes

frankmeszaros force-pushed the main branch from b9d8fd1 to 84451f7 Compare April 25, 2025 01:29

fix pnpm

2d2350c

frankmeszaros force-pushed the main branch from 84451f7 to 2d2350c Compare April 25, 2025 02:44

frankmeszaros and others added 10 commits April 24, 2025 20:06

wip

f9e6923

Merge branch 'cloudflare:main' into main

5e08254

Merge branch 'main' of https://github.com/frankmeszaros/mcp-server-cl…

dafd609

…oudflare into fm/v0

Merge pull request #1 from frankmeszaros/fm/v0

7b030c5

wip

Merge branch 'main' of https://github.com/frankmeszaros/mcp-server-cl…

ec28ab9

…oudflare into fm/v0

Merge branch 'main' of https://github.com/frankmeszaros/mcp-server-cl…

3631999

…oudflare into fm/v0

Merge pull request #2 from frankmeszaros/fm/v0

af09d94

Connect Metrics

remove junk comments

e306c73

Refactor withAccount into shared repo

7619dda

Merge pull request #3 from frankmeszaros/fm/v0

76ce174

Fm/v0

frankmeszaros commented Apr 25, 2025

View reviewed changes

packages/mcp-common/src/api/account.ts Show resolved Hide resolved

frankmeszaros commented Apr 25, 2025

View reviewed changes

packages/mcp-common/src/api/account.ts Outdated Show resolved Hide resolved

cmsparks approved these changes Apr 25, 2025

View reviewed changes

packages/mcp-common/src/api/account.ts Outdated Show resolved Hide resolved

frankmeszaros and others added 5 commits April 25, 2025 18:12

Fix Metrics Server Init

f963b7e

Merge pull request #4 from frankmeszaros/fm/v0

9395a80

Fix Metrics Server Init

pnpm-lock.yaml

b0f334d

Lock with new changes

f505d4c

never mind

ca00607

Maximo-Guk reviewed Apr 26, 2025

View reviewed changes

Maximo-Guk approved these changes Apr 26, 2025

View reviewed changes

never mind

e57d80b

frankmeszaros force-pushed the main branch from ca00607 to e57d80b Compare April 26, 2025 04:11

frankmeszaros added 3 commits April 25, 2025 21:12

Merge branch 'main' of https://github.com/frankmeszaros/mcp-server-cl…

0fe1172

…oudflare

fix: pnpm-lock and gitignore

cd1ac05

fix: pnpm-lock and gitignore

b5ebd44

frankmeszaros merged commit b3df874 into cloudflare:main Apr 29, 2025

CASB MCP Server Support #73

CASB MCP Server Support #73

Uh oh!

Conversation

frankmeszaros commented Apr 24, 2025

MCP Inspector

What

Open questions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Maximo-Guk Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

cmsparks Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

frankmeszaros Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Maximo-Guk Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frankmeszaros Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frankmeszaros Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cmsparks Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Maximo-Guk Apr 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Maximo-Guk Apr 25, 2025 •

edited

Loading

frankmeszaros Apr 25, 2025 •

edited

Loading