Don't throw loud error on Request#cf fetch failure, closes #224

Author: mrbbot

packages/http-server/src/plugin.ts

@@ -13,6 +13,7 @@ import {
   SetupResult,
   defaultClock,
 } from "@miniflare/shared";
+import { dim } from "kleur/colors";
 import type { Attributes, Options } from "selfsigned";
 import { RequestInfo, fetch } from "undici";
 import { getAccessibleHosts } from "./helpers";
@@ -304,9 +305,13 @@ export class HTTPPlugin extends Plugin<HTTPOptions> implements HTTPOptions {
       // Write cf so we can reuse it later
       await fs.mkdir(path.dirname(cfPath), { recursive: true });
       await fs.writeFile(cfPath, cfText, "utf8");
-      this.ctx.log.info("Updated Request cf object cache!");
+      this.ctx.log.info("Updated `Request.cf` object cache!");
     } catch (e: any) {
-      this.ctx.log.error(e);
+      this.ctx.log.warn(
+        "Unable to fetch the `Request.cf` object! Falling back to a default placeholder...\n" +
+          "To always use the placeholder, set the `--no-cf-fetch`/`cfFetch: false` option.\n" +
+          dim(e.cause ? e.cause.stack : e.stack)
+      );
     }
   }
 

packages/http-server/test/plugin.spec.ts

@@ -236,7 +236,7 @@ test("HTTPPlugin: setupCf: cf fetch caches cf.json at default location", async (
   });
   const cf = await fs.readFile(cfPath, "utf8");
   t.is(cf, '{"colo": "LHR"}');
-  t.is(log.logsAtLevel(LogLevel.INFO)[0], "Updated Request cf object cache!");
+  t.is(log.logsAtLevel(LogLevel.INFO)[0], "Updated `Request.cf` object cache!");
 });
 test("HTTPPlugin: setupCf: cf fetch caches cf.json at custom location", async (t) => {
   const tmp = await useTmp(t);
@@ -258,7 +258,7 @@ test("HTTPPlugin: setupCf: cf fetch caches cf.json at custom location", async (t
   t.false(existsSync(defaultCfPath));
   const cf = await fs.readFile(customCfPath, "utf8");
   t.is(cf, '{"colo": "LHR"}');
-  t.is(log.logsAtLevel(LogLevel.INFO)[0], "Updated Request cf object cache!");
+  t.is(log.logsAtLevel(LogLevel.INFO)[0], "Updated `Request.cf` object cache!");
 });
 test("HTTPPlugin: setupCf: cf fetch reuses cf.json", async (t) => {
   const tmp = await useTmp(t);
@@ -300,7 +300,7 @@ test("HTTPPlugin: setupCf: cf fetch refetches cf.json if stale", async (t) => {
   });
   const cf = await fs.readFile(cfPath, "utf8");
   t.is(cf, '{"colo": "MAN"}');
-  t.is(log.logsAtLevel(LogLevel.INFO)[0], "Updated Request cf object cache!");
+  t.is(log.logsAtLevel(LogLevel.INFO)[0], "Updated `Request.cf` object cache!");
 });
 
 test("HTTPPlugin: setupHttps: httpsOptions undefined if https disabled", async (t) => {