Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 428fd61

Browse files
gonzaloriestramrbbotCherry
committed
Upgrade undici to 5.5.1 (#286)
* Upgrade undici to 5.5.1 * Remove header filtering hack, ref #288 Co-authored-by: MrBBot <[email protected]> Co-authored-by: Cherry <[email protected]> (cherry picked from commit 979e875)
1 parent 75abe07 commit 428fd61

File tree

9 files changed

+40
-54
lines changed

9 files changed

+40
-54
lines changed

package-lock.json

Lines changed: 33 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cache/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@miniflare/core": "2.5.0",
3939
"@miniflare/shared": "2.5.0",
4040
"http-cache-semantics": "^4.1.0",
41-
"undici": "5.3.0"
41+
"undici": "5.5.1"
4242
},
4343
"devDependencies": {
4444
"@miniflare/shared-test": "2.5.0",

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"dotenv": "^10.0.0",
4646
"kleur": "^4.1.4",
4747
"set-cookie-parser": "^2.4.8",
48-
"undici": "5.3.0",
48+
"undici": "5.5.1",
4949
"urlpattern-polyfill": "^4.0.3"
5050
},
5151
"devDependencies": {

packages/core/src/standards/http.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,6 @@ import {
5353
} from "./helpers";
5454
import { kContentLength } from "./streams";
5555

56-
// `undici` restricts which headers can be added to/gotten from a `Headers`
57-
// object in `Request`/`Response`s. Whilst this restriction makes sense for
58-
// security reasons in the browser, it doesn't server side.
59-
//
60-
// Note: this is a massive hack. I'm fully expecting it to break in future
61-
// `undici` versions and need to be updated, but that's why we pin our `undici`
62-
// version and have tests... :) Right?
63-
const constants: {
64-
readonly forbiddenHeaderNames: string[];
65-
readonly forbiddenResponseHeaderNames: string[];
66-
} = require("undici/lib/fetch/constants.js");
67-
constants.forbiddenHeaderNames.length = 0;
68-
constants.forbiddenResponseHeaderNames.length = 0;
69-
7056
// We need these for making Request's Headers immutable
7157
const fetchSymbols: {
7258
readonly kState: unique symbol;

packages/durable-objects/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@miniflare/core": "2.5.0",
3939
"@miniflare/shared": "2.5.0",
4040
"@miniflare/storage-memory": "2.5.0",
41-
"undici": "5.3.0"
41+
"undici": "5.5.1"
4242
},
4343
"devDependencies": {
4444
"@miniflare/cache": "2.5.0",

packages/html-rewriter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@miniflare/core": "2.5.0",
3939
"@miniflare/shared": "2.5.0",
4040
"html-rewriter-wasm": "^0.4.1",
41-
"undici": "5.3.0"
41+
"undici": "5.5.1"
4242
},
4343
"devDependencies": {
4444
"@miniflare/shared-test": "2.5.0"

packages/http-server/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@miniflare/web-sockets": "2.5.0",
4141
"kleur": "^4.1.4",
4242
"selfsigned": "^2.0.0",
43-
"undici": "5.3.0",
43+
"undici": "5.5.1",
4444
"ws": "^8.2.2",
4545
"youch": "^2.2.2"
4646
},

packages/miniflare/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"kleur": "^4.1.4",
6464
"semiver": "^1.1.0",
6565
"source-map-support": "^0.5.20",
66-
"undici": "5.3.0"
66+
"undici": "5.5.1"
6767
},
6868
"devDependencies": {
6969
"@miniflare/shared-test": "2.5.0",

packages/web-sockets/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@miniflare/core": "2.5.0",
3939
"@miniflare/shared": "2.5.0",
4040
"ws": "^8.2.2",
41-
"undici": "5.3.0"
41+
"undici": "5.5.1"
4242
},
4343
"devDependencies": {
4444
"@miniflare/shared-test": "2.5.0",

0 commit comments

Comments
 (0)