Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit 697f600

Browse files
authored
Disable shell: true when using NativeRuntime (#445)
When `dispose()`ing a `NativeRuntime`, I've observed the `workerd` process not being terminated properly with this option enabled. We don't actually need it, since we're specifying an absolute path to the `workerd` binary anyway. From a user-perspective, this will help fix issues in Wrangler where reloading crashes with a port-in-use error, or where pressing 'x' doesn't actually exit.
1 parent 32db23b commit 697f600

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

packages/tre/src/runtime/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ class NativeRuntime extends Runtime {
119119
// 2. Start new process
120120
const runtimeProcess = childProcess.spawn(this.#command, this.#args, {
121121
stdio: "pipe",
122-
shell: true,
123122
});
124123
this.#process = runtimeProcess;
125124
this.#processExitPromise = waitForExit(runtimeProcess);

0 commit comments

Comments
 (0)