Remove opaqueredirect Response handling, ref #177

`undici` no longer returns `opaqueredirect` `Response`s when
`redirect` is set to `manual` as of nodejs/undici#1210.

Author: mrbbot

packages/core/src/standards/http.ts

@@ -823,32 +823,11 @@ export async function fetch(
   }
 
   // Convert the response to our hybrid Response
-  let res: Response;
-  if (baseRes.type === "opaqueredirect") {
-    // Unpack opaque responses. This restriction isn't needed server-side,
-    // and Cloudflare doesn't support Response types anyway.
-    // @ts-expect-error symbol properties are not included in type definitions
-    const internalResponse = baseRes[fetchSymbols.kState].internalResponse;
-    const headersList = internalResponse.headersList;
-    assert(headersList.length % 2 === 0);
-    const headers = new Headers();
-    for (let i = 0; i < headersList.length; i += 2) {
-      headers.append(headersList[i], headersList[i + 1]);
-    }
-    // Cloudflare returns a body here, but undici aborts the stream so
-    // unfortunately it's unusable :(
-    res = new Response(null, {
-      status: internalResponse.status,
-      statusText: internalResponse.statusText,
-      headers,
-    });
-  } else {
+  const res = new Response(
     // https://fetch.spec.whatwg.org/#null-body-status
-    res = new Response(
-      nullBodyStatus.includes(baseRes.status) ? null : baseRes.body,
-      baseRes
-    );
-  }
+    nullBodyStatus.includes(baseRes.status) ? null : baseRes.body,
+    baseRes
+  );
   // @ts-expect-error internal kGuard isn't included in type definitions
   res.headers[fetchSymbols.kGuard] = "immutable";
 

packages/core/test/standards/http.spec.ts

@@ -1036,6 +1036,8 @@ test('fetch: returns full Response for "manual" redirect', async (t) => {
   t.is(res.statusText, "Found");
   t.is(res.headers.get("Location"), `/?n=2`);
   t.is(res.headers.get("Set-Cookie"), "n=3");
+  // https://github.com/cloudflare/miniflare/issues/177
+  t.is(res.url, url.href);
 });
 test("fetch: waits for input gate to open before returning", async (t) => {
   const upstream = (await useServer(t, (req, res) => res.end("upstream"))).http;