Hide ServiceWorkerGlobalScope#dispose

Author: mrbbot

packages/core/src/index.ts

@@ -36,6 +36,7 @@ import {
   kAddModuleScheduledListener,
   kDispatchFetch,
   kDispatchScheduled,
+  kDispose,
   withImmutableHeaders,
   withStringFormDataFiles,
 } from "./standards";
@@ -419,7 +420,7 @@ export class MiniflareCore<
     const { modules, processedModuleRules } = this.#instances!.CorePlugin;
 
     // Clean up process-wide promise rejection event listeners
-    this.#globalScope?.dispose();
+    this.#globalScope?.[kDispose]();
     // Create new global scope on each reload
     const globalScope = new ServiceWorkerGlobalScope(
       this.log,

packages/core/src/standards/event.ts

@@ -152,6 +152,7 @@ export const kAddModuleScheduledListener = Symbol(
 );
 export const kDispatchFetch = Symbol("kDispatchFetch");
 export const kDispatchScheduled = Symbol("kDispatchScheduled");
+export const kDispose = Symbol("kDispose");
 
 export class PromiseRejectionEvent extends Event {
   readonly promise: Promise<any>;
@@ -444,7 +445,7 @@ export class ServiceWorkerGlobalScope extends WorkerGlobalScope {
     super.dispatchEvent(event);
   };
 
-  dispose(): void {
+  [kDispose](): void {
     if (this.#unhandledRejectionListeners.size > 0) {
       this.#log.verbose("Removing process unhandledRejection listener...");
       process.removeListener(

packages/core/test/standards/event.promise.spec.ts

@@ -2,6 +2,7 @@ import {
   PromiseRejectionEvent,
   ServiceWorkerGlobalScope,
   WorkerGlobalScopeEventMap,
+  kDispose,
 } from "@miniflare/core";
 import { LogLevel, TypedEventListener } from "@miniflare/shared";
 import { TestLog, triggerPromise } from "@miniflare/shared-test";
@@ -107,7 +108,7 @@ const processListenerDisposeMacro: Macro<[event: string], Context> = async (
 
   // Try disposing when listener that hasn't been added yet
   t.is(process.listenerCount(event), 0);
-  globalScope.dispose();
+  globalScope[kDispose]();
   t.is(process.listenerCount(event), 0);
   t.deepEqual(log.logs, []);
 
@@ -119,7 +120,7 @@ const processListenerDisposeMacro: Macro<[event: string], Context> = async (
   ]);
   log.logs = [];
 
-  globalScope.dispose();
+  globalScope[kDispose]();
   t.is(process.listenerCount(event), 0);
   t.deepEqual(log.logs, [
     [LogLevel.VERBOSE, `Removing process ${event} listener...`],

packages/core/test/standards/event.spec.ts

@@ -108,7 +108,6 @@ test("ServiceWorkerGlobalScope: hides implementation details", (t) => {
     "KEY", // binding
     "addEventListener",
     "dispatchEvent",
-    "dispose",
     "global",
     "globalThis",
     "removeEventListener",