Fix detection of imports in string scripts without scriptPaths

Module resolution requires a path to resolve modules to. When users
just specify a `script`, we don't have this. Miniflare was meant to
block importing in this case, but the detection was using the full
module path (e.g. `/path/to/<script:0>`) where it should've been
using the name (e.g. `<script:0>`).

Author: mrbbot

packages/miniflare/src/plugins/core/modules.ts

@@ -210,18 +210,18 @@ export class ModuleLocator {
     // noinspection JSUnusedGlobalSymbols
     const visitors = {
       ImportDeclaration: (node: estree.ImportDeclaration) => {
-        this.#visitModule(modulePath, type, node.source);
+        this.#visitModule(modulePath, name, type, node.source);
       },
       ExportNamedDeclaration: (node: estree.ExportNamedDeclaration) => {
         if (node.source != null) {
-          this.#visitModule(modulePath, type, node.source);
+          this.#visitModule(modulePath, name, type, node.source);
         }
       },
       ExportAllDeclaration: (node: estree.ExportAllDeclaration) => {
-        this.#visitModule(modulePath, type, node.source);
+        this.#visitModule(modulePath, name, type, node.source);
       },
       ImportExpression: (node: estree.ImportExpression) => {
-        this.#visitModule(modulePath, type, node.source);
+        this.#visitModule(modulePath, name, type, node.source);
       },
       CallExpression: isESM
         ? undefined
@@ -233,7 +233,7 @@ export class ModuleLocator {
               node.callee.name === "require" &&
               argument !== undefined
             ) {
-              this.#visitModule(modulePath, type, argument);
+              this.#visitModule(modulePath, name, type, argument);
             }
           },
     };
@@ -242,10 +242,11 @@ export class ModuleLocator {
 
   #visitModule(
     referencingPath: string,
+    referencingName: string,
     referencingType: JavaScriptModuleRuleType,
     specExpression: estree.Expression | estree.SpreadElement
   ) {
-    if (maybeGetStringScriptPathIndex(referencingPath) !== undefined) {
+    if (maybeGetStringScriptPathIndex(referencingName) !== undefined) {
       const prefix = getResolveErrorPrefix(referencingPath);
       throw new MiniflareCoreError(
         "ERR_MODULE_STRING_SCRIPT",

packages/miniflare/test/index.spec.ts

@@ -464,6 +464,7 @@ test("Miniflare: `node:`, `cloudflare:` and `workerd:` modules", async (t) => {
   const mf = new Miniflare({
     modules: true,
     compatibilityFlags: ["nodejs_compat", "rtti_api"],
+    scriptPath: "index.mjs",
     script: `
     import assert from "node:assert";
     import { Buffer } from "node:buffer";