Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit bee57ff

Browse files
authored
Bump undici to 5.28.2 (#742)
Addresses low severity `npm audit` warning: GHSA-wqq4-5wpv-mx2g Fixes #607 Fixes #738
1 parent a904927 commit bee57ff

File tree

11 files changed

+56
-43
lines changed

11 files changed

+56
-43
lines changed

package-lock.json

Lines changed: 40 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cache/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@miniflare/core": "2.14.1",
3939
"@miniflare/shared": "2.14.1",
4040
"http-cache-semantics": "^4.1.0",
41-
"undici": "5.20.0"
41+
"undici": "5.28.2"
4242
},
4343
"devDependencies": {
4444
"@miniflare/shared-test": "2.14.1",

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"dotenv": "^10.0.0",
4747
"kleur": "^4.1.4",
4848
"set-cookie-parser": "^2.4.8",
49-
"undici": "5.20.0",
49+
"undici": "5.28.2",
5050
"urlpattern-polyfill": "^4.0.3"
5151
},
5252
"devDependencies": {

packages/core/src/standards/http.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -796,14 +796,10 @@ class MiniflareDispatcher extends Dispatcher {
796796
options: Dispatcher.DispatchOptions,
797797
handler: Dispatcher.DispatchHandlers
798798
): boolean {
799+
// Remove any default fetch headers that the user didn't explicitly set,
800+
// `headers` has the form `["key1", "value1", "key2", "value2", ...]`
799801
const headers = options.headers;
800-
if (headers) {
801-
// Note: I'm fully expecting this to break in future undici versions
802-
// and need to be updated, but that's why we pin our undici version and
803-
// have tests
804-
assert(Array.isArray(headers));
805-
// Remove any default fetch headers that the user didn't explicitly set,
806-
// `headers` has the form `["key1", "value1", "key2", "value2", ...]`
802+
if (Array.isArray(headers)) {
807803
let i = 0;
808804
while (i < headers.length) {
809805
if (this.removeHeaders.includes(headers[i].toLowerCase())) {
@@ -812,6 +808,10 @@ class MiniflareDispatcher extends Dispatcher {
812808
i += 2;
813809
}
814810
}
811+
} else if (headers != null) {
812+
for (const key in headers) {
813+
if (this.removeHeaders.includes(key.toLowerCase())) delete headers[key];
814+
}
815815
}
816816
return this.inner.dispatch(options, handler);
817817
}

packages/durable-objects/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@miniflare/core": "2.14.1",
3939
"@miniflare/shared": "2.14.1",
4040
"@miniflare/storage-memory": "2.14.1",
41-
"undici": "5.20.0"
41+
"undici": "5.28.2"
4242
},
4343
"devDependencies": {
4444
"@miniflare/cache": "2.14.1",

packages/html-rewriter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@miniflare/core": "2.14.1",
3939
"@miniflare/shared": "2.14.1",
4040
"html-rewriter-wasm": "^0.4.1",
41-
"undici": "5.20.0"
41+
"undici": "5.28.2"
4242
},
4343
"devDependencies": {
4444
"@miniflare/shared-test": "2.14.1"

packages/http-server/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@miniflare/web-sockets": "2.14.1",
4141
"kleur": "^4.1.4",
4242
"selfsigned": "^2.0.0",
43-
"undici": "5.20.0",
43+
"undici": "5.28.2",
4444
"ws": "^8.2.2",
4545
"youch": "^2.2.2"
4646
},

packages/miniflare/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"kleur": "^4.1.4",
6767
"semiver": "^1.1.0",
6868
"source-map-support": "^0.5.20",
69-
"undici": "5.20.0"
69+
"undici": "5.28.2"
7070
},
7171
"devDependencies": {
7272
"@miniflare/shared-test": "2.14.1",

packages/r2/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"dependencies": {
3838
"@miniflare/core": "2.14.1",
3939
"@miniflare/shared": "2.14.1",
40-
"undici": "5.20.0"
40+
"undici": "5.28.2"
4141
},
4242
"devDependencies": {
4343
"@miniflare/shared-test": "2.14.1"

packages/vitest-environment-miniflare/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"@miniflare/queues": "2.14.1",
4242
"@miniflare/shared": "2.14.1",
4343
"@miniflare/shared-test-environment": "2.14.1",
44-
"undici": "5.20.0"
44+
"undici": "5.28.2"
4545
},
4646
"peerDependencies": {
4747
"vitest": ">=0.23.0"

0 commit comments

Comments
 (0)