Ignore invalid favicon.ico.rsc nodejs functions being generated by the Vercel CLI (since 46.1.0) (#983)

Author: dario-piotrowicz

.changeset/twelve-avocados-sip.md

@@ -0,0 +1,5 @@
+---
+'@cloudflare/next-on-pages': patch
+---
+
+Ignore invalid favicon.ico.rsc nodejs functions being generated by the Vercel CLI (since 46.1.0)

packages/next-on-pages/src/buildApplication/processVercelFunctions/invalidFunctions.ts

@@ -43,6 +43,8 @@ export async function checkInvalidFunctions(
 
 	await tryToFixI18nFunctions(collectedFunctions, opts);
 
+	await fixFaviconInvalidRSCFuncFunction(collectedFunctions);
+
 	await tryToFixInvalidFuncsWithValidIndexAlternative(collectedFunctions);
 	await tryToFixInvalidDynamicISRFuncs(collectedFunctions);
 
@@ -138,6 +140,28 @@ async function fixActionInvalidFuncFunctions({
 	}
 }
 
+/**
+ * Since 46.1.0 the Vercel CLI generates incorrect favicon RSC functions,
+ * they are safe to ignore without any downside, this functions makes sure
+ * that such favicon RSC functions do get ignored
+ *
+ * @param collectedFunctions Collected functions from the Vercel build output.
+ */
+async function fixFaviconInvalidRSCFuncFunction({
+	invalidFunctions,
+	ignoredFunctions,
+}: CollectedFunctions): Promise<void> {
+	for (const [fullPath, fnInfo] of invalidFunctions.entries()) {
+		if (fnInfo.relativePath === '/favicon.ico.rsc.func') {
+			ignoredFunctions.set(fullPath, {
+				reason: 'invalid favicon.ico.rsc.func functions are ignored',
+				...fnInfo,
+			});
+			invalidFunctions.delete(fullPath);
+		}
+	}
+}
+
 /**
  * In the App router, error boundaries are implemented as client components
  * (see: https://nextjs.org/docs/app/api-reference/file-conventions/error), meaning that they