Remove UDP

Author: mattrobenolt

README.md

@@ -1,10 +1,10 @@
 raven-lua
 =========
 
-A small Lua interface to [Sentry](http://sentry.readthedocs.org/) that supports
-both the HTTP and UDP interfaces and also has a helpful wrapper function
-`call()` that takes any arbitrary Lua function (with arguments) and executes
-it, traps any errors and reports it automatically to Sentry.
+A small Lua interface to [Sentry](https://sentry.readthedocs.org/) that also
+has a helpful wrapper function `call()` that takes any arbitrary Lua function
+(with arguments) and executes it, traps any errors and reports it automatically
+to Sentry.
 
 Synopsis
 ========
@@ -13,9 +13,7 @@ Synopsis
 
     local raven = require "raven"
 
-    -- Both HTTP protocol and UDP protocol are supported. For example:
     -- http://pub:secret@127.0.0.1:8080/sentry/proj-id
-    -- udp://pub:secret@127.0.0.1:8080/sentry/proj-id
     local rvn = raven:new("http://pub:secret@127.0.0.1:8080/sentry/proj-id", {
        tags = { foo = "bar" },
     })

docs/index.html

@@ -106,9 +106,7 @@ <h3>Parameters:</h3>
         <li><span class="parameter">dsn</span>
           The DSN of the Sentry instance with this format:
              <pre>{PROTOCOL}://{PUBLIC_KEY}:{SECRET_KEY}???/{PATH}{PROJECT_ID}</pre>
-             Both HTTP protocol and UDP protocol are supported. For example:
              <pre>http://pub:secret@127.0.0.1:8080/sentry/proj-id</pre>
-             <pre>udp://pub:secret@127.0.0.1:8080/sentry/proj-id</pre>
         </li>
         <li><span class="parameter">conf</span>
          client configuration. Conf should be a hash table. Possiable

raven.lua

@@ -214,9 +214,7 @@ _M._parse_dsn = _parse_dsn
 -- @param self raven client
 -- @param dsn  The DSN of the Sentry instance with this format:
 --             <pre>{PROTOCOL}://{PUBLIC_KEY}:{SECRET_KEY}@{HOST}/{PATH}{PROJECT_ID}</pre>
---             Both HTTP protocol and UDP protocol are supported. For example:
 --             <pre>http://pub:secret@127.0.0.1:8080/sentry/proj-id</pre>
---             <pre>udp://pub:secret@127.0.0.1:8080/sentry/proj-id</pre>
 -- @param conf client configuration. Conf should be a hash table. Possiable
 --             keys are: "tags", "logger". For example:
 --             <pre>{ tags = { foo = "bar", abc = "def" }, logger = "myLogger" }</pre>
@@ -390,9 +388,7 @@ function _M.send_report(self, json, conf)
 
    local json_str = json_encode(json)
    local ok, err
-   if self.protocol == "udp" then
-      ok, err = self:udp_send(json_str)
-   elseif self.protocol == "http" then
+   if self.protocol == "http" then
       ok, err = self:http_send(json_str)
    else
       error("protocol not implemented yet: " .. self.protocol)
@@ -487,44 +483,9 @@ function _M.gen_capture_err(self)
    end
 end
 
--- UDP request template
-local xsentryauth_udp="Sentry sentry_version=2.0,sentry_client=%s,"
-      .. "sentry_timestamp=%s,sentry_key=%s,sentry_secret=%s\n\n%s\n"
-
 -- HTTP request template
 local xsentryauth_http = "POST %s HTTP/1.0\r\nHost: %s\r\nConnection: close\r\nContent-Type: application/json\r\nContent-Length: %d\r\nUser-Agent: %s\r\nX-Sentry-Auth: Sentry sentry_version=5, sentry_client=%s, sentry_timestamp=%s, sentry_key=%s, sentry_secret=%s\r\n\r\n%s"
 
--- udp_send: actually sends the structured data to the Sentry server using
--- UDP
-function _M.udp_send(self, json_str)
-   local ok, err
-
-   if not self.sock then
-      local sock = socket.udp()
-
-      if sock then
-         ok, err = sock:setpeername(self.host, self.port)
-         if not ok then
-            return nil, err
-         end
-         self.sock = sock
-      end
-   end
-
-   local bytes
-
-   if self.sock then
-      local content = string_format(xsentryauth_udp,
-                                   self.client_id,
-                                   iso8601(),
-                                   self.public_key,
-                                   self.secret_key,
-                                   json_str)
-      bytes, err = self.sock:send(content)
-   end
-   return bytes, err
-end
-
 -- http_send_core: do the actual network send. Expects an already
 -- connected socket.
 function _M.http_send_core(self, json_str)

tests/test_exceptions.lua

@@ -13,7 +13,6 @@ module("test_exceptions", lunit.testcase)
 local rvn
 local port = 29999
 local dsn_http = "http://pub:secret@127.0.0.1:" .. port .. "/sentry/proj-id"
-local dsn_udp = "udp://pub:secret@127.0.0.1:" .. port .. "/sentry/proj-id"
 
 function test_capture_message_connection_refused_http()
    local rvn = raven:new(dsn_http)
@@ -34,10 +33,3 @@ function test_capture_message_connection_refused_http_xpcall()
    assert_nil(id)
    assert_equal("connection refused", err)
 end
-
-function test_capture_message_connection_refused_udp()
-   local rvn = raven:new(dsn_udp)
-   local id, err = rvn:captureMessage("Sentry is a realtime event logging and aggregation platform.")
-
-   assert_not_nil(id)
-end