fix file operations

Author: threepointone

.changeset/little-toes-retire.md

@@ -0,0 +1,5 @@
+---
+"@cloudflare/sandbox": patch
+---
+
+fix file operations

examples/basic/src/index.ts

@@ -15,6 +15,14 @@ export default {
       return sandbox.containerFetch(request);
     }
 
+    if (pathname.startsWith("/test-file")) {
+      // write a file to the sandbox
+      const sandbox = getSandbox(env.Sandbox, "my-sandbox");
+      await sandbox.writeFile("/test-file.txt", "Hello, world!" + Date.now());
+      const file = await sandbox.readFile("/test-file.txt");
+      return new Response(file!.content, { status: 200 });
+    }
+
     return new Response("Not found", { status: 404 });
   },
 };

packages/sandbox/src/client.ts

@@ -203,7 +203,9 @@ export class HttpClient {
     path: string,
     options?: RequestInit
   ): Promise<Response> {
-    const url = this.options.stub ? `stub:${path}` : `${this.baseUrl}${path}`;
+    const url = this.options.stub
+      ? `http://localhost:${this.options.port}${path}`
+      : `${this.baseUrl}${path}`;
     const method = options?.method || "GET";
 
     console.log(`[HTTP Client] Making ${method} request to ${url}`);
@@ -212,15 +214,23 @@ export class HttpClient {
       let response: Response;
 
       if (this.options.stub) {
-        response = await this.options.stub.containerFetch(this.baseUrl + path, options, this.options.port);
+        response = await this.options.stub.containerFetch(
+          url,
+          options,
+          this.options.port
+        );
       } else {
-        response = await fetch(this.baseUrl + path, options);
+        response = await fetch(url, options);
       }
 
-      console.log(`[HTTP Client] Response: ${response.status} ${response.statusText}`);
+      console.log(
+        `[HTTP Client] Response: ${response.status} ${response.statusText}`
+      );
 
       if (!response.ok) {
-        console.error(`[HTTP Client] Request failed: ${method} ${url} - ${response.status} ${response.statusText}`);
+        console.error(
+          `[HTTP Client] Request failed: ${method} ${url} - ${response.status} ${response.statusText}`
+        );
       }
 
       return response;

packages/sandbox/src/index.ts

@@ -19,7 +19,9 @@ export class Sandbox<Env = unknown> extends Container<Env> {
         );
       },
       onCommandStart: (command, args) => {
-        console.log(`[Container] Command started: ${command} ${args.join(" ")}`);
+        console.log(
+          `[Container] Command started: ${command} ${args.join(" ")}`
+        );
       },
       onError: (error, command, args) => {
         console.error(`[Container] Command error: ${error}`);
@@ -74,7 +76,7 @@ export class Sandbox<Env = unknown> extends Container<Env> {
 
   async mkdir(
     path: string,
-    options: { recursive?: boolean; stream?: boolean }
+    options: { recursive?: boolean; stream?: boolean } = {}
   ) {
     if (options?.stream) {
       return this.client.mkdirStream(path, options.recursive);
@@ -85,15 +87,15 @@ export class Sandbox<Env = unknown> extends Container<Env> {
   async writeFile(
     path: string,
     content: string,
-    options: { encoding?: string; stream?: boolean }
+    options: { encoding?: string; stream?: boolean } = {}
   ) {
     if (options?.stream) {
       return this.client.writeFileStream(path, content, options.encoding);
     }
     return this.client.writeFile(path, content, options.encoding);
   }
 
-  async deleteFile(path: string, options: { stream?: boolean }) {
+  async deleteFile(path: string, options: { stream?: boolean } = {}) {
     if (options?.stream) {
       return this.client.deleteFileStream(path);
     }
@@ -103,7 +105,7 @@ export class Sandbox<Env = unknown> extends Container<Env> {
   async renameFile(
     oldPath: string,
     newPath: string,
-    options: { stream?: boolean }
+    options: { stream?: boolean } = {}
   ) {
     if (options?.stream) {
       return this.client.renameFileStream(oldPath, newPath);
@@ -114,7 +116,7 @@ export class Sandbox<Env = unknown> extends Container<Env> {
   async moveFile(
     sourcePath: string,
     destinationPath: string,
-    options: { stream?: boolean }
+    options: { stream?: boolean } = {}
   ) {
     if (options?.stream) {
       return this.client.moveFileStream(sourcePath, destinationPath);
@@ -124,7 +126,7 @@ export class Sandbox<Env = unknown> extends Container<Env> {
 
   async readFile(
     path: string,
-    options: { encoding?: string; stream?: boolean }
+    options: { encoding?: string; stream?: boolean } = {}
   ) {
     if (options?.stream) {
       return this.client.readFileStream(path, options.encoding);