Listing files hangs indefinetely

[moneydance]

When calling listFiles the promise never resolves. Other file actions like reading and writing a file works

calling

    const files = await workspace.listFiles(fullPath, {
        recursive,
        includeHidden,
      });

using

"@cloudflare/sandbox": "^0.4.11",

[whoiskatrin]

@moneydance hey! could you please provide a repository with some steps to reproduce this? we can't reproduce the same behaviour on our side

[moneydance]

Yes definitely! Will do today!

[moneydance]

https://github.com/moneydance/cf-sandbox-read-file-minimal-repo heres the minimal repo. I think it may have to do with how I'm starting my preview server in the extended Sandbox https://github.com/moneydance/cf-sandbox-read-file-minimal-repo/blob/main/projects/file-worker/src/workspace.ts#L97

Hmm yeah that's definitely it when I remove the code to startup the dev server from the Workspace constructor it doesn't hang

heres a branch with the working version https://github.com/moneydance/cf-sandbox-read-file-minimal-repo/tree/working-version

Any idea what causes the hanging behavior when I start the server up in the constructor? It appears to just not like a process being kicked off there.

[moneydance]

https://github.com/moneydance/cf-sandbox-read-file-minimal-repo/blob/bp/alternate/projects/file-worker/src/workspace.ts#L87 hmm took an alternate approach and moved the starting of the preview server in the provision and it still hangs.

Ideally I'd like to start the preview server whenever a container is requested so it's ready to go right away for a preview if one is asked for later (it will be every time). Is there a prescribed way for kicking off a process on sandbox creation?

[moneydance]

Hmm starting the server in a seperate session

  const serverSession = await this.createSession({
      id: 'serverSession',
      cwd: '/workspace',
    });
    const process = await serverSession.startProcess(
      'pnpm --filter react-sandbox-renderer start',
    );

resolved the issue I think there's maybe still a bug here with starting a server on the default session though.

[whoiskatrin]

@ghostwriternr let's check this

[ghostwriternr]

Thanks for the detailed repro, @moneydance! This was super super helpful to debug, and was indeed a critical issue with the SDK. The PR I just merged should land in the next version and should not have the problem. If it continues to persist, please feel free to re-open this issue.

[moneydance]

Lets gooo glad it was helpful! I'm going to create a separate feature request around managing sandbox lifecycles as well. A hook built into the sdk that we can register a callback too when a container is named and fully spun up would be helpful for some of the features I'm working on. I'm working around it now with lifecycle hooks I added but having it supported by the sdk would be great.

[moneydance]

#188 added a feature request issue here