Remove aarch64 feature and add stable aarch64 target actions workflow

Author: marmeladema

.github/workflows/check.yml

@@ -104,6 +104,28 @@ jobs:
           echo "$HOME/.wasmtime/bin" >> $GITHUB_PATH
       - name: Run tests
         run: cargo +${{steps.toolchain.outputs.name}} wasi test --workspace --all-features
+  aarch64-stable:
+    name: aarch64 stable
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install cross-compilation toolchain
+        run: |
+          sudo apt update
+          sudo apt install gcc-aarch64-linux-gnu
+      - name: Install stable toolchain
+        id: toolchain
+        uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: stable
+          components: clippy, rustfmt
+          target: aarch64-unknown-linux-gnu
+      - name: Build all targets
+        run: cargo +${{steps.toolchain.outputs.name}} build --target aarch64-unknown-linux-gnu --workspace --all-targets
+        env:
+          RUSTFLAGS: -C linker=aarch64-linux-gnu-gcc
+      - name: Run Clippy linter
+        run: cargo +${{steps.toolchain.outputs.name}} clippy --target aarch64-unknown-linux-gnu --workspace --all-targets -- -D warnings
   aarch64-nightly:
     name: aarch64 nightly
     runs-on: ubuntu-latest
@@ -125,7 +147,7 @@ jobs:
         env:
           RUSTFLAGS: -C linker=aarch64-linux-gnu-gcc
       - name: Run Clippy linter
-        run: cargo +${{steps.toolchain.outputs.name}} clippy --target aarch64-unknown-linux-gnu --workspace --all-targets  --all-features -- -D warnings
+        run: cargo +${{steps.toolchain.outputs.name}} clippy --target aarch64-unknown-linux-gnu --workspace --all-targets --all-features -- -D warnings
   bench-stable:
     name: Benchmarks stable
     runs-on: ubuntu-latest

Cargo.toml

@@ -22,5 +22,4 @@ memmap2 = "0.5"
 debug = true
 
 [features]
-aarch64 = []
 stdsimd = []

src/bits.rs

@@ -2,10 +2,7 @@
 #[multiversion::multiversion]
 #[clone(target = "[x86|x86_64]+avx2")]
 #[clone(target = "wasm32+simd128")]
-#[cfg_attr(
-    all(target_arch = "aarch64", feature = "aarch64"),
-    clone(target = "aarch64+neon")
-)]
+#[clone(target = "aarch64+neon")]
 pub fn clear_leftmost_set(value: u32) -> u32 {
     value & (value - 1)
 }

src/lib.rs

@@ -8,7 +8,7 @@
 #![cfg_attr(feature = "stdsimd", feature(portable_simd))]
 
 /// Substring search implementations using aarch64 architecture features.
-#[cfg(all(target_arch = "aarch64", feature = "aarch64"))]
+#[cfg(target_arch = "aarch64")]
 pub mod aarch64;
 
 /// Substring search implementations using generic stdsimd features.
@@ -200,10 +200,7 @@ trait Searcher<N: NeedleWithSize + ?Sized> {
     #[multiversion::multiversion]
     #[clone(target = "[x86|x86_64]+avx2")]
     #[clone(target = "wasm32+simd128")]
-    #[cfg_attr(
-        all(target_arch = "aarch64", feature = "aarch64"),
-        clone(target = "aarch64+neon")
-    )]
+    #[clone(target = "aarch64+neon")]
     unsafe fn vector_search_in_chunk<V: Vector>(
         &self,
         hash: &VectorHash<V>,
@@ -257,10 +254,7 @@ trait Searcher<N: NeedleWithSize + ?Sized> {
     #[multiversion::multiversion]
     #[clone(target = "[x86|x86_64]+avx2")]
     #[clone(target = "wasm32+simd128")]
-    #[cfg_attr(
-        all(target_arch = "aarch64", feature = "aarch64"),
-        clone(target = "aarch64+neon")
-    )]
+    #[clone(target = "aarch64+neon")]
     unsafe fn vector_search_in<V: Vector>(
         &self,
         haystack: &[u8],

src/memcmp.rs

@@ -4,10 +4,7 @@ use std::slice;
 #[multiversion::multiversion]
 #[clone(target = "[x86|x86_64]+avx2")]
 #[clone(target = "wasm32+simd128")]
-#[cfg_attr(
-    all(target_arch = "aarch64", feature = "aarch64"),
-    clone(target = "aarch64+neon")
-)]
+#[clone(target = "aarch64+neon")]
 pub unsafe fn generic(left: *const u8, right: *const u8, n: usize) -> bool {
     slice::from_raw_parts(left, n) == slice::from_raw_parts(right, n)
 }
@@ -16,10 +13,7 @@ pub unsafe fn generic(left: *const u8, right: *const u8, n: usize) -> bool {
 #[multiversion::multiversion]
 #[clone(target = "[x86|x86_64]+avx2")]
 #[clone(target = "wasm32+simd128")]
-#[cfg_attr(
-    all(target_arch = "aarch64", feature = "aarch64"),
-    clone(target = "aarch64+neon")
-)]
+#[clone(target = "aarch64+neon")]
 pub unsafe fn specialized<const N: usize>(left: *const u8, right: *const u8) -> bool {
     slice::from_raw_parts(left, N) == slice::from_raw_parts(right, N)
 }