WIP - hack to get auth to work #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crude hack to get auth to work.
|
Seems to work, if you downgrade infi.clickhouse-orm==1.0.4 |
Author
|
Interesting. It looks like it may work if in the connector class send function you use a different request function: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this just to point out that auth (at least the way I understand it) doesn't currently work in the current master branch. Even if you supply a username and password in the JDBC URI the connector appears to ignore them. This has been working for people because by default Clickhouse doesn't require a username and password. In our case, since we require auth the attempt to connect returns the error: user 'default' requires a password.