Skip to content

Commit aae83b0

Browse files
committed
Minor changes
1 parent 8f5cfd7 commit aae83b0

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

settings.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
V8_HOME = os.environ.get("V8_HOME", os.path.join(STPYV8_HOME, "v8"))
88

99
V8_GIT_URL = "https://chromium.googlesource.com/v8/v8.git"
10-
V8_GIT_TAG_STABLE = "14.4.258.13"
10+
V8_GIT_TAG_STABLE = "14.3.127.17"
1111
V8_GIT_TAG_MASTER = "master"
1212
V8_GIT_TAG = V8_GIT_TAG_STABLE
1313
DEPOT_GIT_URL = "https://chromium.googlesource.com/chromium/tools/depot_tools.git"
@@ -26,7 +26,7 @@
2626
"treat_warnings_as_errors": "false",
2727
"use_clang_modules": "false",
2828
"use_custom_libcxx": "false",
29-
"use_sysroot": "true" if platform.system() in ("Linux",) else "false",
29+
"use_sysroot": "false",
3030
"v8_deprecation_warnings": "true",
3131
"v8_enable_disassembler": "false",
3232
"v8_enable_i18n_support": "true",
@@ -35,9 +35,7 @@
3535
"v8_enable_31bit_smis_on_64bit_arch": "false",
3636
"v8_imminent_deprecation_warnings": "true",
3737
"v8_monolithic": "true",
38-
"v8_monolithic_for_shared_library": "false"
39-
if platform.system() in ("Windows",)
40-
else "true",
38+
"v8_monolithic_for_shared_library": "true",
4139
"v8_use_external_startup_data": "false",
4240
}
4341

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def checkout_v8():
139139

140140

141141
def build_v8():
142-
args = f"gen {os.path.join('out.gn', 'x64.release.sample')} --args=\"{GN_ARGS}\""
142+
args = f'gen {os.path.join("out.gn", "x64.release.sample")} --args="{GN_ARGS}"'
143143
success, _, __ = exec_cmd(
144144
os.path.join(DEPOT_HOME, "gn"),
145145
args,

0 commit comments

Comments
 (0)