Skip to content

Commit 15912b0

Browse files
committed
test(cloudflare_ruleset): add coverage for more actions
* Add `decode_null_to_zero` tag to `categories` and `rules` action parameters for the `execute` action to handle empty lists being omitted from API responses. * Add `decode_null_to_zero` tag to `preserve_duplicates` action parameters for the `log_custom_field` action to handle `false` being omitted from API responses. * Add validation to ensure `log_custom_field` action parameters are not set to empty lists. * Ensure test data is formatted consistently and put actions in alphabetical order. * Add test coverage for the `challenge`, `js_challenge`, `managed_challenge`, `execute`, `log`, and `log_custom_field` actions.
1 parent 5cd110d commit 15912b0

File tree

38 files changed

+1048
-37
lines changed

38 files changed

+1048
-37
lines changed

internal/services/ruleset/model.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ type RulesetRulesActionParametersMatchedDataModel struct {
118118

119119
type RulesetRulesActionParametersOverridesModel struct {
120120
Action types.String `tfsdk:"action" json:"action,optional"`
121-
Categories customfield.NestedObjectList[RulesetRulesActionParametersOverridesCategoriesModel] `tfsdk:"categories" json:"categories,optional"`
121+
Categories customfield.NestedObjectList[RulesetRulesActionParametersOverridesCategoriesModel] `tfsdk:"categories" json:"categories,computed_optional,decode_null_to_zero"`
122122
Enabled types.Bool `tfsdk:"enabled" json:"enabled,optional"`
123-
Rules customfield.NestedObjectList[RulesetRulesActionParametersOverridesRulesModel] `tfsdk:"rules" json:"rules,optional"`
123+
Rules customfield.NestedObjectList[RulesetRulesActionParametersOverridesRulesModel] `tfsdk:"rules" json:"rules,computed_optional,decode_null_to_zero"`
124124
SensitivityLevel types.String `tfsdk:"sensitivity_level" json:"sensitivity_level,optional"`
125125
}
126126

@@ -280,7 +280,7 @@ type RulesetRulesActionParametersCookieFieldsModel struct {
280280

281281
type RulesetRulesActionParametersRawResponseFieldsModel struct {
282282
Name types.String `tfsdk:"name" json:"name,required"`
283-
PreserveDuplicates types.Bool `tfsdk:"preserve_duplicates" json:"preserve_duplicates,optional"`
283+
PreserveDuplicates types.Bool `tfsdk:"preserve_duplicates" json:"preserve_duplicates,computed_optional,decode_null_to_zero"`
284284
}
285285

286286
type RulesetRulesActionParametersRequestFieldsModel struct {
@@ -289,7 +289,7 @@ type RulesetRulesActionParametersRequestFieldsModel struct {
289289

290290
type RulesetRulesActionParametersResponseFieldsModel struct {
291291
Name types.String `tfsdk:"name" json:"name,required"`
292-
PreserveDuplicates types.Bool `tfsdk:"preserve_duplicates" json:"preserve_duplicates,optional"`
292+
PreserveDuplicates types.Bool `tfsdk:"preserve_duplicates" json:"preserve_duplicates,computed_optional,decode_null_to_zero"`
293293
}
294294

295295
type RulesetRulesActionParametersTransformedRequestFieldsModel struct {

0 commit comments

Comments
 (0)