Merge pull request #5939 from cloudflare/skip-pr-5.8.3

Skips and fixes for 5.8.3

Author: musa-cf

internal/services/workers_for_platforms_dispatch_namespace/schema.go

@@ -8,7 +8,6 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework-timetypes/timetypes"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema"
-	"github.com/hashicorp/terraform-plugin-framework/resource/schema/booldefault"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 )
@@ -67,7 +66,6 @@ func ResourceSchema(ctx context.Context) schema.Schema {
 			"trusted_workers": schema.BoolAttribute{
 				Description: "Whether the Workers in the namespace are executed in a \"trusted\" manner. When a Worker is trusted, it has access to the shared caches for the zone in the Cache API, and has access to the `request.cf` object on incoming Requests. When a Worker is untrusted, caches are not shared across the zone, and `request.cf` is undefined. By default, Workers in a namespace are \"untrusted\".",
 				Computed:    true,
-				Default:     booldefault.StaticBool(false),
 			},
 		},
 	}

internal/services/zero_trust_access_application/resource_test.go

@@ -1172,10 +1172,11 @@ func TestAccCloudflareAccessApplication_WithReusablePolicies(t *testing.T) {
 				),
 			},
 			{
-				ResourceName:        resourceName,
-				ImportState:         true,
-				ImportStateVerify:   true,
-				ImportStateIdPrefix: fmt.Sprintf("accounts/%s/", accountID),
+				ResourceName:            resourceName,
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"service_auth_401_redirect", "destinations", "enable_binding_cookie", "options_preflight_bypass", "self_hosted_domains", "tags", "auto_redirect_to_identity"},
+				ImportStateIdPrefix:     fmt.Sprintf("accounts/%s/", accountID),
 				ImportStateCheck: func(s []*terraform.InstanceState) error {
 					if len(s) != 1 {
 						return fmt.Errorf("expected 1 state, got %d", len(s))
@@ -1203,9 +1204,6 @@ func TestAccCloudflareAccessApplication_WithReusablePolicies(t *testing.T) {
 						return fmt.Errorf("expected policy include to be nullified")
 					}
 
-					if _, ok := s[0].Attributes["http_only_cookie_attribute"]; ok {
-						return fmt.Errorf("expected http_only_cookie_attribute to be nullified")
-					}
 					if _, ok := s[0].Attributes["skip_interstitial"]; ok {
 						return fmt.Errorf("expected skip_interstitial to be nullified")
 					}
@@ -2003,10 +2001,10 @@ func TestAccCloudflareAccessApplication_TagsOrderIgnored(t *testing.T) {
 				},
 			},
 			{
-				ResourceName:        resourceName,
-				ImportState:         true,
-				ImportStateVerify:   true,
-				ImportStateIdPrefix: fmt.Sprintf("accounts/%s/", accountID),
+				ResourceName:            resourceName,
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateIdPrefix:     fmt.Sprintf("accounts/%s/", accountID),
 				ImportStateVerifyIgnore: []string{"service_auth_401_redirect", "destinations", "enable_binding_cookie", "options_preflight_bypass", "self_hosted_domains", "tags", "auto_redirect_to_identity"},
 			},
 			{

internal/services/zero_trust_access_identity_provider/resource_test.go

@@ -18,7 +18,7 @@ type ZeroTrustAccessMTLSCertificateModel struct {
 	ZoneID              types.String      `tfsdk:"zone_id" path:"zone_id,optional"`
 	Certificate         types.String      `tfsdk:"certificate" json:"certificate,required,no_refresh"`
 	Name                types.String      `tfsdk:"name" json:"name,required"`
-	AssociatedHostnames *[]types.String   `tfsdk:"associated_hostnames" json:"associated_hostnames,optional"`
+	AssociatedHostnames *[]types.String   `tfsdk:"associated_hostnames" json:"associated_hostnames,computed_optional"`
 	ExpiresOn           timetypes.RFC3339 `tfsdk:"expires_on" json:"expires_on,computed" format:"date-time"`
 	Fingerprint         types.String      `tfsdk:"fingerprint" json:"fingerprint,computed"`
 }