fix(api): Fix update/read path parameter for zone subscription

Author: stainless-app[bot]

.stats.yml

@@ -1,4 +1,4 @@
 configured_endpoints: 1769
 openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/cloudflare%2Fcloudflare-5e53659eea1b4f1fb11addaddb82880c177d8fa3e7a93f0d664a65e43ac526f4.yml
 openapi_spec_hash: 3e0f59ac2722028954566a4c850e8849
-config_hash: fba73e92c75cff1909420025367fd0c0
+config_hash: 7d141842aab5959e694a41aa0025b663

internal/services/zone_subscription/model.go

@@ -13,7 +13,7 @@ type ZoneSubscriptionResultEnvelope struct {
 }
 
 type ZoneSubscriptionModel struct {
-	ID                 types.String                   `tfsdk:"id" json:"id,computed"`
+	ID                 types.String                   `tfsdk:"id" json:"-,computed"`
 	ZoneID             types.String                   `tfsdk:"zone_id" path:"zone_id,required"`
 	Frequency          types.String                   `tfsdk:"frequency" json:"frequency,optional"`
 	RatePlan           *ZoneSubscriptionRatePlanModel `tfsdk:"rate_plan" json:"rate_plan,optional"`

internal/services/zone_subscription/resource.go

@@ -91,6 +91,7 @@ func (r *ZoneSubscriptionResource) Create(ctx context.Context, req resource.Crea
 		return
 	}
 	data = &env.Result
+	data.ID = data.ZoneID
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
 }
@@ -122,7 +123,7 @@ func (r *ZoneSubscriptionResource) Update(ctx context.Context, req resource.Upda
 	_, err = r.client.Zones.Subscriptions.Update(
 		ctx,
 		zones.SubscriptionUpdateParams{
-			ZoneID: cloudflare.F(data.ID.ValueString()),
+			ZoneID: cloudflare.F(data.ZoneID.ValueString()),
 		},
 		option.WithRequestBody("application/json", dataBytes),
 		option.WithResponseBodyInto(&res),
@@ -139,6 +140,7 @@ func (r *ZoneSubscriptionResource) Update(ctx context.Context, req resource.Upda
 		return
 	}
 	data = &env.Result
+	data.ID = data.ZoneID
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
 }
@@ -157,7 +159,7 @@ func (r *ZoneSubscriptionResource) Read(ctx context.Context, req resource.ReadRe
 	_, err := r.client.Zones.Subscriptions.Get(
 		ctx,
 		zones.SubscriptionGetParams{
-			ZoneID: cloudflare.F(data.ID.ValueString()),
+			ZoneID: cloudflare.F(data.ZoneID.ValueString()),
 		},
 		option.WithResponseBodyInto(&res),
 		option.WithMiddleware(logging.Middleware(ctx)),
@@ -178,6 +180,7 @@ func (r *ZoneSubscriptionResource) Read(ctx context.Context, req resource.ReadRe
 		return
 	}
 	data = &env.Result
+	data.ID = data.ZoneID
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
 }
@@ -223,6 +226,7 @@ func (r *ZoneSubscriptionResource) ImportState(ctx context.Context, req resource
 		return
 	}
 	data = &env.Result
+	data.ID = data.ZoneID
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
 }

internal/services/zone_subscription/schema.go

@@ -23,12 +23,12 @@ func ResourceSchema(ctx context.Context) schema.Schema {
 			"id": schema.StringAttribute{
 				Description:   "Subscription identifier tag.",
 				Computed:      true,
-				PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()},
+				PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown(), stringplanmodifier.RequiresReplace()},
 			},
 			"zone_id": schema.StringAttribute{
 				Description:   "Subscription identifier tag.",
 				Required:      true,
-				PlanModifiers: []planmodifier.String{stringplanmodifier.RequiresReplace()},
+				PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown(), stringplanmodifier.RequiresReplace()},
 			},
 			"frequency": schema.StringAttribute{
 				Description: "How often the subscription is renewed automatically.\nAvailable values: \"weekly\", \"monthly\", \"quarterly\", \"yearly\".",