fix(workers_script): Revert treating cloudflare_workers_script.bindings as a Set

This was originally intended to prevent diffs due to ordering inconsistency between API and Terraform config, but resulted in a loss of fidelity in diffs as the entire `bindings` attribute was now being shown in diffs as `(sensitive)` due to a nested attribute being as such.

Author: 1000hz

internal/services/workers_script/custom.go

@@ -184,9 +184,9 @@ func ValidateContentSHA256() validator.String {
 
 func UpdateSecretTextsFromState[T any](
 	ctx context.Context,
-	refreshed customfield.NestedObjectSet[T],
-	state customfield.NestedObjectSet[T],
-) (customfield.NestedObjectSet[T], diag.Diagnostics) {
+	refreshed customfield.NestedObjectList[T],
+	state customfield.NestedObjectList[T],
+) (customfield.NestedObjectList[T], diag.Diagnostics) {
 	var diags diag.Diagnostics
 
 	refreshedElems := refreshed.Elements()
@@ -252,11 +252,11 @@ func UpdateSecretTextsFromState[T any](
 		updatedElems[i] = refreshedObj
 	}
 
-	setValue, d := types.SetValue(refreshed.ElementType(ctx), updatedElems)
+	value, d := types.ListValue(refreshed.ElementType(ctx), updatedElems)
 	diags.Append(d...)
 
-	return customfield.NestedObjectSet[T]{
-		SetValue: setValue,
+	return customfield.NestedObjectList[T]{
+		ListValue: value,
 	}, diags
 }
 

internal/services/workers_script/model.go

@@ -89,18 +89,18 @@ func (r WorkersScriptModel) MarshalMultipart() (data []byte, formDataContentType
 }
 
 type WorkersScriptMetadataModel struct {
-	Assets             *WorkersScriptMetadataAssetsModel                               `tfsdk:"assets" json:"assets,optional"`
-	Bindings           customfield.NestedObjectSet[WorkersScriptMetadataBindingsModel] `tfsdk:"bindings" json:"bindings,computed_optional"`
-	BodyPart           types.String                                                    `tfsdk:"body_part" json:"body_part,optional"`
-	CompatibilityDate  types.String                                                    `tfsdk:"compatibility_date" json:"compatibility_date,computed_optional"`
-	CompatibilityFlags customfield.Set[types.String]                                   `tfsdk:"compatibility_flags" json:"compatibility_flags,computed_optional"`
-	KeepAssets         types.Bool                                                      `tfsdk:"keep_assets" json:"keep_assets,optional"`
-	KeepBindings       *[]types.String                                                 `tfsdk:"keep_bindings" json:"keep_bindings,optional"`
-	Logpush            types.Bool                                                      `tfsdk:"logpush" json:"logpush,computed_optional"`
-	MainModule         types.String                                                    `tfsdk:"main_module" json:"main_module,optional"`
-	Migrations         customfield.NestedObject[WorkersScriptMetadataMigrationsModel]  `tfsdk:"migrations" json:"migrations,optional"`
-	Observability      *WorkersScriptMetadataObservabilityModel                        `tfsdk:"observability" json:"observability,optional"`
-	Placement          customfield.NestedObject[WorkersScriptMetadataPlacementModel]   `tfsdk:"placement" json:"placement,computed_optional"`
+	Assets             *WorkersScriptMetadataAssetsModel                                `tfsdk:"assets" json:"assets,optional"`
+	Bindings           customfield.NestedObjectList[WorkersScriptMetadataBindingsModel] `tfsdk:"bindings" json:"bindings,computed_optional"`
+	BodyPart           types.String                                                     `tfsdk:"body_part" json:"body_part,optional"`
+	CompatibilityDate  types.String                                                     `tfsdk:"compatibility_date" json:"compatibility_date,computed_optional"`
+	CompatibilityFlags customfield.Set[types.String]                                    `tfsdk:"compatibility_flags" json:"compatibility_flags,computed_optional"`
+	KeepAssets         types.Bool                                                       `tfsdk:"keep_assets" json:"keep_assets,optional"`
+	KeepBindings       *[]types.String                                                  `tfsdk:"keep_bindings" json:"keep_bindings,optional"`
+	Logpush            types.Bool                                                       `tfsdk:"logpush" json:"logpush,computed_optional"`
+	MainModule         types.String                                                     `tfsdk:"main_module" json:"main_module,optional"`
+	Migrations         customfield.NestedObject[WorkersScriptMetadataMigrationsModel]   `tfsdk:"migrations" json:"migrations,optional"`
+	Observability      *WorkersScriptMetadataObservabilityModel                         `tfsdk:"observability" json:"observability,optional"`
+	Placement          customfield.NestedObject[WorkersScriptMetadataPlacementModel]    `tfsdk:"placement" json:"placement,computed_optional"`
 	// Tags               *[]types.String                                                       `tfsdk:"tags" json:"tags,optional"`
 	TailConsumers customfield.NestedObjectSet[WorkersScriptMetadataTailConsumersModel] `tfsdk:"tail_consumers" json:"tail_consumers,computed_optional"`
 	UsageModel    types.String                                                         `tfsdk:"usage_model" json:"usage_model,computed_optional"`

internal/services/workers_script/schema.go

@@ -145,11 +145,11 @@ func ResourceSchema(ctx context.Context) schema.Schema {
 					},
 				},
 			},
-			"bindings": schema.SetNestedAttribute{
+			"bindings": schema.ListNestedAttribute{
 				Description: "List of bindings attached to a Worker. You can find more about bindings on our docs: https://developers.cloudflare.com/workers/configuration/multipart-upload-metadata/#bindings.",
 				Computed:    true,
 				Optional:    true,
-				CustomType:  customfield.NewNestedObjectSetType[WorkersScriptMetadataBindingsModel](ctx),
+				CustomType:  customfield.NewNestedObjectListType[WorkersScriptMetadataBindingsModel](ctx),
 				NestedObject: schema.NestedAttributeObject{
 					Attributes: map[string]schema.Attribute{
 						"name": schema.StringAttribute{

internal/services/workers_script/testdata/module.tf

@@ -28,15 +28,15 @@ resource "cloudflare_workers_script" "%[1]s" {
       type = "kv_namespace"
       namespace_id = cloudflare_workers_kv_namespace.%[1]s.id
     },
-    {
-      name = "SECRET"
-      type = "secret_text"
-      text = "shhh!!"
-    },
     {
       name = "MY_QUEUE"
       type = "queue"
       queue_name = cloudflare_queue.%[1]s.queue_name
+    },
+    {
+      name = "SECRET"
+      type = "secret_text"
+      text = "shhh!!"
     }
   ]
   observability = {