Skip to content

Commit 86b3333

Browse files
committed
DLS-314: Add dns in routing field for tests
1 parent f13e27e commit 86b3333

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

internal/services/regional_hostname/resource_test.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ import (
99
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
1010
)
1111

12-
var (
13-
zoneID = os.Getenv("CLOUDFLARE_ZONE_ID")
14-
)
12+
var zoneID = os.Getenv("CLOUDFLARE_ZONE_ID")
1513

1614
func TestAccCloudflareRegionalHostname_Basic(t *testing.T) {
1715
rnd := utils.GenerateRandomResourceName()
@@ -23,14 +21,14 @@ func TestAccCloudflareRegionalHostname_Basic(t *testing.T) {
2321
ProtoV6ProviderFactories: acctest.TestAccProtoV6ProviderFactories,
2422
Steps: []resource.TestStep{
2523
{
26-
Config: testRegionalHostnameConfig(rnd, zoneName, "ca"),
24+
Config: testRegionalHostnameConfig(rnd, zoneName, "ca", "dns"),
2725
Check: resource.ComposeTestCheckFunc(
2826
resource.TestCheckResourceAttr(name, "hostname", zoneName),
2927
resource.TestCheckResourceAttr(name, "region_key", "ca"),
3028
),
3129
},
3230
{
33-
Config: testRegionalHostnameConfig(rnd, zoneName, "eu"),
31+
Config: testRegionalHostnameConfig(rnd, zoneName, "eu", "dns"),
3432
Check: resource.ComposeTestCheckFunc(
3533
resource.TestCheckResourceAttr(name, "hostname", zoneName),
3634
resource.TestCheckResourceAttr(name, "region_key", "eu"),
@@ -40,6 +38,6 @@ func TestAccCloudflareRegionalHostname_Basic(t *testing.T) {
4038
})
4139
}
4240

43-
func testRegionalHostnameConfig(name string, zoneName, regionKey string) string {
44-
return acctest.LoadTestCase("regionalhostnameconfig.tf", name, zoneID, zoneName, regionKey)
41+
func testRegionalHostnameConfig(name string, zoneName, regionKey, routing string) string {
42+
return acctest.LoadTestCase("regionalhostnameconfig.tf", name, zoneID, zoneName, regionKey, routing)
4543
}

internal/services/regional_hostname/testdata/regionalhostnameconfig.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@ resource "cloudflare_regional_hostname" "%[1]s" {
33
zone_id = "%[2]s"
44
hostname = "%[3]s"
55
region_key = "%[4]s"
6-
}
6+
routing = "%[5]s"
7+
}

0 commit comments

Comments
 (0)