Skip to content

Commit 8b41fda

Browse files
committed
Revert "chore(test): Skip some rulesets tests"
This reverts commit 263f43c. Fix was to manually delete the straggling API resources directly. Note: this cannot be done by the dash; it needs to be done by the API.
1 parent e3007bd commit 8b41fda

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

internal/services/ruleset/resource_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,6 @@ func TestAccCloudflareRuleset_WAFManagedRulesetWithPayloadLogging(t *testing.T)
684684
}
685685

686686
func TestAccCloudflareRuleset_RateLimit(t *testing.T) {
687-
t.Skip(`'zone' is not a valid value for kind because exceeded maximum number of zone rulesets for phase http_ratelimit`)
688687
// Temporarily unset CLOUDFLARE_API_TOKEN if it is set as the WAF
689688
// service does not yet support the API tokens and it results in
690689
// misleading state error messages.
@@ -735,7 +734,6 @@ func TestAccCloudflareRuleset_RateLimit(t *testing.T) {
735734
}
736735

737736
func TestAccCloudflareRuleset_RateLimitScorePerPeriod(t *testing.T) {
738-
t.Skip(`'zone' is not a valid value for kind because exceeded maximum number of zone rulesets for phase http_ratelimit`)
739737
// Temporarily unset CLOUDFLARE_API_TOKEN if it is set as the WAF
740738
// service does not yet support the API tokens and it results in
741739
// misleading state error messages.
@@ -1984,7 +1982,6 @@ func TestAccCloudflareRuleset_Redirect(t *testing.T) {
19841982
}
19851983

19861984
func TestAccCloudflareRuleset_DynamicRedirect(t *testing.T) {
1987-
t.Skip(`'zone' is not a valid value for kind because exceeded maximum number of zone rulesets for phase http_ratelimit`)
19881985
rnd := utils.GenerateRandomResourceName()
19891986
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
19901987
resourceName := "cloudflare_ruleset." + rnd
@@ -2014,7 +2011,6 @@ func TestAccCloudflareRuleset_DynamicRedirect(t *testing.T) {
20142011
}
20152012

20162013
func TestAccCloudflareRuleset_DynamicRedirectWithoutPreservingQueryString(t *testing.T) {
2017-
t.Skip(`'zone' is not a valid value for kind because exceeded maximum number of zone rulesets for phase http_ratelimit`)
20182014
rnd := utils.GenerateRandomResourceName()
20192015
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
20202016
resourceName := "cloudflare_ruleset." + rnd

0 commit comments

Comments
 (0)