feat(state_upgarder) refactor state upgrader for dns_record, page_rule

and load_balancer_pool

Author: vaishakdinesh

.github/workflows/migration-tests.yml

@@ -28,6 +28,7 @@ env:
   CLOUDFLARE_HYPERDRIVE_DATABASE_HOSTNAME: ${{ secrets.CLOUDFLARE_HYPERDRIVE_DATABASE_HOSTNAME }}
   TF_ACC: 1
   TF_MIGRATE_BINARY_PATH: ${{ github.workspace }}/tf-migrate
+  TF_MIG_TEST: true
 
 jobs:
   migration-tests:

internal/acctest/acctest.go

@@ -1129,6 +1129,15 @@ func MigrationV2TestStepWithPlan(t *testing.T, v4Config string, tmpDir string, e
 	return []resource.TestStep{migrationStep, planStep, validationStep}
 }
 
+// InferMigrationVersions determines source and target versions from test provider version.
+// Returns ("v4", "v5") for v4.x versions, ("v5", "v5") for v5.x versions.
+func InferMigrationVersions(testVersion string) (source, target string) {
+	if strings.HasPrefix(testVersion, "5.") {
+		return "v5", "v5"
+	}
+	return "v4", "v5"
+}
+
 // MigrationTestStep creates a test step that runs the migration command and validates with v5 provider
 func MigrationTestStep(t *testing.T, v4Config string, tmpDir string, exactVersion string, stateChecks []statecheck.StateCheck) resource.TestStep {
 	// Choose the appropriate plan check based on the version

internal/services/dns_record/migration/v500/handler.go

@@ -0,0 +1,52 @@
+package v500
+
+import (
+	"context"
+
+	"github.com/hashicorp/terraform-plugin-framework/resource"
+	"github.com/hashicorp/terraform-plugin-log/tflog"
+)
+
+// UpgradeFromV0 handles state upgrades from earlier v500 versions (schema_version=0) to current v500.
+// This is a no-op upgrade since the schema is compatible - just copy state through.
+//
+// Why this exists: Terraform requires explicit upgraders to be defined for version tracking,
+// even when the schema is identical. This ensures the schema_version is updated in the statefile.
+func UpgradeFromV0(
+	ctx context.Context,
+	req resource.UpgradeStateRequest,
+	resp *resource.UpgradeStateResponse,
+) {
+	// No-op upgrade: schema is compatible, just copy raw state through
+	// We use the raw state value directly to avoid issues with custom field type serialization
+	resp.State.Raw = req.State.Raw
+}
+
+// UpgradeFromLegacyV3 handles state upgrades from the legacy cloudflare_record resource to cloudflare_dns_record.
+// This is triggered when users manually run `terraform state mv cloudflare_record.x cloudflare_dns_record.x`
+// (Terraform < 1.8), which preserves the source schema_version=3 from the legacy provider.
+//
+// Note: schema_version=3 was the final schema version of cloudflare_record in the legacy (SDKv2) provider
+// before it was deprecated. The state structure matches SourceCloudflareRecordModel.
+func UpgradeFromLegacyV3(ctx context.Context, req resource.UpgradeStateRequest, resp *resource.UpgradeStateResponse) {
+	tflog.Info(ctx, "Upgrading DNS record state from legacy cloudflare_record (schema_version=3)")
+
+	// Parse the state (schema_version=3, source resource type)
+	var sourceState SourceCloudflareRecordModel
+	resp.Diagnostics.Append(req.State.Get(ctx, &sourceState)...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	// Transform to target
+	targetState, diags := Transform(ctx, sourceState)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
+
+	// Set the upgraded state
+	resp.Diagnostics.Append(resp.State.Set(ctx, targetState)...)
+
+	tflog.Info(ctx, "State upgrade from legacy cloudflare_record completed successfully")
+}