fix: custom page tests

Author: vaishakdinesh

internal/services/custom_pages/model.go

@@ -19,7 +19,7 @@ type CustomPagesModel struct {
 	AccountID      types.String                   `tfsdk:"account_id" path:"account_id,optional"`
 	ZoneID         types.String                   `tfsdk:"zone_id" path:"zone_id,optional"`
 	State          types.String                   `tfsdk:"state" json:"state,required"`
-	URL            types.String                   `tfsdk:"url" json:"url,required"`
+	URL            types.String                   `tfsdk:"url" json:"url,computed_optional"`
 	CreatedOn      timetypes.RFC3339              `tfsdk:"created_on" json:"created_on,computed" format:"date-time"`
 	Description    types.String                   `tfsdk:"description" json:"description,computed"`
 	ModifiedOn     timetypes.RFC3339              `tfsdk:"modified_on" json:"modified_on,computed" format:"date-time"`

internal/services/custom_pages/resource.go

@@ -99,6 +99,9 @@ func (r *CustomPagesResource) Create(ctx context.Context, req resource.CreateReq
 	}
 	data = &env.Result
 	data.ID = data.Identifier
+	if env.Result.URL.IsNull() || env.Result.URL.ValueString() == "" || env.Result.URL.ValueString() == "null" {
+		data.URL = types.StringValue("")
+	}
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
 }
@@ -155,6 +158,9 @@ func (r *CustomPagesResource) Update(ctx context.Context, req resource.UpdateReq
 	}
 	data = &env.Result
 	data.ID = data.Identifier
+	if env.Result.URL.IsNull() || env.Result.URL.ValueString() == "" || env.Result.URL.ValueString() == "null" {
+		data.URL = types.StringValue("")
+	}
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
 }
@@ -202,6 +208,9 @@ func (r *CustomPagesResource) Read(ctx context.Context, req resource.ReadRequest
 	}
 	data = &env.Result
 	data.ID = data.Identifier
+	if env.Result.URL.IsNull() || env.Result.URL.ValueString() == "" || env.Result.URL.ValueString() == "null" {
+		data.URL = types.StringValue("")
+	}
 
 	resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
 }

internal/services/custom_pages/resource_test.go

@@ -399,6 +399,9 @@ func TestAccCloudflareCustomPages_ZoneRatelimitBlock(t *testing.T) {
 					statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("url"), knownvalue.StringExact("")),
 					statecheck.ExpectKnownValue(resourceName, tfjsonpath.New("account_id"), knownvalue.Null()),
 				},
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PostApplyPostRefresh: acctest.LogResourceDrift,
+				},
 			},
 			{
 				Config: testAccCustomPagesZoneConfig(rnd, zoneID, "ratelimit_block", "customized", "https://custom-pages-waf-challenge.terraform-provider-acceptance-testing.workers.dev/"),