Skip to content

Commit d3b0d00

Browse files
committed
chore: update zone name for tests and not in parallel
1 parent a81b833 commit d3b0d00

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

internal/services/dns_record/resource_test.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func testSweepCloudflareRecord(r string) error {
6363
}
6464

6565
func TestAccCloudflareRecord_Basic(t *testing.T) {
66-
t.Parallel()
66+
//t.Parallel()
6767
var record cfold.DNSRecord
6868
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
6969
domain := os.Getenv("CLOUDFLARE_DOMAIN")
@@ -96,7 +96,7 @@ func TestAccCloudflareRecord_Basic(t *testing.T) {
9696
}
9797

9898
func TestAccCloudflareRecord_Apex(t *testing.T) {
99-
t.Parallel()
99+
//t.Parallel()
100100
var record cfold.DNSRecord
101101
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
102102
domain := os.Getenv("CLOUDFLARE_DOMAIN")
@@ -123,7 +123,7 @@ func TestAccCloudflareRecord_Apex(t *testing.T) {
123123
}
124124

125125
func TestAccCloudflareRecord_LOC(t *testing.T) {
126-
t.Parallel()
126+
//t.Parallel()
127127
var record cfold.DNSRecord
128128
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
129129
domain := os.Getenv("CLOUDFLARE_DOMAIN")
@@ -161,7 +161,7 @@ func TestAccCloudflareRecord_LOC(t *testing.T) {
161161
}
162162

163163
func TestAccCloudflareRecord_SRV(t *testing.T) {
164-
t.Parallel()
164+
//t.Parallel()
165165
var record cfold.DNSRecord
166166
domain := os.Getenv("CLOUDFLARE_DOMAIN")
167167
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
@@ -191,7 +191,7 @@ func TestAccCloudflareRecord_SRV(t *testing.T) {
191191
}
192192

193193
func TestAccCloudflareRecord_CAA(t *testing.T) {
194-
t.Parallel()
194+
//t.Parallel()
195195
var record cfold.DNSRecord
196196
domain := os.Getenv("CLOUDFLARE_DOMAIN")
197197
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
@@ -226,7 +226,7 @@ func TestAccCloudflareRecord_CAA(t *testing.T) {
226226
}
227227

228228
func TestAccCloudflareRecord_Proxied(t *testing.T) {
229-
t.Parallel()
229+
//t.Parallel()
230230
var record cfold.DNSRecord
231231
domain := os.Getenv("CLOUDFLARE_DOMAIN")
232232
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
@@ -253,7 +253,7 @@ func TestAccCloudflareRecord_Proxied(t *testing.T) {
253253
}
254254

255255
func TestAccCloudflareRecord_Updated(t *testing.T) {
256-
t.Parallel()
256+
//t.Parallel()
257257
var record cfold.DNSRecord
258258
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
259259
domain := os.Getenv("CLOUDFLARE_DOMAIN")
@@ -285,7 +285,7 @@ func TestAccCloudflareRecord_Updated(t *testing.T) {
285285
}
286286

287287
func TestAccCloudflareRecord_typeForceNewRecord(t *testing.T) {
288-
t.Parallel()
288+
//t.Parallel()
289289
var afterCreate, afterUpdate cfold.DNSRecord
290290
zoneName := os.Getenv("CLOUDFLARE_DOMAIN")
291291
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
@@ -316,7 +316,7 @@ func TestAccCloudflareRecord_typeForceNewRecord(t *testing.T) {
316316
}
317317

318318
func TestAccCloudflareRecord_TtlValidation(t *testing.T) {
319-
t.Parallel()
319+
//t.Parallel()
320320
zoneName := os.Getenv("CLOUDFLARE_DOMAIN")
321321
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
322322
recordName := "tf-acctest-ttl-validation"
@@ -336,7 +336,7 @@ func TestAccCloudflareRecord_TtlValidation(t *testing.T) {
336336
}
337337

338338
func TestAccCloudflareRecord_ExplicitProxiedFalse(t *testing.T) {
339-
t.Parallel()
339+
//t.Parallel()
340340
zoneName := os.Getenv("CLOUDFLARE_DOMAIN")
341341
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
342342
rnd := utils.GenerateRandomResourceName()
@@ -373,7 +373,7 @@ func TestAccCloudflareRecord_ExplicitProxiedFalse(t *testing.T) {
373373
}
374374

375375
func TestAccCloudflareRecord_MXWithPriorityZero(t *testing.T) {
376-
t.Parallel()
376+
//t.Parallel()
377377
zoneName := os.Getenv("CLOUDFLARE_DOMAIN")
378378
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
379379
rnd := utils.GenerateRandomResourceName()
@@ -396,7 +396,7 @@ func TestAccCloudflareRecord_MXWithPriorityZero(t *testing.T) {
396396
}
397397

398398
func TestAccCloudflareRecord_HTTPS(t *testing.T) {
399-
t.Parallel()
399+
//t.Parallel()
400400
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
401401
zoneName := os.Getenv("CLOUDFLARE_DOMAIN")
402402
rnd := utils.GenerateRandomResourceName()
@@ -420,7 +420,7 @@ func TestAccCloudflareRecord_HTTPS(t *testing.T) {
420420
}
421421

422422
func TestAccCloudflareRecord_SVCB(t *testing.T) {
423-
t.Parallel()
423+
//t.Parallel()
424424
zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
425425
domain := os.Getenv("CLOUDFLARE_DOMAIN")
426426
rnd := utils.GenerateRandomResourceName()

internal/services/zone/resource_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,15 @@ func TestAccZoneWithUnicodeIsStoredAsUnicode(t *testing.T) {
112112
rnd := utils.GenerateRandomResourceName()
113113
name := "cloudflare_zone." + rnd
114114
accountID := os.Getenv("CLOUDFLARE_ACCOUNT_ID")
115-
115+
unicodeDomain := fmt.Sprintf("żóła.%s.cfapi.net", rnd)
116116
resource.Test(t, resource.TestCase{
117117
PreCheck: func() { acctest.TestAccPreCheck(t) },
118118
ProtoV6ProviderFactories: acctest.TestAccProtoV6ProviderFactories,
119119
Steps: []resource.TestStep{
120120
{
121-
Config: testZoneConfig(rnd, "żółw.cfapi.net", "true", "false", accountID),
121+
Config: testZoneConfig(rnd, unicodeDomain, "true", "false", accountID),
122122
Check: resource.ComposeTestCheckFunc(
123-
resource.TestCheckResourceAttr(name, "name", "żółw.cfapi.net"),
123+
resource.TestCheckResourceAttr(name, "name", unicodeDomain),
124124
resource.TestCheckResourceAttr(name, "name_servers.#", "2"),
125125
resource.TestCheckResourceAttr(name, "type", "full"),
126126
),

0 commit comments

Comments
 (0)