Merge pull request #5845 from cferic/argo_smart_routing-tests

test(argo_smart_routing): add test cases

Author: vaishakdinesh

internal/services/argo_smart_routing/resource_test.go

@@ -3,11 +3,16 @@ package argo_smart_routing_test
 import (
 	"fmt"
 	"os"
+	"regexp"
 	"testing"
 
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/knownvalue"
+	"github.com/hashicorp/terraform-plugin-testing/plancheck"
+	"github.com/hashicorp/terraform-plugin-testing/tfjsonpath"
+
 	"github.com/cloudflare/terraform-provider-cloudflare/internal/acctest"
 	"github.com/cloudflare/terraform-provider-cloudflare/internal/utils"
-	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
 func TestAccCloudflareArgoSmartRouting_Basic(t *testing.T) {
@@ -17,21 +22,83 @@ func TestAccCloudflareArgoSmartRouting_Basic(t *testing.T) {
 
 	resource.Test(t, resource.TestCase{
 		PreCheck: func() {
-			acctest.TestAccPreCheck_AccountID(t)
+			acctest.TestAccPreCheck_ZoneID(t)
 			acctest.TestAccPreCheck_Credentials(t)
 		},
 		ProtoV6ProviderFactories: acctest.TestAccProtoV6ProviderFactories,
 		Steps: []resource.TestStep{
 			{
-				Config: testAccCheckCloudflareArgoSmartRoutingBasic(zoneID, rnd),
+				Config: testAccCheckCloudflareArgoSmartRoutingEnable(zoneID, rnd),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(name, "id", zoneID),
+					resource.TestCheckResourceAttr(name, "zone_id", zoneID),
+					resource.TestCheckResourceAttr(name, "value", "on"),
+				),
+			},
+			{
+				Config: testAccCheckCloudflareArgoSmartRoutingEnable(zoneID, rnd),
 				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(name, "id", zoneID),
+					resource.TestCheckResourceAttr(name, "zone_id", zoneID),
 					resource.TestCheckResourceAttr(name, "value", "on"),
 				),
+				PlanOnly:           true,
+				ExpectNonEmptyPlan: false,
+			},
+			{
+				Config: testAccCheckCloudflareArgoSmartRoutingDisable(zoneID, rnd),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(name, "id", zoneID),
+					resource.TestCheckResourceAttr(name, "zone_id", zoneID),
+					resource.TestCheckResourceAttr(name, "value", "off"),
+				),
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PreApply: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction(name, plancheck.ResourceActionUpdate),
+						plancheck.ExpectKnownValue(
+							name,
+							tfjsonpath.New("value"),
+							knownvalue.StringExact("off"),
+						),
+					},
+				},
+			},
+			{
+				ResourceName:      name,
+				ImportState:       true,
+				ImportStateVerify: true,
 			},
 		},
 	})
 }
 
-func testAccCheckCloudflareArgoSmartRoutingBasic(zoneID, name string) string {
-	return acctest.LoadTestCase("basic.tf", zoneID, name)
+func TestAccCloudflareArgoSmartRouting_InvalidValue(t *testing.T) {
+	zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
+	rnd := utils.GenerateRandomResourceName()
+
+	resource.Test(t, resource.TestCase{
+		PreCheck: func() {
+			acctest.TestAccPreCheck_AccountID(t)
+			acctest.TestAccPreCheck_Credentials(t)
+		},
+		ProtoV6ProviderFactories: acctest.TestAccProtoV6ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config:      testAccCheckCloudflareArgoSmartRoutingInvalidValue(zoneID, rnd),
+				ExpectError: regexp.MustCompile(regexp.QuoteMeta("Invalid Attribute Value Match")),
+			},
+		},
+	})
+}
+
+func testAccCheckCloudflareArgoSmartRoutingEnable(zoneID, name string) string {
+	return acctest.LoadTestCase("enable.tf", zoneID, name)
+}
+
+func testAccCheckCloudflareArgoSmartRoutingDisable(zoneID, name string) string {
+	return acctest.LoadTestCase("disable.tf", zoneID, name)
+}
+
+func testAccCheckCloudflareArgoSmartRoutingInvalidValue(zoneID, name string) string {
+	return acctest.LoadTestCase("invalid_value.tf", zoneID, name)
 }

internal/services/argo_smart_routing/testdata/disable.tf

@@ -0,0 +1,4 @@
+resource "cloudflare_argo_smart_routing" "%[2]s" {
+  zone_id = "%[1]s"
+  value   = "off"
+}

internal/services/argo_smart_routing/testdata/basic.tf renamed to internal/services/argo_smart_routing/testdata/enable.tf

@@ -1,4 +1,4 @@
 resource "cloudflare_argo_smart_routing" "%[2]s" {
-	 zone_id = "%[1]s"
+  zone_id = "%[1]s"
   value   = "on"
 }

internal/services/argo_smart_routing/testdata/invalid_value.tf

@@ -0,0 +1,4 @@
+resource "cloudflare_argo_smart_routing" "%[2]s" {
+  zone_id = "%[1]s"
+  value   = "invalid"
+}