Merge pull request #5867 from zakcutner/ruleset/tests

Refactor `cloudflare_ruleset` resource tests

Author: vaishakdinesh

internal/services/ruleset/resource_legacy_test.go

@@ -0,0 +1,25 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 1.1.1.1"
+      action     = "block"
+      ref        = "one"
+    },
+    {
+      expression = "ip.src eq 3.3.3.3"
+      action     = "block"
+      ref        = "three"
+    },
+    {
+      expression = "ip.src eq 2.2.2.2"
+      action     = "block"
+      ref        = "two"
+    },
+  ]
+}

internal/services/ruleset/resource_test.go

@@ -0,0 +1,20 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 1.1.1.1"
+      action     = "block"
+      ref        = "one"
+    },
+    {
+      expression = "ip.src eq 2.2.2.2"
+      action     = "block"
+      ref        = "two"
+    },
+  ]
+}

internal/services/ruleset/testdata/TestAccCloudflareRuleset_RuleRef/add/after.tf

@@ -0,0 +1,25 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 1.1.1.1"
+      action     = "block"
+      ref        = "one"
+    },
+    {
+      expression = "ip.src eq 2.2.2.2"
+      action     = "block"
+      ref        = "two"
+    },
+    {
+      expression = "ip.src eq 3.3.3.3"
+      action     = "block"
+      ref        = "three"
+    },
+  ]
+}

internal/services/ruleset/testdata/TestAccCloudflareRuleset_RuleRef/add/before.tf

@@ -0,0 +1,20 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 1.1.1.1"
+      action     = "block"
+      ref        = "one"
+    },
+    {
+      expression = "ip.src eq 2.2.2.2"
+      action     = "block"
+      ref        = "two"
+    },
+  ]
+}

internal/services/ruleset/testdata/TestAccCloudflareRuleset_RuleRef/append/after.tf

@@ -0,0 +1,20 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 1.1.1.1"
+      action     = "block"
+      ref        = "one"
+    },
+    {
+      expression = "ip.src eq 3.3.3.3"
+      action     = "block"
+      ref        = "two"
+    },
+  ]
+}

internal/services/ruleset/testdata/TestAccCloudflareRuleset_RuleRef/append/before.tf

@@ -0,0 +1,20 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 1.1.1.1"
+      action     = "block"
+      ref        = "one"
+    },
+    {
+      expression = "ip.src eq 2.2.2.2"
+      action     = "block"
+      ref        = "two"
+    },
+  ]
+}

internal/services/ruleset/testdata/TestAccCloudflareRuleset_RuleRef/modify/after.tf

@@ -0,0 +1,15 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 2.2.2.2"
+      action     = "block"
+      ref        = "two"
+    },
+  ]
+}

internal/services/ruleset/testdata/TestAccCloudflareRuleset_RuleRef/modify/before.tf

@@ -0,0 +1,20 @@
+variable "zone_id" {}
+
+resource "cloudflare_ruleset" "my_ruleset" {
+  zone_id = var.zone_id
+  name    = "My ruleset"
+  phase   = "http_request_firewall_custom"
+  kind    = "zone"
+  rules = [
+    {
+      expression = "ip.src eq 1.1.1.1"
+      action     = "block"
+      ref        = "one"
+    },
+    {
+      expression = "ip.src eq 2.2.2.2"
+      action     = "block"
+      ref        = "two"
+    },
+  ]
+}