Skip to content

Commit 7bb4b46

Browse files
Lekensteynneuromncr
authored andcommitted
Go 1.13beta1 fixes and enablement in tests (#180)
* Fix go1.13beta1 test failures Fix two legitimate issues, one that broke getUint24 for large values, another that prevented the example from being tested and displayed: * travis: add go1.13rc1 to the test matrix Note: go1.13beta1 fails the build due to a readonly GOROOT, issue 33537. This was fixed in go1.13rc1.
1 parent 6e853dd commit 7bb4b46

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ os:
1919
go:
2020
- 1.11.x
2121
- 1.12.x
22+
- 1.13rc1
2223

2324
env:
2425
- TEST_SUITE=test-unit

common.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1232,8 +1232,8 @@ func signatureFromSignatureScheme(signatureAlgorithm SignatureScheme) uint8 {
12321232
// TODO(kk): Use variable length encoding?
12331233
func getUint24(b []byte) int {
12341234
n := int(b[2])
1235-
n += int(b[1] << 8)
1236-
n += int(b[0] << 16)
1235+
n += int(b[1]) << 8
1236+
n += int(b[0]) << 16
12371237
return n
12381238
}
12391239

example_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ yuGnBXj8ytqU0CwIPX4WecigUCAkVDNx
7272
conn.Close()
7373
}
7474

75-
func ExampleConfig_keyLogWriter_TLS12() {
75+
func ExampleConfig_keyLogWriterTLS12() {
7676
// Debugging TLS applications by decrypting a network traffic capture.
7777

7878
// WARNING: Use of KeyLogWriter compromises security and should only be
@@ -116,7 +116,7 @@ func ExampleConfig_keyLogWriter_TLS12() {
116116
// CLIENT_RANDOM 0000000000000000000000000000000000000000000000000000000000000000 baca0df460a688e44ce018b025183cc2353ae01f89755ef766eedd3ecc302888ee3b3a22962e45f48c20df15a98c0e80
117117
}
118118

119-
func ExampleConfig_keyLogWriter_TLS13() {
119+
func ExampleConfig_keyLogWriterTLS13() {
120120
// Debugging TLS applications by decrypting a network traffic capture.
121121

122122
// WARNING: Use of KeyLogWriter compromises security and should only be

0 commit comments

Comments
 (0)