fix: address code review findings

- ETag regex: use lastIndexOf('-') to extract only the final hash
  segment, avoiding capture of filename fragments in multi-hyphenated
  names (e.g. `before-pop-state-D3R3Ien6` now extracts `D3R3Ien6`)
- Progress bar: track processed count (including skipped files) so
  the bar always reaches 100%
- Tests: update ETag test for filename-hash behavior, add coverage
  for mtime fallback on non-hashed and unhashed-in-assets files

Author: NathanDrake2406

packages/vinext/src/build/precompress.ts

@@ -98,12 +98,17 @@ export async function precompressAssets(
   }
 
   // Process in chunks to bound concurrent CPU-heavy compressions
+  let processed = 0;
   for (let i = 0; i < filePaths.length; i += CONCURRENCY) {
     const chunk = filePaths.slice(i, i + CONCURRENCY);
     await Promise.all(
       chunk.map(async (fullPath) => {
         const content = await fsp.readFile(fullPath);
-        if (content.length < MIN_SIZE) return;
+        processed++;
+        if (content.length < MIN_SIZE) {
+          onProgress?.(processed, filePaths.length, path.basename(fullPath));
+          return;
+        }
 
         result.filesCompressed++;
         result.totalOriginalBytes += content.length;
@@ -136,7 +141,7 @@ export async function precompressAssets(
         await Promise.all(writes);
 
         result.totalCompressedBytes += brContent.length;
-        onProgress?.(result.filesCompressed, filePaths.length, path.basename(fullPath));
+        onProgress?.(processed, filePaths.length, path.basename(fullPath));
       }),
     );
   }

packages/vinext/src/server/static-file-cache.ts

@@ -236,8 +236,11 @@ export class StaticFileCache {
  */
 function etagFromFilenameHash(relativePath: string, ext: string): string | null {
   const basename = path.basename(relativePath, ext);
-  const match = basename.match(/-([a-zA-Z0-9_-]{6,})$/);
-  return match ? `W/"${match[1]}"` : null;
+  const lastDash = basename.lastIndexOf("-");
+  if (lastDash === -1 || lastDash === basename.length - 1) return null;
+  const suffix = basename.slice(lastDash + 1);
+  // Vite emits 8-char base64url hashes; allow 6-12 for other bundlers
+  return suffix.length >= 6 && suffix.length <= 12 ? `W/"${suffix}"` : null;
 }
 
 function buildVariant(

tests/static-file-cache.test.ts

@@ -104,13 +104,32 @@ describe("StaticFileCache", () => {
     expect(entry!.original.headers["Cache-Control"]).toBe("public, max-age=3600");
   });
 
-  it("generates weak etag from size and mtime", async () => {
+  it("generates weak etag from filename hash for hashed assets", async () => {
     await writeFile(clientDir, "assets/app-abc123.css", ".body { margin: 0; }");
 
     const cache = await StaticFileCache.create(clientDir);
     const entry = cache.lookup("/assets/app-abc123.css");
 
-    // Etag should be W/"<size>-<mtime>" format (like sirv)
+    // Hashed assets use the content hash from the filename
+    expect(entry!.etag).toBe('W/"abc123"');
+  });
+
+  it("falls back to mtime etag for non-hashed files", async () => {
+    await writeFile(clientDir, "favicon.ico", "icon");
+
+    const cache = await StaticFileCache.create(clientDir);
+    const entry = cache.lookup("/favicon.ico");
+
+    expect(entry!.etag).toMatch(/^W\/"\d+-\d+(\.\d+)?"$/);
+  });
+
+  it("falls back to mtime etag for assets without hash suffix", async () => {
+    await writeFile(clientDir, "assets/logo.svg", "<svg></svg>");
+
+    const cache = await StaticFileCache.create(clientDir);
+    const entry = cache.lookup("/assets/logo.svg");
+
+    // No hash in filename — falls back to mtime-based ETag
     expect(entry!.etag).toMatch(/^W\/"\d+-\d+(\.\d+)?"$/);
   });