[workerd-cxx] replacing symlinks with bazel rules (#13)

Author: mikea

.bazelrc

@@ -10,6 +10,10 @@ build:linux --@rules_rust//:extra_rustc_flags=-Clink-arg=-fuse-ld=lld
 build:linux --cxxopt=-std=c++17
 build:macos --cxxopt=-std=c++17
 
+build:clippy --aspects=@rules_rust//rust:defs.bzl%rust_clippy_aspect
+build:clippy --output_groups=+clippy_checks
+build:clippy  --@rules_rust//:clippy_flags=-Dclippy::all,-Dclippy::pedantic
+
 ###############################################################################
 ## Custom user flags
 ##

.github/workflows/buck2.yml

@@ -13,99 +13,6 @@ jobs:
   pre_ci:
     uses: dtolnay/.github/.github/workflows/pre_ci.yml@master
 
-  test:
-    name: ${{matrix.name || format('Rust {0}', matrix.rust)}}
-    needs: pre_ci
-    if: needs.pre_ci.outputs.continue
-    runs-on: ${{matrix.os}}-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        rust: [nightly, beta, stable, 1.82.0, 1.80.0, 1.77.0, 1.74.0, 1.73.0]
-        os: [ubuntu]
-        flags: ['']
-        include:
-          - name: Cargo on macOS
-            rust: nightly
-            os: macos
-          - name: Cargo on Windows (msvc)
-            rust: nightly-x86_64-pc-windows-msvc
-            os: windows
-            flags: /EHs
-          - name: C++14
-            rust: nightly
-            os: ubuntu
-            flags: -std=c++14
-          - name: C++17
-            rust: nightly
-            os: ubuntu
-            flags: -std=c++17
-          - name: C++20
-            rust: nightly
-            os: ubuntu
-            flags: -std=c++20
-    env:
-      CXXFLAGS: ${{matrix.flags}}
-      RUSTFLAGS: --cfg deny_warnings -Dwarnings
-    timeout-minutes: 45
-    steps:
-      - name: Enable symlinks (windows)
-        if: matrix.os == 'windows'
-        run: git config --global core.symlinks true
-      - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@master
-        with:
-          toolchain: ${{matrix.rust}}
-          components: rust-src
-      - name: Determine test suite subset
-        # Our Windows and macOS jobs are the longest running, so exclude the
-        # relatively slow compiletest from them to speed up end-to-end CI time,
-        # except during cron builds when no human is presumably waiting on the
-        # build. The extra coverage is not particularly valuable and we can
-        # still ensure the test is kept passing on the basis of the scheduled
-        # builds.
-        run: |
-          echo RUSTFLAGS=$RUSTFLAGS >> $GITHUB_ENV
-          echo exclude=--exclude cxx-test-suite ${{matrix.rust == '1.73.0' && '--exclude cxxbridge-cmd' || ''}} >> $GITHUB_OUTPUT
-        env:
-          RUSTFLAGS: ${{env.RUSTFLAGS}} ${{matrix.os != 'ubuntu' && github.event_name != 'schedule' && '--cfg skip_ui_tests' || ''}}
-        id: testsuite
-        shell: bash
-      - name: Ignore macOS linker warning
-        run: echo RUSTFLAGS=${RUSTFLAGS}\ -Alinker_messages >> $GITHUB_ENV
-        if: matrix.os == 'macos'
-      - run: cargo run --manifest-path demo/Cargo.toml
-      - run: cargo test --workspace ${{steps.testsuite.outputs.exclude}}
-        if: matrix.rust != '1.74.0' && matrix.rust != '1.73.0'
-      - run: cargo check --no-default-features --features alloc
-        env:
-          RUSTFLAGS: --cfg compile_error_if_std ${{env.RUSTFLAGS}}
-      - run: cargo check --no-default-features
-        env:
-          RUSTFLAGS: --cfg compile_error_if_alloc --cfg cxx_experimental_no_alloc ${{env.RUSTFLAGS}}
-      - uses: actions/upload-artifact@v4
-        if: matrix.os == 'ubuntu' && matrix.rust == 'nightly' && always()
-        with:
-          name: Cargo.lock
-          path: Cargo.lock
-        continue-on-error: true
-
-  reindeer:
-    name: Reindeer
-    runs-on: ubuntu-latest
-    if: github.event_name != 'pull_request'
-    timeout-minutes: 45
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@stable
-        with:
-          components: rust-src
-      - uses: dtolnay/install@reindeer
-      - run: reindeer buckify
-        working-directory: third-party
-      - name: Check reindeer-generated BUCK file up to date
-        run: git diff --exit-code
-
   bazel:
     name: Bazel on ${{matrix.os == 'ubuntu' && 'Linux' || matrix.os == 'macos' && 'macOS' || matrix.os == 'windows' && 'Windows' || '???'}}
     runs-on: ${{matrix.os}}-latest
@@ -129,57 +36,20 @@ jobs:
       - name: Check MODULE.bazel.lock up to date
         run: git diff --exit-code
       - run: bazel run //third-party:vendor
-        if: matrix.os == 'ubuntu' || matrix.os == 'macos'
+        if: matrix.os == 'ubuntu'
       - name: Check third-party/bazel up to date
         run: git diff --exit-code
-        if: matrix.os == 'ubuntu' || matrix.os == 'macos'
-
-  minimal:
-    name: Minimal versions
-    needs: pre_ci
-    if: needs.pre_ci.outputs.continue
-    runs-on: ubuntu-latest
-    timeout-minutes: 45
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@nightly
-      - run: cargo generate-lockfile -Z minimal-versions
-      - run: cargo check --locked --workspace
-
-  doc:
-    name: Documentation
-    needs: pre_ci
-    if: needs.pre_ci.outputs.continue
-    runs-on: ubuntu-latest
-    timeout-minutes: 45
-    env:
-      RUSTDOCFLAGS: -Dwarnings
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@nightly
-        with:
-          components: rust-src
-      - uses: dtolnay/install@cargo-docs-rs
-      - run: cargo docs-rs
-      - run: cargo docs-rs -p cxx-build
-      - run: cargo docs-rs -p cxx-gen
-      - run: cargo docs-rs -p cxxbridge-flags
-      - run: cargo docs-rs -p cxxbridge-macro
+        if: matrix.os == 'ubuntu'
 
   clippy:
     name: Clippy
     runs-on: ubuntu-latest
     if: github.event_name != 'pull_request'
     timeout-minutes: 45
-    env:
-      RUSTFLAGS: -Dwarnings
     steps:
       - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@nightly
-        with:
-          components: clippy, rust-src
-      - run: cargo clippy --workspace --tests --exclude demo -- -Dclippy::all -Dclippy::pedantic
-      - run: cargo clippy --manifest-path demo/Cargo.toml -- -Dclippy::all
+      - run: sudo apt-get install lld
+      - run: bazel build --config=clippy ... --verbose_failures --noshow_progress
 
   clang-tidy:
     name: Clang Tidy
@@ -204,14 +74,3 @@ jobs:
         working-directory: book
       - run: npx eslint
         working-directory: book
-
-  outdated:
-    name: Outdated
-    runs-on: ubuntu-latest
-    if: github.event_name != 'pull_request'
-    timeout-minutes: 45
-    steps:
-      - uses: actions/checkout@v4
-      - uses: dtolnay/rust-toolchain@stable
-      - uses: dtolnay/install@cargo-outdated
-      - run: cargo outdated --workspace --exit-code 1

.github/workflows/ci.yml

@@ -1,8 +1,5 @@
 /.buckd
-/bazel-bin
-/bazel-cxx
-/bazel-out
-/bazel-testlogs
+/bazel-*
 /user.bazelrc
 /buck-out
 /expand.cc

.github/workflows/site._yml

@@ -1,5 +1,7 @@
 load("@rules_cc//cc:defs.bzl", "cc_library")
 load("@rules_rust//rust:defs.bzl", "rust_binary", "rust_library", "rust_proc_macro")
+load("@bazel_skylib//lib:paths.bzl", "paths")
+load(":copy_srcs.bzl", "copy_srcs")
 
 rust_library(
     name = "cxx",
@@ -25,10 +27,15 @@ alias(
     visibility = ["//visibility:public"],
 )
 
+copy_srcs(
+    name = "cxxbridge-cmd-srcs",
+    srcs = glob(["gen/cmd/src/*.rs"])
+)
+
 rust_binary(
     name = "cxxbridge",
-    srcs = glob(["gen/cmd/src/**/*.rs"]),
-    compile_data = ["gen/cmd/src/gen/include/cxx.h"],
+    srcs = [":cxxbridge-cmd-srcs"],
+    compile_data = ["include/cxx.h"],
     edition = "2021",
     deps = [
         "@crates.io//:clap",
@@ -54,9 +61,14 @@ cc_library(
     linkstatic = True,
 )
 
+copy_srcs(
+    name = "cxxbridge-macro-srcs",
+    srcs = glob(["macro/src/*.rs"])
+)
+
 rust_proc_macro(
     name = "cxxbridge-macro",
-    srcs = glob(["macro/src/**/*.rs"]),
+    srcs = [":cxxbridge-macro-srcs"],
     edition = "2021",
     proc_macro_deps = [
         "@crates.io//:rustversion",
@@ -68,10 +80,17 @@ rust_proc_macro(
     ],
 )
 
+copy_srcs(
+    name = "cxx-build-srcs",
+    srcs = glob(["gen/build/src/*.rs"])
+)
+
 rust_library(
     name = "cxx-build",
-    srcs = glob(["gen/build/src/**/*.rs"]),
-    compile_data = ["gen/build/src/gen/include/cxx.h"],
+    srcs = [":cxx-build-srcs"],
+    compile_data = [
+        "include/cxx.h",
+    ],
     edition = "2021",
     deps = [
         "@crates.io//:cc",
@@ -83,10 +102,15 @@ rust_library(
     ],
 )
 
+copy_srcs(
+    name = "cxx-gen-srcs",
+    srcs = glob(["gen/lib/src/*.rs"])
+)
+
 rust_library(
     name = "cxx-gen",
-    srcs = glob(["gen/lib/src/**/*.rs"]),
-    compile_data = ["gen/lib/src/gen/include/cxx.h"],
+    srcs = [":cxx-gen-srcs"],
+    compile_data = ["include/cxx.h"],
     edition = "2021",
     visibility = ["//visibility:public"],
     deps = [