Move container-client-test image dependencies into separate pnpm package

gpanders · gpanders · commit 0f0816275e10 · 2025-12-02T08:47:58.000-06:00
diff --git a/.bazelignore b/.bazelignore
@@ -1,4 +1,5 @@
 node_modules
+images/container-client-test/node_modules
 
 # Nested modules
 build/google-benchmark
diff --git a/images/container-client-test/BUILD.bazel b/images/container-client-test/BUILD.bazel
@@ -1,10 +1,13 @@
 load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_image_layer")
 load("@rules_oci//oci:defs.bzl", "oci_image", "oci_load")
+load("@npm//:defs.bzl", "npm_link_all_packages")
+
+npm_link_all_packages(name = "node_modules")
 
 js_binary(
     name = "app",
     chdir = package_name(),
-    data = ["//:node_modules/ws"],
+    data = [":node_modules/ws"],
     entry_point = "app.js",
 )
 
diff --git a/images/container-client-test/package.json b/images/container-client-test/package.json
@@ -0,0 +1,11 @@
+{
+  "name": "container-client-test",
+  "private": true,
+  "version": "1.0.0",
+  "description": "",
+  "scripts": {},
+  "packageManager": "pnpm@10.18.3",
+  "devDependencies": {
+    "ws": "^8.18.3"
+  }
+}
diff --git a/package.json b/package.json
@@ -14,8 +14,7 @@
     "esbuild": "^0.25.10",
     "eslint": "^9.37.0",
     "expect-type": "^1.2.2",
-    "typescript-eslint": "^8.46.1",
-    "ws": "^8.18.3"
+    "typescript-eslint": "^8.46.1"
   },
   "pnpm": {
     "onlyBuiltDependencies": [
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -1,3 +1,7 @@
 minimumReleaseAge: 1440
 minimumReleaseAgeExclude:
 - '@types/node'
+
+packages:
+   - .
+   - images/container-client-test

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`node_modules`
	`2`	`+images/container-client-test/node_modules`
`2`	`3`
`3`	`4`	`# Nested modules`
`4`	`5`	`build/google-benchmark`