Skip to content

Commit 1e8a049

Browse files
authored
refactor(bzlmod): remove bind of @Icu (#5213)
1 parent 4aa0d6d commit 1e8a049

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

WORKSPACE

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@ load("@//build/deps:v8.bzl", "deps_v8")
2323

2424
deps_v8()
2525

26-
bind(
27-
name = "icu",
28-
actual = "@com_googlesource_chromium_icu//:icu",
29-
)
30-
3126
# Tell workerd code where to find v8.
3227
#
3328
# We indirect through `@workerd-v8` to allow dependents to override how and where `v8` is built.

build/deps/v8.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ PATCHES = [
3535
"0027-Implement-additional-Exception-construction-methods.patch",
3636
"0028-Export-icudata-file-to-facilitate-embedding-it.patch",
3737
"0029-IsGraphAsync-module-cast-check.patch",
38+
"0030-bind-icu-to-googlesource.patch",
3839
]
3940

4041
# V8 and its dependencies
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
--- a/BUILD.bazel
2+
+++ b/BUILD.bazel
3+
@@ -4517,7 +4517,7 @@
4+
copts = ["-Wno-implicit-fallthrough"],
5+
icu_deps = [
6+
":icu/generated_torque_definitions_headers",
7+
- "//external:icu",
8+
+ "@com_googlesource_chromium_icu//:icu",
9+
],
10+
icu_srcs = [
11+
":generated_regexp_special_case",
12+
@@ -4640,7 +4640,7 @@
13+
],
14+
deps = [
15+
":v8_libbase",
16+
- "//external:icu",
17+
+ "@com_googlesource_chromium_icu//:icu",
18+
],
19+
)
20+

0 commit comments

Comments
 (0)