Merge pull request #3800 from cloudflare/jphillips/v8-13.5

Update V8 13.4.114.17 -> 13.5.212.10.

Author: jp4a50

WORKSPACE

@@ -172,7 +172,7 @@ git_repository(
     # This should match the version specified in V8 DEPS, but in practice it is generally acceptable
     # for it to be behind – zlib is very stable and its API has not changed in a long time, most
     # changes to the Chromium fork affect ancillary tools and not the zlib library itself.
-    commit = "82a5fecf8aae8f288267cfdb2d29c9ebf7b37e59",
+    commit = "788cb3c270e8700b425c7bdca1f9ce6b0c1400a9",
     remote = "https://chromium.googlesource.com/chromium/src/third_party/zlib.git",
 )
 

build/deps/v8.bzl

@@ -1,9 +1,9 @@
 load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-VERSION = "13.4.114.17"
+VERSION = "13.5.212.10"
 
-INTEGRITY = "sha256-2oHxjMY9AI8zSRf4VU+eJE1q5lWHWKiZ/pnOJBuV2JM="
+INTEGRITY = "sha256-LEez3iJZH0OE91qkYjAeuf251mHuB/c8q5WonQp11a4="
 
 PATCHES = [
     "0001-Allow-manually-setting-ValueDeserializer-format-vers.patch",
@@ -26,11 +26,7 @@ PATCHES = [
     "0018-Disable-memory-leak-assert-when-shutting-down-V8.patch",
     "0019-Enable-V8-shared-linkage.patch",
     "0020-Fix-macOS-build.patch",
-    "0021-Delete-IsolateGroup-in-V8-Dispose.patch",
-    "0022-Reset-code_range_-before-pointer-compression-cage.patch",
-    "0023-Move-tear-down-in-IsolateGroup-Release-into-destruct.patch",
-    "0024-Modify-where-to-look-for-fast_float-and-simdutf.patch",
-    "0025-add-processed_characters-option-to-WriteUtf8V2.patch",
+    "0021-Modify-where-to-look-for-fast_float-and-simdutf.patch",
 ]
 
 # V8 and its dependencies
@@ -60,7 +56,7 @@ def deps_v8():
     git_repository(
         name = "com_googlesource_chromium_icu",
         build_file = "@v8//:bazel/BUILD.icu",
-        commit = "bbccc2f6efc1b825de5f2c903c48be685cd0cf22",
+        commit = "d30b7b0bb3829f2e220df403ed461a1ede78b774",
         patch_cmds = ["find source -name BUILD.bazel | xargs rm"],
         patch_cmds_win = ["Get-ChildItem -Path source -File -Include BUILD.bazel -Recurse | Remove-Item"],
         remote = "https://chromium.googlesource.com/chromium/deps/icu.git",

docs/v8-updates.md

@@ -18,13 +18,13 @@ To update the version of V8 used by workerd, the steps are:
 
 4. Sync the local copy of V8 to the version used by workerd.
 
-   First find, the tag of the V8 `http_archive` (`name = "v8"`) in the workerd [WORKSPACE](../WORKSPACE) file.
+   First, find workerd's current version of V8 in `v8.bzl`. We will call this `<old_version>`.
 
    Then sync your fetched version v8 based on the tag.
 
    ```sh
    cd <path_to_v8>/v8
-   git checkout <tag>
+   git checkout <old_version>
    gclient sync
    ```
 
@@ -36,55 +36,43 @@ To update the version of V8 used by workerd, the steps are:
    ```
 
 6. Rebase the workerd V8 changes onto the new version of V8. For example, assuming
-   we are updating to 11.4.183.8 and there are 19 workerd patches for V8, the
-   command would be:
+   we are updating to `<new_version>`, the command would be:
 
    ```sh
-   git rebase --onto 11.4.183.8 HEAD~19
+   git rebase --onto <new_version> <old_version>
    ```
 
-   Note that `HEAD~19`, here and elsewhere, could be replaced with
-   `$(git describe --tags --abbrev=0)`, which prints the name of the tag on which the
-   branch is based.
-
    There is usually some minor patch editing required during a rebase.
 
    Ideally at this stage, you should be able to build and test the local V8 with the
    patches applied. See the V8 [Testing](https://v8.dev/docs/test) page.
 
-7. Re-generate workerd's V8 patches. Assuming there are 19 workerd patches for V8,
-   the command would be:
+7. Re-generate workerd's V8 patches.
 
    ```sh
-   git format-patch --full-index -k --no-signature --no-stat --zero-commit HEAD~19
+   git format-patch --full-index -k --no-signature --no-stat --zero-commit <new_version>
    ```
 
-8. Remove the existing patches from `workerd/patches/v8` and copy over the latest generated patches
+8. Remove the existing patches from `<path_to_workerd>/patches/v8` and copy over the latest generated patches
 from the V8 directory.
 
-9. Update the `http_archive` for V8 in the `workerd/WORKSPACE` file.
+9. Update the `VERSION` for V8 in `v8.bzl`.
 
     The list of patches should be refreshed if new patches are being added or existing
     patches are being removed.
 
-    `strip_prefix` and `url` in the `http_archive` for V8 should be updated based on the new V8
-    version/tag.
-
-    The `integrity` check needs to be updated to the new value. You can get the new value in
+    `INTEGRITY` needs to be updated to the new value. You can get the new value in
     bazel's preferred format just by looking into the mismatch error while trying to compile
     workerd using the newer V8 version or by running
     `openssl dgst -sha256 -binary <tarball_filename> | openssl base64 -A`
 
-    See [V8 http_archive in WORKSPACE](https://github.com/cloudflare/workerd/blob/587ad90dd1e91d2660c271018056f4189fca3501/WORKSPACE#L408)
-
-10. Update V8's dependencies in `workerd/WORKSPACE`.
+10. Update V8's dependencies in `v8.bzl` and `WORKSPACE`.
 
-    You can find the commit versions for V8's dependencies under `v8/DEPS` and the ones
-    that are carried through to workerd in the `workerd/WORKSPACE` file.
+    You can find the commit versions for V8's dependencies under `<path_to_v8>/DEPS`.
 
     These currently include `zlib` and `com_googlesource_chromium_icu`.
     Typically you'll get a build failure if the projects are out of sync. Copy the
-    commit versions from `v8/DEPS` to the `WORKSPACE` file.
+    commit versions from `v8/DEPS` to the `v8.bzl` or `WORKSPACE` file.
 
 11. Check workerd's tests pass with the updated V8.
 

patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch

@@ -35,10 +35,10 @@ index 0cb3e045bc46ec732956318b980e749d1847d06d..40ad805c7970cc9379e69f046205836d
     * Reads raw data in various common formats to the buffer.
     * Note that integer types are read in base-128 varint format, not with a
 diff --git a/src/api/api.cc b/src/api/api.cc
-index 6fcf4f9c7e65b7a95f2d7db924695219ac9aaa3e..f38ba2110bf41fc4fe09e243c4833d5fb962c6d4 100644
+index 0ccd4a150caf4eabb3121219d2f2fc02b1d3539c..c5605259910e29e71ef6a97b5e23fdb7378cb1ad 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3637,6 +3637,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
+@@ -3459,6 +3459,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
    return private_->deserializer.GetWireFormatVersion();
  }
 
@@ -50,10 +50,10 @@ index 6fcf4f9c7e65b7a95f2d7db924695219ac9aaa3e..f38ba2110bf41fc4fe09e243c4833d5f
    PREPARE_FOR_EXECUTION(context, ValueDeserializer, ReadValue);
    i::MaybeDirectHandle<i::Object> result;
 diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
-index 47ee062e5acab8f187d640dec8665e7285df9e59..39021ed40fa46981db639719da7d3b1a5ea34e58 100644
+index fbe47397ea5dfda03f834ec2bff44ba57e1f2a96..395f3848f0d0e62c1515a33ab07e7ef46e15d0e6 100644
 --- a/src/objects/value-serializer.h
 +++ b/src/objects/value-serializer.h
-@@ -220,6 +220,13 @@ class ValueDeserializer {
+@@ -221,6 +221,13 @@ class ValueDeserializer {
     */
    uint32_t GetWireFormatVersion() const { return version_; }
 

patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch

@@ -22,10 +22,10 @@ index 40ad805c7970cc9379e69f046205836dbd760373..596be18adeb3a5a81794aaa44b1d347d
     * Writes out a header, which includes the format version.
     */
 diff --git a/src/api/api.cc b/src/api/api.cc
-index f38ba2110bf41fc4fe09e243c4833d5fb962c6d4..56483742053c7f3e59b73c9d2e789239067cdc0a 100644
+index c5605259910e29e71ef6a97b5e23fdb7378cb1ad..5c6315a5c20f026f6e780aa05ed2ade7ff317ceb 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3505,6 +3505,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
+@@ -3327,6 +3327,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
 
  ValueSerializer::~ValueSerializer() { delete private_; }
 
@@ -37,7 +37,7 @@ index f38ba2110bf41fc4fe09e243c4833d5fb962c6d4..56483742053c7f3e59b73c9d2e789239
 
  void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
 diff --git a/src/objects/value-serializer.cc b/src/objects/value-serializer.cc
-index 735cda53cac436d659bd7ad09a1e2eaecc2493fc..1b3dcf71d4c682ff2db23718ee54b86121f1f1c8 100644
+index 49ad642086bf85ab67c55482111e2c89e6db657c..9bd318b43b7ac3a9ef54af0be077e29155cdcfa0 100644
 --- a/src/objects/value-serializer.cc
 +++ b/src/objects/value-serializer.cc
 @@ -291,6 +291,7 @@ ValueSerializer::ValueSerializer(Isolate* isolate,
@@ -67,7 +67,7 @@ index 735cda53cac436d659bd7ad09a1e2eaecc2493fc..1b3dcf71d4c682ff2db23718ee54b861
  }
 
  void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
-@@ -1033,10 +1042,12 @@ Maybe<bool> ValueSerializer::WriteJSArrayBufferView(
+@@ -1037,10 +1046,12 @@ Maybe<bool> ValueSerializer::WriteJSArrayBufferView(
    WriteVarint(static_cast<uint8_t>(tag));
    WriteVarint(static_cast<uint32_t>(view->byte_offset()));
    WriteVarint(static_cast<uint32_t>(view->byte_length()));
@@ -83,7 +83,7 @@ index 735cda53cac436d659bd7ad09a1e2eaecc2493fc..1b3dcf71d4c682ff2db23718ee54b861
  }
 
 diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
-index 39021ed40fa46981db639719da7d3b1a5ea34e58..ec79ccae64617547239b2b48c01a2be6ce43d035 100644
+index 395f3848f0d0e62c1515a33ab07e7ef46e15d0e6..a463753df6ee29e79768829c7b7d5b3136bd997d 100644
 --- a/src/objects/value-serializer.h
 +++ b/src/objects/value-serializer.h
 @@ -54,6 +54,11 @@ class ValueSerializer {
@@ -98,7 +98,7 @@ index 39021ed40fa46981db639719da7d3b1a5ea34e58..ec79ccae64617547239b2b48c01a2be6
    /*
     * Writes out a header, which includes the format version.
     */
-@@ -181,6 +186,7 @@ class ValueSerializer {
+@@ -182,6 +187,7 @@ class ValueSerializer {
    bool treat_array_buffer_views_as_host_objects_ = false;
    bool out_of_memory_ = false;
    Zone zone_;

patches/v8/0003-Allow-Windows-builds-under-Bazel.patch

@@ -5,10 +5,10 @@ Subject: Allow Windows builds under Bazel
 
 
 diff --git a/BUILD.bazel b/BUILD.bazel
-index 967f7bbfb2810366de89b7a7a90f284efab6c9c6..702648004a7c68721c80e7b43cdcd355ceb16710 100644
+index f8c653bd7eaf1df8b484c1badef4f411387a8fb5..7521eac6a6a0ef4777e2d7602bda9e7495a00d24 100644
 --- a/BUILD.bazel
 +++ b/BUILD.bazel
-@@ -3829,6 +3829,8 @@ filegroup(
+@@ -3848,6 +3848,8 @@ filegroup(
          "@v8//bazel/config:is_inline_asm_x64": ["src/heap/base/asm/x64/push_registers_asm.cc"],
          "@v8//bazel/config:is_inline_asm_arm": ["src/heap/base/asm/arm/push_registers_asm.cc"],
          "@v8//bazel/config:is_inline_asm_arm64": ["src/heap/base/asm/arm64/push_registers_asm.cc"],

patches/v8/0005-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch

@@ -8,7 +8,7 @@ speedup for the build: Components like ICU were previously compiled in
 both target and exec configurations as generator tools depend on them.
 
 diff --git a/BUILD.bazel b/BUILD.bazel
-index 702648004a7c68721c80e7b43cdcd355ceb16710..e65bd03bec247979b2825584f5b59e5ab0c40283 100644
+index 7521eac6a6a0ef4777e2d7602bda9e7495a00d24..56c6f15cbcbcedaae0176ca5fe45e29dd155afe9 100644
 --- a/BUILD.bazel
 +++ b/BUILD.bazel
 @@ -17,6 +17,7 @@ load(
@@ -19,7 +19,7 @@ index 702648004a7c68721c80e7b43cdcd355ceb16710..e65bd03bec247979b2825584f5b59e5a
  )
  load(":bazel/v8-non-pointer-compression.bzl", "v8_binary_non_pointer_compression")
 
-@@ -4217,22 +4218,20 @@ filegroup(
+@@ -4235,22 +4236,20 @@ filegroup(
      ],
  )
 
@@ -48,7 +48,7 @@ index 702648004a7c68721c80e7b43cdcd355ceb16710..e65bd03bec247979b2825584f5b59e5a
  )
 
  v8_mksnapshot(
-@@ -4441,7 +4440,6 @@ v8_binary(
+@@ -4459,7 +4458,6 @@ v8_binary(
      srcs = [
          "src/regexp/gen-regexp-special-case.cc",
          "src/regexp/special-case.h",