[o11y] Clean up lint in STW tests, obsolete compat flag

Author: fhanau

src/workerd/api/actor-kv-test-tail.js

@@ -4,9 +4,6 @@ let invocationPromises = [];
 let spans = new Map();
 
 export default {
-  async fetch(ctrl, env, ctx) {
-    return new Response('');
-  },
   async test(ctrl, env, ctx) {
     const expected = [
       {
@@ -47,7 +44,6 @@ export default {
     return (event) => {
       switch (event.event.type) {
         case 'spanOpen':
-          console.log('span open', event.event.name);
           if (event.event.name === 'durable_object_subrequest') {
             let span = spans.get(event.event.spanId);
             span['subrequests'] = span['subrequests']
@@ -60,7 +56,6 @@ export default {
           }
           break;
         case 'attributes': {
-          console.log('attributes', event);
           let span = spans.get(event.event.spanId);
           for (let { name, value } of event.event.info) {
             span[name] = value;

src/workerd/api/actor-kv-test.wd-test

@@ -10,7 +10,7 @@ const config :Workerd.Config = (
 
 const mainWorker :Workerd.Worker = (
   compatibilityDate = "2022-09-16",
-  compatibilityFlags = ["experimental", "nodejs_compat", "streaming_tail_worker", "tail_worker_user_spans"],
+  compatibilityFlags = ["experimental", "nodejs_compat", "streaming_tail_worker"],
 
   streamingTails = ["tail"],
 

src/workerd/api/kv-test.wd-test

@@ -10,7 +10,7 @@ const unitTests :Workerd.Config = (
         bindings = [ ( name = "KV", kvNamespace = "kv-test" ), ],
         compatibilityDate = "2023-07-24",
         # "experimental" flag is needed to test deleteBulk
-        compatibilityFlags = ["experimental", "nodejs_compat", "service_binding_extra_handlers", "streaming_tail_worker", "tail_worker_user_spans"],
+        compatibilityFlags = ["experimental", "nodejs_compat", "service_binding_extra_handlers", "streaming_tail_worker"],
         streamingTails = ["tail"],
       )
     ),

src/workerd/api/r2-test.wd-test

@@ -12,7 +12,7 @@ const unitTests :Workerd.Config = (
           ( name = "SERVICE", service = "r2-test" ),
         ],
         compatibilityDate = "2023-07-24",
-        compatibilityFlags = ["nodejs_compat", "service_binding_extra_handlers", "streaming_tail_worker", "tail_worker_user_spans"],
+        compatibilityFlags = ["nodejs_compat", "service_binding_extra_handlers", "streaming_tail_worker"],
         streamingTails = ["tail"],
       )
     ),

src/workerd/api/sql-test.wd-test

@@ -14,7 +14,7 @@ const mainWorker :Workerd.Worker = (
   compatibilityDate = "2024-03-04",
 
   # "experimental" flag is needed to test `sql.ingest()` and `sql.prepare()`.
-  compatibilityFlags = ["experimental", "nodejs_compat", "streaming_tail_worker", "tail_worker_user_spans"],
+  compatibilityFlags = ["experimental", "nodejs_compat", "streaming_tail_worker"],
 
   modules = [
     (name = "worker", esModule = embed "sql-test.js"),

src/workerd/api/tail-worker-test.wd-test

@@ -13,7 +13,7 @@ const unitTests :Workerd.Config = (
           ( name = "CACHE_ENABLED", json = "false" ),
         ],
         compatibilityDate = "2023-08-01",
-        compatibilityFlags = ["nodejs_compat", "service_binding_extra_handlers", "cache_option_disabled", "streaming_tail_worker", "tail_worker_user_spans"],
+        compatibilityFlags = ["nodejs_compat", "service_binding_extra_handlers", "cache_option_disabled", "streaming_tail_worker"],
         streamingTails = ["log", "log-invalid"],
       ),
     ),

src/workerd/io/compatibility-date.capnp

@@ -634,7 +634,6 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
   # correctly. The fix, however, can break existing implementations that don't account
   # for the bug so we need to put the fix behind a compat flag.
 
-  # Experimental support for exporting user spans to tail worker.
   obsolete69 @69 :Bool
       $compatEnableFlag("tail_worker_user_spans")
       $experimental;

src/workerd/io/trace.h

@@ -554,8 +554,6 @@ struct Exception final {
 
 // EventInfo types are used to describe the onset of an invocation. The FetchEventInfo
 // can also be used to describe the start of a fetch subrequest.
-// TODO(o11y): Write KJ_STRINGIFY() for EventInfo to beef up logging for events reported after
-// stream close.
 using EventInfo = kj::OneOf<FetchEventInfo,
     JsRpcEventInfo,
     ScheduledEventInfo,