Skip to content

Commit 430bd0a

Browse files
authored
Python: In 0.28.2 tests, use stacked snapshot by default (#5350)
This will give us much better coverage of the stacked snapshots we are generally making in production
1 parent e562cc0 commit 430bd0a

File tree

12 files changed

+27
-22
lines changed

12 files changed

+27
-22
lines changed

build/python_metadata.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ def _make_bundle_version_info(versions):
8686
name = entry["name"]
8787
if name != "development":
8888
entry["id"] = _bundle_id(**entry)
89+
entry["real_pyodide_version"] = entry["pyodide_version"]
8990
entry["feature_flags"] = [entry["flag"]]
9091
entry["feature_string_flags"] = [entry["enable_flag_name"]]
9192
if "packages" in entry:

src/cloudflare/internal/test/ai/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ py_wd_test(
1717
]),
1818
# Works but times out frequently
1919
make_snapshot = False,
20+
use_snapshot = None,
2021
)

src/cloudflare/internal/test/aig/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ py_wd_test(
1717
]),
1818
# Works but times out
1919
make_snapshot = False,
20+
use_snapshot = None,
2021
)

src/cloudflare/internal/test/autorag/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ py_wd_test(
1717
]),
1818
# Works but times out
1919
make_snapshot = False,
20+
use_snapshot = None,
2021
)

src/cloudflare/internal/test/br/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ py_wd_test(
1717
]),
1818
# Works but times out
1919
make_snapshot = False,
20+
use_snapshot = None,
2021
)

src/cloudflare/internal/test/d1/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,5 @@ py_wd_test(
2525
"*.js",
2626
]),
2727
make_snapshot = False,
28+
use_snapshot = None,
2829
)

src/cloudflare/internal/test/to-markdown/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ py_wd_test(
1717
]),
1818
# Works but times out frequently
1919
make_snapshot = False,
20+
use_snapshot = None,
2021
)

src/cloudflare/internal/test/vectorize/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ py_wd_test(
1515
]),
1616
# Works but times out
1717
make_snapshot = False,
18+
use_snapshot = None,
1819
)

src/workerd/server/tests/python/BUILD.bazel

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,11 @@ py_wd_test(
4949

5050
py_wd_test("js-import")
5151

52-
py_wd_test("importable-env")
52+
py_wd_test(
53+
"importable-env",
54+
# TODO: why doesn't dedicated snapshot work with this?
55+
use_snapshot = None,
56+
)
5357

5458
py_wd_test("python-rpc")
5559

@@ -72,21 +76,3 @@ py_wd_test(
7276
make_snapshot = False,
7377
use_snapshot = "numpy",
7478
)
75-
76-
py_wd_test(
77-
name = "numpy_stacked_snapshot",
78-
directory = "numpy",
79-
feature_flags = ["python_dedicated_snapshot"],
80-
make_snapshot = True,
81-
python_flags = ["0.28.2"],
82-
use_snapshot = "baseline",
83-
)
84-
85-
py_wd_test(
86-
name = "fastapi_stacked_snapshot",
87-
directory = "fastapi",
88-
feature_flags = ["python_dedicated_snapshot"],
89-
make_snapshot = True,
90-
python_flags = ["0.28.2"],
91-
use_snapshot = "baseline",
92-
)

src/workerd/server/tests/python/import_tests.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ def _test(name, directory, wd_test, py_file, python_version, **kwds):
4343
directory = directory,
4444
src = wd_test,
4545
python_flags = [python_version],
46+
use_snapshot = None,
4647
make_snapshot = False,
4748
args = ["--experimental", "--pyodide-package-disk-cache-dir", "../all_pyodide_wheels_%s" % pkg_tag],
4849
skip_default_data = True,

0 commit comments

Comments
 (0)