EW-9332 Update deprecated V8 function usage

DCHECKs started failing in V8 14.2 until I heeded these warnings.

It appears that some of these functions were previously already updated.
I followed existing convention of using a static_cast of the index
argument as its own embedder tag.

Author: harrishancock

src/workerd/jsg/ser.c++

@@ -297,8 +297,15 @@ v8::Maybe<bool> Serializer::WriteHostObject(v8::Isolate* isolate, v8::Local<v8::
       throwDataCloneErrorForObject(js, object);
     }
 
+    // TODO(cleanup): Remove this #if when workerd's V8 version is updated to 14.2.
+#if V8_MAJOR_VERSION < 14 || V8_MINOR_VERSION < 2
     Wrappable* wrappable = reinterpret_cast<Wrappable*>(
         object->GetAlignedPointerFromInternalField(Wrappable::WRAPPED_OBJECT_FIELD_INDEX));
+#else
+    Wrappable* wrappable = reinterpret_cast<Wrappable*>(
+        object->GetAlignedPointerFromInternalField(Wrappable::WRAPPED_OBJECT_FIELD_INDEX,
+            static_cast<v8::EmbedderDataTypeTag>(Wrappable::WRAPPED_OBJECT_FIELD_INDEX)));
+#endif
 
     // HACK: Although we don't technically know yet that `wrappable` is an `Object`, we know that
     //   only subclasses of `Object` register serializers. So *if* a serializer is found, then this

src/workerd/jsg/setup.c++

@@ -302,10 +302,17 @@ void HeapTracer::ResetRoot(const v8::TracedReference<v8::Value>& handle) {
   // V8 calls this to tell us when our wrapper can be dropped. See comment about droppable
   // references in Wrappable::attachWrapper() for details.
   v8::HandleScope scope(isolate);
+  // TODO(cleanup): Remove this #if when workerd's V8 version is updated to 14.2.
+#if V8_MAJOR_VERSION < 14 || V8_MINOR_VERSION < 2
   auto& wrappable = *static_cast<Wrappable*>(
       handle.As<v8::Object>().Get(isolate)->GetAlignedPointerFromInternalField(
           Wrappable::WRAPPED_OBJECT_FIELD_INDEX));
-
+#else
+  auto& wrappable = *static_cast<Wrappable*>(
+      handle.As<v8::Object>().Get(isolate)->GetAlignedPointerFromInternalField(
+          Wrappable::WRAPPED_OBJECT_FIELD_INDEX,
+          static_cast<v8::EmbedderDataTypeTag>(Wrappable::WRAPPED_OBJECT_FIELD_INDEX)));
+#endif
   // V8 gets angry if we do not EXPLICITLY call `Reset()` on the wrapper. If we merely destroy it
   // (which is what `detachWrapper()` will do) it is not satisfied, and will come back and try to
   // visit the reference again, but it will DCHECK-fail on that second attempt because the

src/workerd/jsg/setup.h

@@ -801,8 +801,15 @@ class Isolate: public IsolateBase {
       if (instance.IsEmpty()) {
         return kj::none;
       } else {
+        // TODO(cleanup): Remove this #if when workerd's V8 version is updated to 14.2.
+#if V8_MAJOR_VERSION < 14 || V8_MINOR_VERSION < 2
         return *reinterpret_cast<Object*>(
             instance->GetAlignedPointerFromInternalField(Wrappable::WRAPPED_OBJECT_FIELD_INDEX));
+#else
+        return *reinterpret_cast<Object*>(
+            instance->GetAlignedPointerFromInternalField(Wrappable::WRAPPED_OBJECT_FIELD_INDEX,
+                static_cast<v8::EmbedderDataTypeTag>(Wrappable::WRAPPED_OBJECT_FIELD_INDEX)));
+#endif
       }
     }
 

src/workerd/jsg/wrappable.c++

@@ -416,8 +416,15 @@ kj::Maybe<Wrappable&> Wrappable::tryUnwrapOpaque(
         v8::Local<v8::Object>::Cast(handle)->FindInstanceInPrototypeChain(
             IsolateBase::getOpaqueTemplate(isolate));
     if (!instance.IsEmpty()) {
+      // TODO(cleanup): Remove this #if when workerd's V8 version is updated to 14.2.
+#if V8_MAJOR_VERSION < 14 || V8_MINOR_VERSION < 2
       return *reinterpret_cast<Wrappable*>(
           instance->GetAlignedPointerFromInternalField(WRAPPED_OBJECT_FIELD_INDEX));
+#else
+      return *reinterpret_cast<Wrappable*>(
+          instance->GetAlignedPointerFromInternalField(WRAPPED_OBJECT_FIELD_INDEX,
+              static_cast<v8::EmbedderDataTypeTag>(WRAPPED_OBJECT_FIELD_INDEX)));
+#endif
     }
   }
 

src/workerd/jsg/wrappable.h

@@ -10,6 +10,7 @@
 
 #include <v8-context.h>
 #include <v8-object.h>
+#include <v8-version.h>
 
 #include <kj/common.h>
 #include <kj/debug.h>
@@ -55,7 +56,13 @@ template <typename T>
 kj::Maybe<T&> getAlignedPointerFromEmbedderData(
     v8::Local<v8::Context> context, ContextPointerSlot slot) {
   KJ_DASSERT(slot != ContextPointerSlot::RESERVED, "Attempt to use reserved embedder data slot.");
+  // TODO(cleanup): Remove this #if when workerd's V8 version is updated to 14.2.
+#if V8_MAJOR_VERSION < 14 || V8_MINOR_VERSION < 2
   void* ptr = context->GetAlignedPointerFromEmbedderData(static_cast<int>(slot));
+#else
+  void* ptr = context->GetAlignedPointerFromEmbedderData(
+      static_cast<int>(slot), static_cast<v8::EmbedderDataTypeTag>(slot));
+#endif
   if (ptr == nullptr) return kj::none;
   return *reinterpret_cast<T*>(ptr);
 }
@@ -109,8 +116,15 @@ class Wrappable: public kj::Refcounted {
   static constexpr uint16_t WORKERD_WRAPPABLE_TAG = 0xeb04;
 
   static bool isWorkerdApiObject(v8::Local<v8::Object> object) {
+    // TODO(cleanup): Remove this #if when workerd's V8 version is updated to 14.2.
+#if V8_MAJOR_VERSION < 14 || V8_MINOR_VERSION < 2
     return object->GetAlignedPointerFromInternalField(WRAPPABLE_TAG_FIELD_INDEX) ==
         &WORKERD_WRAPPABLE_TAG;
+#else
+    return object->GetAlignedPointerFromInternalField(WRAPPABLE_TAG_FIELD_INDEX,
+               static_cast<v8::EmbedderDataTypeTag>(WRAPPABLE_TAG_FIELD_INDEX)) ==
+        &WORKERD_WRAPPABLE_TAG;
+#endif
   }
 
   void addStrongRef();
@@ -315,8 +329,15 @@ T& extractInternalPointer(
         getAlignedPointerFromEmbedderData<T>(context, ContextPointerSlot::GLOBAL_WRAPPER));
   } else {
     KJ_ASSERT(object->InternalFieldCount() == Wrappable::INTERNAL_FIELD_COUNT);
+    // TODO(cleanup): Remove this #if when workerd's V8 version is updated to 14.2.
+#if V8_MAJOR_VERSION < 14 || V8_MINOR_VERSION < 2
     return *reinterpret_cast<T*>(
         object->GetAlignedPointerFromInternalField(Wrappable::WRAPPED_OBJECT_FIELD_INDEX));
+#else
+    return *reinterpret_cast<T*>(
+        object->GetAlignedPointerFromInternalField(Wrappable::WRAPPED_OBJECT_FIELD_INDEX,
+            static_cast<v8::EmbedderDataTypeTag>(Wrappable::WRAPPED_OBJECT_FIELD_INDEX)));
+#endif
   }
 }