Skip to content

Commit 48990e7

Browse files
authored
Merge pull request #5421 from cloudflare/mar/def-dtor
Upgrade error for invalid deferDestruction queue state.
2 parents de948b8 + b8efcca commit 48990e7

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/workerd/jsg/setup.c++

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,10 +231,8 @@ void IsolateBase::jsgGetMemoryInfo(MemoryTracker& tracker) const {
231231

232232
void IsolateBase::deferDestruction(Item item) {
233233
KJ_REQUIRE_NONNULL(ptr, "tried to defer destruction after V8 isolate was destroyed");
234-
if (queueState != QueueState::ACTIVE) {
235-
KJ_LOG(ERROR, "tried to defer destruction during isolate shutdown", queueState,
236-
kj::getStackTrace());
237-
}
234+
KJ_REQUIRE(queueState == QueueState::ACTIVE, "tried to defer destruction during isolate shutdown",
235+
queueState);
238236
queue.lockExclusive()->push(kj::mv(item));
239237
}
240238

0 commit comments

Comments
 (0)