Skip to content

Commit 58b89fa

Browse files
authored
Merge pull request #3885 from cloudflare/yagiz/remove-unnecessary-ts-override
remove unnecessary JSG_TS_OVERRIDE calls
2 parents 0bbde7e + 4fab6c2 commit 58b89fa

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

src/workerd/api/global-scope.c++

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -694,9 +694,7 @@ void ServiceWorkerGlobalScope::emitPromiseRejection(jsg::Lock& js,
694694
}
695695
}
696696

697-
jsg::JsString ServiceWorkerGlobalScope::btoa(jsg::Lock& js, jsg::JsValue data) {
698-
auto str = data.toJsString(js);
699-
697+
jsg::JsString ServiceWorkerGlobalScope::btoa(jsg::Lock& js, jsg::JsString str) {
700698
// We could implement btoa() by accepting a kj::String, but then we'd have to check that it
701699
// doesn't have any multibyte code points. Easier to perform that test using v8::String's
702700
// ContainsOnlyOneByte() function.

src/workerd/api/global-scope.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,6 @@ class Navigator: public jsg::Object {
9797
#ifdef WORKERD_EXPERIMENTAL_ENABLE_WEBGPU
9898
JSG_READONLY_INSTANCE_PROPERTY(gpu, getGPU);
9999
#endif
100-
101-
JSG_TS_OVERRIDE({ readonly hardwareConcurrency: number; });
102100
}
103101
};
104102

@@ -530,7 +528,7 @@ class ServiceWorkerGlobalScope: public WorkerGlobalScope {
530528
// ---------------------------------------------------------------------------
531529
// JS API
532530

533-
jsg::JsString btoa(jsg::Lock& js, jsg::JsValue data);
531+
jsg::JsString btoa(jsg::Lock& js, jsg::JsString data);
534532
jsg::JsString atob(jsg::Lock& js, kj::String data);
535533

536534
void queueMicrotask(jsg::Lock& js, v8::Local<v8::Function> task);
@@ -879,8 +877,6 @@ class ServiceWorkerGlobalScope: public WorkerGlobalScope {
879877
// `Module` is also declared `abstract` to disable its `BufferSource` constructor.
880878

881879
JSG_TS_OVERRIDE({
882-
btoa(data: string): string;
883-
884880
setTimeout(callback: (...args: any[]) => void, msDelay?: number): number;
885881
setTimeout<Args extends any[]>(callback: (...args: Args) => void, msDelay?: number, ...args: Args): number;
886882

src/workerd/api/urlpattern-standard.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,6 @@ class URLPattern final: public jsg::Object {
127127
JSG_READONLY_PROTOTYPE_PROPERTY(hasRegExpGroups, getHasRegExpGroups);
128128
JSG_METHOD(test);
129129
JSG_METHOD(exec);
130-
131-
JSG_TS_OVERRIDE({
132-
get hasRegExpGroups(): boolean;
133-
});
134130
}
135131

136132
private:

0 commit comments

Comments
 (0)