Merge pull request #3093 from cloudflare/chore/v8-13.1-upgrade

Upgrade V8 13.0.245.16 -> 13.1.201.8

Author: ObsidianMinor

.bazelrc

@@ -19,6 +19,9 @@ build --experimental_remote_cache_eviction_retries=5
 # Note that we use remote_download_minimal for test builds, which avoids fetching build outputs
 # where possible. While several previous BwoB bugs have been fixed, this is slower than it could be
 # due to https://github.com/bazelbuild/bazel/issues/20576.
+# Windows build is failing on some runs due to FileAccessException errors, Bazel has had several
+# similar bugs in the past. Disable BwoB for now.
+build:windows --remote_download_all
 
 # Import CI-specific configuration. As the amount of custom configuration settings we use grows,
 # consider moving more flags out to separate files.

WORKSPACE

@@ -122,7 +122,7 @@ filegroup(
 #
 git_repository(
     name = "com_google_absl",
-    commit = "ed3733b91e472a1e7a641c1f0c1e6c0ea698e958",
+    commit = "dc257ad54f38739767a6cb26eb57fd51c37bfe3c",
     remote = "https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git",
 )
 
@@ -175,7 +175,7 @@ git_repository(
     name = "zlib",
     build_file = "//:build/BUILD.zlib",
     # Must match the version used by v8
-    commit = "d3aea2341cdeaf7e717bc257a59aa7a9407d318a",
+    commit = "fa9f14143c7938e6a1d18443900efee7a1e5e669",
     remote = "https://chromium.googlesource.com/chromium/src/third_party/zlib.git",
 )
 
@@ -280,32 +280,31 @@ esbuild_register_toolchains(
 
 http_archive(
     name = "v8",
-    integrity = "sha256-2jQHW96t3jpEsjOlv9yyjgUem3kKNnpDAIDR4PPFSnw=",
+    integrity = "sha256-s+oY+fAG0cXTGmKDxbioUudjUciK1dU2reu7lZ+uB1w=",
     patch_args = ["-p1"],
     patches = [
         "//:patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch",
         "//:patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch",
-        "//:patches/v8/0003-Add-ArrayBuffer-MaybeNew.patch",
-        "//:patches/v8/0004-Allow-Windows-builds-under-Bazel.patch",
-        "//:patches/v8/0005-Disable-bazel-whole-archive-build.patch",
-        "//:patches/v8/0006-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch",
-        "//:patches/v8/0007-Implement-Promise-Context-Tagging.patch",
-        "//:patches/v8/0008-Enable-V8-shared-linkage.patch",
-        "//:patches/v8/0009-Randomize-the-initial-ExecutionContextId-used-by-the.patch",
-        "//:patches/v8/0010-increase-visibility-of-virtual-method.patch",
-        "//:patches/v8/0011-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch",
-        "//:patches/v8/0012-Set-torque-generator-path-to-external-v8.-This-allow.patch",
-        "//:patches/v8/0013-Modify-where-to-look-for-fp16-dependency.-This-depen.patch",
-        "//:patches/v8/0014-Expose-v8-Symbol-GetDispose.patch",
-        "//:patches/v8/0015-Rename-V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE-V8_COMPR.patch",
-        "//:patches/v8/0016-Revert-TracedReference-deref-API-removal.patch",
-        "//:patches/v8/0017-Revert-heap-Add-masm-specific-unwinding-annotations-.patch",
-        "//:patches/v8/0018-Update-illegal-invocation-error-message-in-v8.patch",
-        "//:patches/v8/0019-Implement-cross-request-context-promise-resolve-hand.patch",
-        "//:patches/v8/0020-Modify-where-to-look-for-fast_float-dependency.patch",
+        "//:patches/v8/0003-Allow-Windows-builds-under-Bazel.patch",
+        "//:patches/v8/0004-Disable-bazel-whole-archive-build.patch",
+        "//:patches/v8/0005-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch",
+        "//:patches/v8/0006-Implement-Promise-Context-Tagging.patch",
+        "//:patches/v8/0007-Randomize-the-initial-ExecutionContextId-used-by-the.patch",
+        "//:patches/v8/0008-increase-visibility-of-virtual-method.patch",
+        "//:patches/v8/0009-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch",
+        "//:patches/v8/0010-Set-torque-generator-path-to-external-v8.-This-allow.patch",
+        "//:patches/v8/0011-Modify-where-to-look-for-fp16-dependency.-This-depen.patch",
+        "//:patches/v8/0012-Expose-v8-Symbol-GetDispose.patch",
+        "//:patches/v8/0013-Revert-TracedReference-deref-API-removal.patch",
+        "//:patches/v8/0014-Revert-heap-Add-masm-specific-unwinding-annotations-.patch",
+        "//:patches/v8/0015-Update-illegal-invocation-error-message-in-v8.patch",
+        "//:patches/v8/0016-Implement-cross-request-context-promise-resolve-hand.patch",
+        "//:patches/v8/0017-Modify-where-to-look-for-fast_float-dependency.patch",
+        "//:patches/v8/0018-Return-rejected-promise-from-WebAssembly.compile-if-.patch",
+        "//:patches/v8/0019-codegen-Don-t-pass-a-nullptr-in-InitUnwindingRecord-.patch",
     ],
-    strip_prefix = "v8-13.0.245.16",
-    url = "https://github.com/v8/v8/archive/refs/tags/13.0.245.16.tar.gz",
+    strip_prefix = "v8-13.1.201.8",
+    url = "https://github.com/v8/v8/archive/refs/tags/13.1.201.8.tar.gz",
 )
 
 git_repository(

patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch

@@ -1,4 +1,4 @@
-From 9d82ceca73562418e6ea9be81d8fc985e9b10f2e Mon Sep 17 00:00:00 2001
+From 0d006413157bb6d286eca2dff77956a9e4ed36e5 Mon Sep 17 00:00:00 2001
 From: Alex Robinson <[email protected]>
 Date: Wed, 2 Mar 2022 15:58:04 -0600
 Subject: Allow manually setting ValueDeserializer format version
@@ -35,10 +35,10 @@ index 0cb3e045bc46ec732956318b980e749d1847d06d..40ad805c7970cc9379e69f046205836d
     * Reads raw data in various common formats to the buffer.
     * Note that integer types are read in base-128 varint format, not with a
 diff --git a/src/api/api.cc b/src/api/api.cc
-index eddb472d5608567255c5f55f4ae8b451abe5f6d3..c86687981fab3ed28306ada00c9d5dff5c594377 100644
+index 29dd26037bc9ce4c21f421cba32bc3077bb064d2..cda724c712dda198f3c0c6b1d94e0a6d70b745fd 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3605,6 +3605,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
+@@ -3619,6 +3619,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
    return private_->deserializer.GetWireFormatVersion();
  }
 

patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch

@@ -1,4 +1,4 @@
-From d4de923519e992bf2e5f1bf4a19f410d41791e10 Mon Sep 17 00:00:00 2001
+From 8aa5173892d869765d77bbe83e3c97ba5be123b3 Mon Sep 17 00:00:00 2001
 From: James M Snell <[email protected]>
 Date: Wed, 16 Mar 2022 08:59:21 -0700
 Subject: Allow manually setting ValueSerializer format version
@@ -22,10 +22,10 @@ index 40ad805c7970cc9379e69f046205836dbd760373..596be18adeb3a5a81794aaa44b1d347d
     * Writes out a header, which includes the format version.
     */
 diff --git a/src/api/api.cc b/src/api/api.cc
-index c86687981fab3ed28306ada00c9d5dff5c594377..7058f9a13cb73cbbd0602ddeb589268306ee45ea 100644
+index cda724c712dda198f3c0c6b1d94e0a6d70b745fd..b69788395974538231aa3d2094453630d0c4f62a 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3473,6 +3473,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
+@@ -3487,6 +3487,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
 
  ValueSerializer::~ValueSerializer() { delete private_; }
 
@@ -37,7 +37,7 @@ index c86687981fab3ed28306ada00c9d5dff5c594377..7058f9a13cb73cbbd0602ddeb5892683
 
  void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
 diff --git a/src/objects/value-serializer.cc b/src/objects/value-serializer.cc
-index 51abbe13a599ce3a0f1b7d6fffea3abcfbfbafa4..eeb74aa42a9d783bbfdedc171717422321435c3a 100644
+index b62f2f907806fa3fa6189e15908aaeb218b06b82..187700b273d5d79b79b554d597ca6e605cdb4d26 100644
 --- a/src/objects/value-serializer.cc
 +++ b/src/objects/value-serializer.cc
 @@ -291,6 +291,7 @@ ValueSerializer::ValueSerializer(Isolate* isolate,

patches/v8/0003-Add-ArrayBuffer-MaybeNew.patch

@@ -1,46 +1,46 @@
-From 6dfefbe388136c0d648e7cee0c2080c7eaac7861 Mon Sep 17 00:00:00 2001
+From 162d27ca507656e5f99c407fa31cef577b7266cf Mon Sep 17 00:00:00 2001
 From: Brendan Coll <[email protected]>
 Date: Thu, 16 Mar 2023 11:56:10 +0000
 Subject: Allow Windows builds under Bazel
 
 
 diff --git a/BUILD.bazel b/BUILD.bazel
-index 1f269f9c149e56a7098697fc2346b5998b0c6e01..89bc2f54fc5e42a2cf6d6fa41742c2dfe2c9ab48 100644
+index 762483456429100f864e9d3f25e6e974c8bd8f05..80bf8f89783334bbcf44f05a8de3f32dd04790f0 100644
 --- a/BUILD.bazel
 +++ b/BUILD.bazel
-@@ -817,6 +817,7 @@ filegroup(
+@@ -826,6 +826,7 @@ filegroup(
          "src/base/platform/mutex.h",
          "src/base/platform/platform.cc",
          "src/base/platform/platform.h",
 +        "src/base/platform/platform-posix.h",  # Always included by src/execution/isolate.h
          "src/base/platform/semaphore.cc",
          "src/base/platform/semaphore.h",
          "src/base/platform/time.cc",
-@@ -860,7 +861,6 @@ filegroup(
+@@ -869,7 +870,6 @@ filegroup(
      ] + select({
          "@v8//bazel/config:is_posix": [
              "src/base/platform/platform-posix.cc",
 -            "src/base/platform/platform-posix.h",
              "src/base/platform/platform-posix-time.cc",
              "src/base/platform/platform-posix-time.h",
          ],
-@@ -883,6 +883,7 @@ filegroup(
+@@ -892,6 +892,7 @@ filegroup(
          "@v8//bazel/config:is_windows": [
              "src/base/debug/stack_trace_win.cc",
              "src/base/platform/platform-win32.cc",
 +            "src/base/platform/platform-win32.h",
              "src/base/win32-headers.h",
          ],
      }),
-@@ -1265,6 +1266,7 @@ filegroup(
+@@ -1274,6 +1275,7 @@ filegroup(
          "include/v8-wasm-trap-handler-posix.h",
          "src/api/api.cc",
          "src/api/api.h",
 +        "include/v8-wasm-trap-handler-win.h",
          "src/api/api-arguments.cc",
          "src/api/api-arguments.h",
          "src/api/api-arguments-inl.h",
-@@ -2739,6 +2741,11 @@ filegroup(
+@@ -2755,6 +2757,11 @@ filegroup(
              "src/trap-handler/handler-inside-posix.cc",
              "src/trap-handler/handler-outside-posix.cc",
          ],
@@ -52,7 +52,7 @@ index 1f269f9c149e56a7098697fc2346b5998b0c6e01..89bc2f54fc5e42a2cf6d6fa41742c2df
          "//conditions:default": [],
      }) + select({
          "@v8//bazel/config:v8_arm64_simulator": [
-@@ -2746,13 +2753,6 @@ filegroup(
+@@ -2762,13 +2769,6 @@ filegroup(
              "src/trap-handler/trap-handler-simulator.h",
          ],
          "//conditions:default": [],
@@ -66,7 +66,7 @@ index 1f269f9c149e56a7098697fc2346b5998b0c6e01..89bc2f54fc5e42a2cf6d6fa41742c2df
      }) + select({
          "@v8//bazel/config:is_windows_64bit": [
              "src/diagnostics/unwinding-info-win64.cc",
-@@ -3805,6 +3805,9 @@ filegroup(
+@@ -3825,6 +3825,9 @@ filegroup(
          "@v8//bazel/config:is_msvc_asm_ia32": ["src/heap/base/asm/ia32/push_registers_masm.asm"],
          "@v8//bazel/config:is_msvc_asm_x64": ["src/heap/base/asm/x64/push_registers_masm.asm"],
          "@v8//bazel/config:is_msvc_asm_arm64": ["src/heap/base/asm/arm64/push_registers_masm.S"],
@@ -76,7 +76,7 @@ index 1f269f9c149e56a7098697fc2346b5998b0c6e01..89bc2f54fc5e42a2cf6d6fa41742c2df
      }),
  )
 
-@@ -4201,9 +4204,11 @@ filegroup(
+@@ -4227,9 +4230,11 @@ filegroup(
          "src/d8/d8-js.cc",
          "src/d8/d8-platforms.cc",
          "src/d8/d8-platforms.h",
@@ -90,7 +90,7 @@ index 1f269f9c149e56a7098697fc2346b5998b0c6e01..89bc2f54fc5e42a2cf6d6fa41742c2df
  )
 
  genrule(
-@@ -4554,7 +4559,7 @@ py_test(
+@@ -4580,7 +4585,7 @@ py_test(
          ":noicu/d8",
          ":noicu/v8_build_config",
          "//testing/pybase",
@@ -99,7 +99,7 @@ index 1f269f9c149e56a7098697fc2346b5998b0c6e01..89bc2f54fc5e42a2cf6d6fa41742c2df
      main = "tools/run-tests.py",
      python_version = "PY3",
      tags = [
-@@ -4593,7 +4598,7 @@ py_test(
+@@ -4619,7 +4624,7 @@ py_test(
          ":icu/d8",
          ":icu/v8_build_config",
          "//testing/pybase",
@@ -178,7 +178,7 @@ index c81f278203126913c3bad74d31348706678ccf06..96e0f9cdb61d0d8f6597d337c2dd965b
      name = "is_clang",
      match_any = [
 diff --git a/bazel/defs.bzl b/bazel/defs.bzl
-index ba1716d9ad466a1a7a0a8976631c6a82cad9b894..cda9c55baefe428bd85b8d98dbf475d07e9c4307 100644
+index f961346e942d3f106ccd87f40bbe8c3a262c5261..a854e3cb4b3a70a4e683b1112598deefb28cbe58 100644
 --- a/bazel/defs.bzl
 +++ b/bazel/defs.bzl
 @@ -119,6 +119,24 @@ def _default_args():
@@ -230,15 +230,15 @@ index ba1716d9ad466a1a7a0a8976631c6a82cad9b894..cda9c55baefe428bd85b8d98dbf475d0
              ],
              "@v8//bazel/config:is_macos": ["-pthread"],
              "//conditions:default": ["-Wl,--no-as-needed -ldl -pthread"],
-@@ -495,6 +523,7 @@ def v8_mksnapshot(name, args, suffix = ""):
+@@ -492,6 +520,7 @@ def v8_mksnapshot(name, args, suffix = ""):
          suffix = suffix,
          target_os = select({
              "@v8//bazel/config:is_macos": "mac",
 +            "@v8//bazel/config:is_windows": "win",
              "//conditions:default": "",
          }),
      )
-@@ -506,6 +535,7 @@ def v8_mksnapshot(name, args, suffix = ""):
+@@ -503,6 +532,7 @@ def v8_mksnapshot(name, args, suffix = ""):
          suffix = suffix,
          target_os = select({
              "@v8//bazel/config:is_macos": "mac",

…4-Allow-Windows-builds-under-Bazel.patch …3-Allow-Windows-builds-under-Bazel.patchpatches/v8/0004-Allow-Windows-builds-under-Bazel.patch renamed to patches/v8/0003-Allow-Windows-builds-under-Bazel.patch patches/v8/0004-Allow-Windows-builds-under-Bazel.patch renamed to patches/v8/0003-Allow-Windows-builds-under-Bazel.patch

@@ -1,4 +1,4 @@
-From 3fab228a85820d93478887f88725d740b8fb919c Mon Sep 17 00:00:00 2001
+From fc8627f4d7aac841d000f3e88208e619eaebd84a Mon Sep 17 00:00:00 2001
 From: Felix Hanau <[email protected]>
 Date: Tue, 11 Apr 2023 14:41:31 -0400
 Subject: Disable bazel whole-archive build

…-Disable-bazel-whole-archive-build.patch …-Disable-bazel-whole-archive-build.patchpatches/v8/0005-Disable-bazel-whole-archive-build.patch renamed to patches/v8/0004-Disable-bazel-whole-archive-build.patch patches/v8/0005-Disable-bazel-whole-archive-build.patch renamed to patches/v8/0004-Disable-bazel-whole-archive-build.patch

@@ -1,4 +1,4 @@
-From 1f4c8f5f723a9e80abcb8a966249b13105d890bb Mon Sep 17 00:00:00 2001
+From a62bdfd1858fff43ed8248a3d39b7bd00dd06e25 Mon Sep 17 00:00:00 2001
 From: Felix Hanau <[email protected]>
 Date: Wed, 7 Jun 2023 21:40:54 -0400
 Subject: Speed up V8 bazel build by always using target cfg
@@ -12,7 +12,7 @@ generated files as the output set. While unrelated to the build cfg change,
 this also improves build times.
 
 diff --git a/BUILD.bazel b/BUILD.bazel
-index 89bc2f54fc5e42a2cf6d6fa41742c2dfe2c9ab48..675c36f7784409f10b28b6fca93d4fd39f69a17d 100644
+index 80bf8f89783334bbcf44f05a8de3f32dd04790f0..23915096536d7f80e46b7dc33ca2ee56a61487bc 100644
 --- a/BUILD.bazel
 +++ b/BUILD.bazel
 @@ -17,6 +17,7 @@ load(
@@ -23,7 +23,7 @@ index 89bc2f54fc5e42a2cf6d6fa41742c2dfe2c9ab48..675c36f7784409f10b28b6fca93d4fd3
  )
  load(":bazel/v8-non-pointer-compression.bzl", "v8_binary_non_pointer_compression")
 
-@@ -4211,22 +4212,20 @@ filegroup(
+@@ -4237,22 +4238,20 @@ filegroup(
      }),
  )
 
@@ -52,7 +52,7 @@ index 89bc2f54fc5e42a2cf6d6fa41742c2dfe2c9ab48..675c36f7784409f10b28b6fca93d4fd3
  )
 
  v8_mksnapshot(
-@@ -4427,8 +4426,6 @@ v8_binary(
+@@ -4453,8 +4452,6 @@ v8_binary(
      srcs = [
          "src/regexp/gen-regexp-special-case.cc",
          "src/regexp/special-case.h",
@@ -61,7 +61,7 @@ index 89bc2f54fc5e42a2cf6d6fa41742c2dfe2c9ab48..675c36f7784409f10b28b6fca93d4fd3
      ],
      copts = ["-Wno-implicit-fallthrough"],
      defines = [
-@@ -4440,6 +4437,7 @@ v8_binary(
+@@ -4466,6 +4463,7 @@ v8_binary(
      ],
      deps = [
          "//external:absl_optional",
@@ -70,10 +70,10 @@ index 89bc2f54fc5e42a2cf6d6fa41742c2dfe2c9ab48..675c36f7784409f10b28b6fca93d4fd3
      ],
  )
 diff --git a/bazel/defs.bzl b/bazel/defs.bzl
-index cda9c55baefe428bd85b8d98dbf475d07e9c4307..658b44b7deca596ef8ea5b178b2d51b0d06820d3 100644
+index a854e3cb4b3a70a4e683b1112598deefb28cbe58..a0e8b91ecc9deb4e045c947d2e62eba0bc87cf0e 100644
 --- a/bazel/defs.bzl
 +++ b/bazel/defs.bzl
-@@ -340,6 +340,15 @@ def v8_library(
+@@ -337,6 +337,15 @@ def v8_library(
              **kwargs
          )
 
@@ -89,7 +89,7 @@ index cda9c55baefe428bd85b8d98dbf475d07e9c4307..658b44b7deca596ef8ea5b178b2d51b0
  # Use a single generator target for torque definitions and initializers. We can
  # split the set of outputs by using OutputGroupInfo, that way we do not need to
  # run the torque generator twice.
-@@ -404,7 +413,7 @@ _v8_torque_files = rule(
+@@ -401,7 +410,7 @@ _v8_torque_files = rule(
          "tool": attr.label(
              allow_files = True,
              executable = True,
@@ -98,7 +98,7 @@ index cda9c55baefe428bd85b8d98dbf475d07e9c4307..658b44b7deca596ef8ea5b178b2d51b0
          ),
          "args": attr.string_list(),
      },
-@@ -505,13 +514,16 @@ _v8_mksnapshot = rule(
+@@ -502,13 +511,16 @@ _v8_mksnapshot = rule(
              mandatory = True,
              allow_files = True,
              executable = True,
@@ -117,7 +117,7 @@ index cda9c55baefe428bd85b8d98dbf475d07e9c4307..658b44b7deca596ef8ea5b178b2d51b0
  )
 
  def v8_mksnapshot(name, args, suffix = ""):
-@@ -635,3 +647,34 @@ def v8_build_config(name, arch):
+@@ -633,3 +645,34 @@ def v8_build_config(name, arch):
          outs = ["icu/" + name + ".json"],
          cmd = "echo '" + build_config_content(cpu, "true") + "' > \"$@\"",
      )