Revert "[Instrumentation] Add spans for Images Binding (#5236)"

This reverts commit df9779b.

Author: mikea

src/cloudflare/internal/images-api.ts

@@ -6,7 +6,7 @@ import {
   createBase64DecoderTransformStream,
   createBase64EncoderTransformStream,
 } from 'cloudflare-internal:streaming-base64';
-import { withSpan, type Span } from 'cloudflare-internal:tracing-helpers';
+import { withSpan } from 'cloudflare-internal:tracing-helpers';
 
 type Fetcher = {
   fetch: typeof fetch;
@@ -122,51 +122,40 @@ class ImageTransformerImpl implements ImageTransformer {
   async output(
     options: ImageOutputOptions
   ): Promise<ImageTransformationResult> {
-    return await withSpan('images_output', async (span) => {
-      span.setAttribute('cloudflare.binding.type', 'Images');
-      const formData = new StreamableFormData();
+    const formData = new StreamableFormData();
 
-      this.#consume();
-      formData.append('image', this.#stream, { type: 'file' });
+    this.#consume();
+    formData.append('image', this.#stream, { type: 'file' });
 
-      this.#serializeTransforms(formData, span);
+    this.#serializeTransforms(formData);
 
-      span.setAttribute('cloudflare.images.options.format', options.format);
-      formData.append('output_format', options.format);
+    formData.append('output_format', options.format);
+    if (options.quality !== undefined) {
+      formData.append('output_quality', options.quality.toString());
+    }
 
-      if (options.quality !== undefined) {
-        span.setAttribute('cloudflare.images.options.quality', options.quality);
-        formData.append('output_quality', options.quality.toString());
-      }
+    if (options.background !== undefined) {
+      formData.append('background', options.background);
+    }
 
-      if (options.background !== undefined) {
-        span.setAttribute(
-          'cloudflare.images.options.background',
-          options.background
-        );
-        formData.append('background', options.background);
-      }
+    if (options.anim !== undefined) {
+      formData.append('anim', options.anim.toString());
+    }
 
-      if (options.anim !== undefined) {
-        span.setAttribute('cloudflare.images.options.anim', options.anim);
-        formData.append('anim', options.anim.toString());
+    const response = await this.#fetcher.fetch(
+      'https://js.images.cloudflare.com/transform',
+      {
+        method: 'POST',
+        headers: {
+          'content-type': formData.contentType(),
+        },
+        body: formData.stream(),
       }
+    );
 
-      const response = await this.#fetcher.fetch(
-        'https://js.images.cloudflare.com/transform',
-        {
-          method: 'POST',
-          headers: {
-            'content-type': formData.contentType(),
-          },
-          body: formData.stream(),
-        }
-      );
-
-      await throwErrorIfErrorResponse('TRANSFORM', response, span);
+    await throwErrorIfErrorResponse('TRANSFORM', response);
 
-      return new TransformationResultImpl(response);
-    });
+    return new TransformationResultImpl(response);
   }
 
   #consume(): void {
@@ -180,7 +169,7 @@ class ImageTransformerImpl implements ImageTransformer {
     this.#consumed = true;
   }
 
-  #serializeTransforms(formData: StreamableFormData, span: Span): void {
+  #serializeTransforms(formData: StreamableFormData): void {
     const transforms: (TargetedTransform | DrawCommand)[] = [];
 
     // image 0 is the canvas, so the first draw_image has index 1
@@ -222,16 +211,6 @@ class ImageTransformerImpl implements ImageTransformer {
     }
 
     walkTransforms(0, this.#transforms);
-
-    // The transforms are a set of operations which are applied to the image in order.
-    // Attaching an attribute as JSON is a little odd, but I'm not sure if there is
-    // a better way to do this.
-    if (transforms.length > 0) {
-      span.setAttribute(
-        'cloudflare.images.options.transforms',
-        JSON.stringify(transforms)
-      );
-    }
     formData.append('transforms', JSON.stringify(transforms));
   }
 }
@@ -256,18 +235,15 @@ class ImagesBindingImpl implements ImagesBinding {
     options?: ImageInputOptions
   ): Promise<ImageInfoResponse> {
     return await withSpan('images_info', async (span) => {
-      span.setAttribute('cloudflare.binding.type', 'Images');
       const body = new StreamableFormData();
 
-      span.setAttribute(
-        'cloudflare.images.options.encoding',
-        options?.encoding ?? 'base64'
-      );
       const decodedStream =
         options?.encoding === 'base64'
           ? stream.pipeThrough(createBase64DecoderTransformStream())
           : stream;
 
+      span.setAttribute('cloudflare.images.info.encoding', options?.encoding);
+
       body.append('image', decodedStream, { type: 'file' });
 
       const response = await this.#fetcher.fetch(
@@ -281,23 +257,22 @@ class ImagesBindingImpl implements ImagesBinding {
         }
       );
 
-      await throwErrorIfErrorResponse('INFO', response, span);
+      await throwErrorIfErrorResponse('INFO', response);
 
       const r = (await response.json()) as RawInfoResponse;
 
-      span.setAttribute('cloudflare.images.result.format', r.format);
+      span.setAttribute('cloudflare.images.info.format', r.format);
 
       if ('file_size' in r) {
-        const ret = {
+        span.setAttribute('cloudflare.images.info.file_size', r.file_size);
+        span.setAttribute('cloudflare.images.info.width', r.width);
+        span.setAttribute('cloudflare.images.info.height', r.height);
+        return {
           fileSize: r.file_size,
           width: r.width,
           height: r.height,
           format: r.format,
         };
-        span.setAttribute('cloudflare.images.result.file_size', ret.fileSize);
-        span.setAttribute('cloudflare.images.result.width', ret.width);
-        span.setAttribute('cloudflare.images.result.height', ret.height);
-        return ret;
       }
 
       return r;
@@ -327,29 +302,24 @@ class ImagesErrorImpl extends Error implements ImagesError {
 
 async function throwErrorIfErrorResponse(
   operation: string,
-  response: Response,
-  span: Span
+  response: Response
 ): Promise<void> {
   const statusHeader = response.headers.get('cf-images-binding') || '';
 
   const match = /err=(\d+)/.exec(statusHeader);
 
   if (match && match[1]) {
-    const errorMessage = await response.text();
-    span.setAttribute('cloudflare.images.error.code', match[1]);
-    span.setAttribute('error.type', errorMessage);
     throw new ImagesErrorImpl(
-      `IMAGES_${operation}_${errorMessage}`.trim(),
+      `IMAGES_${operation}_${await response.text()}`.trim(),
       Number.parseInt(match[1])
     );
   }
 
   if (response.status > 399) {
-    const errorMessage = await response.text();
-    span.setAttribute('cloudflare.images.error.code', '9523');
-    span.setAttribute('error.type', errorMessage);
     throw new ImagesErrorImpl(
-      `Unexpected error response ${response.status}: ${errorMessage.trim()}`,
+      `Unexpected error response ${response.status}: ${(
+        await response.text()
+      ).trim()}`,
       9523
     );
   }