add more tests related to node:http (#4448)

Author: anonrig

src/workerd/api/node/BUILD.bazel

@@ -432,10 +432,19 @@ wd_test(
     ],
 )
 
+js_binary(
+    name = "http-agent-server",
+    entry_point = "tests/http-agent-server.js",
+)
+
 wd_test(
     src = "tests/http-agent-nodejs-test.wd-test",
     args = ["--experimental"],
     data = ["tests/http-agent-nodejs-test.js"],
+    sidecar = "http-agent-server",
+    sidecar_port_bindings = [
+        "PONG_SERVER_PORT",
+    ],
 )
 
 wd_test(

src/workerd/api/node/tests/http-agent-nodejs-test.js

@@ -3,7 +3,17 @@
 //     https://opensource.org/licenses/Apache-2.0
 
 import http from 'node:http';
-import { strictEqual } from 'node:assert';
+import { strictEqual, ok } from 'node:assert';
+
+export const checkPortsSetCorrectly = {
+  test(_ctrl, env) {
+    const keys = ['PONG_SERVER_PORT'];
+    for (const key of keys) {
+      strictEqual(typeof env[key], 'string');
+      ok(env[key].length > 0);
+    }
+  },
+};
 
 // Test is taken from test/parallel/test-http-agent-getname.js
 export const testHttpAgentGetName = {
@@ -50,3 +60,18 @@ export const testHttpAgentGetName = {
       strictEqual(agent.getName({ family }), `localhost:::${family}`);
   },
 };
+
+// Test is taken from test/parallel/test-http-agent-null.js
+export const testHttpAgentNull = {
+  async test(_ctrl, env) {
+    const { promise, resolve } = Promise.withResolvers();
+    http.get(
+      {
+        agent: null,
+        port: env.PONG_SERVER_PORT,
+      },
+      resolve
+    );
+    await promise;
+  },
+};

src/workerd/api/node/tests/http-agent-nodejs-test.wd-test

@@ -9,6 +9,9 @@ const unitTests :Workerd.Config = (
         ],
         compatibilityDate = "2025-01-15",
         compatibilityFlags = ["nodejs_compat", "experimental"],
+        bindings = [
+          (name = "PONG_SERVER_PORT", fromEnvironment = "PONG_SERVER_PORT"),
+        ],
       )
     ),
     ( name = "internet", network = ( allow = ["private"] ) ),

src/workerd/api/node/tests/http-agent-server.js

@@ -0,0 +1,20 @@
+// Copyright (c) 2017-2022 Cloudflare, Inc.
+// Licensed under the Apache 2.0 license found in the LICENSE file or at:
+//     https://opensource.org/licenses/Apache-2.0
+
+// This is a sidecar that runs alongside the http-client-nodejs-test.* tests.
+// It is executed using the appropriate Node.js version defined in WORKSPACE.
+const http = require('node:http');
+
+function reportPort(server) {
+  console.info(`Listening on port ${server.address().port}`);
+}
+
+const pongServer = http.createServer((req, res) => {
+  req.resume();
+  req.on('end', () => {
+    res.writeHead(200);
+    res.end('pong');
+  });
+});
+pongServer.listen(process.env.PONG_SERVER_PORT, () => reportPort(pongServer));

src/workerd/api/node/tests/http-client-nodejs-test.js

@@ -5,7 +5,6 @@
 import http from 'node:http';
 import https from 'node:https';
 import { strictEqual, ok, deepStrictEqual, throws } from 'node:assert';
-import { mock } from 'node:test';
 
 export const checkPortsSetCorrectly = {
   test(_ctrl, env) {