Python: Use the setTimeout from the outer isolate

Not from the pool isolate.

Author: hoodmane

src/pyodide/helpers.bzl

@@ -181,6 +181,7 @@ def _python_bundle(version, *, pyodide_asm_wasm = None, pyodide_asm_js = None, p
         reportUndefinedSymbolsPatched,
         wasmInstantiate,
         patched_PyEM_CountFuncParams,
+        setTimeout,
     } from "pyodide-internal:pool/builtin_wrappers";
     """
 

src/pyodide/internal/pool/builtin_wrappers.ts

@@ -16,6 +16,19 @@ export const location = undefined;
 
 export function addEventListener(): void {}
 
+
+let _outerSetTimout: typeof setTimeout;
+
+export function setSetTimeout(f: typeof setTimeout) {
+  _outerSetTimout = f;
+}
+
+// Make sure we use the setTimeout from the outer isolate, not the pool isolate.
+// Otherwise we get timeout id conflicts
+export function setTimeout(func: () => void, ms: number): void {
+  _outerSetTimout(func, ms);
+}
+
 export function reportUndefinedSymbolsPatched(Module: Module): void {
   if (Module.API.version === '0.26.0a2') {
     return;

src/pyodide/internal/pool/emscriptenSetup.ts

@@ -14,6 +14,7 @@ import { _createPyodideModule } from 'pyodide-internal:generated/pyodide.asm';
 import {
   setUnsafeEval,
   setGetRandomValues,
+  setSetTimeout,
   finishSetup,
 } from 'pyodide-internal:pool/builtin_wrappers';
 
@@ -216,6 +217,7 @@ export async function instantiateEmscriptenModule(
   const emscriptenModule = await emscriptenSettings.readyPromise;
   emscriptenModule.setUnsafeEval = setUnsafeEval;
   emscriptenModule.setGetRandomValues = setGetRandomValues;
+  emscriptenModule.setSetTimeout = setSetTimeout;
   finishSetup();
   return emscriptenModule;
 }

src/pyodide/internal/python.ts

@@ -106,6 +106,7 @@ export async function loadPyodide(
     }
     Module.setUnsafeEval(UnsafeEval);
     Module.setGetRandomValues(getRandomValues);
+    Module.setSetTimeout(setTimeout);
 
     entropyMountFiles(Module);
     await enterJaegerSpan('load_packages', () =>

src/pyodide/types/emscripten.d.ts

@@ -97,6 +97,7 @@ interface Module {
   setGetRandomValues(
     func: typeof import('pyodide-internal:topLevelEntropy/lib').getRandomValues
   ): void;
+  setSetTimeout(func: typeof setTimeout): void;
   getMemory(size: number): number;
   getMemoryPatched(
     Module: Module,