Skip to content

Commit f32706b

Browse files
authored
Merge pull request #3149 from cloudflare/yagiz/remove-unnecessary-symbolizer
replace symbolizer with kj built-in
2 parents 91ac4fd + 739c80c commit f32706b

File tree

5 files changed

+4
-200
lines changed

5 files changed

+4
-200
lines changed

build/kj_test.bzl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ def kj_test(
1010
srcs = [src],
1111
deps = [
1212
"@capnp-cpp//src/kj:kj-test",
13-
] + select({
14-
"@platforms//os:windows": [],
15-
"//conditions:default": ["@workerd//src/workerd/util:symbolizer"],
16-
}) + deps,
13+
] + deps,
1714
linkopts = select({
1815
"@//:use_dead_strip": ["-Wl,-dead_strip", "-Wl,-no_exported_symbols"],
1916
"//conditions:default": [""],

justfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ default:
77
@just --list
88

99
pwd := `pwd`
10-
clang_version := "18"
1110

1211
prepare:
1312
cargo install gen-compile-commands
@@ -25,14 +24,14 @@ build-asan *args="//...":
2524
just build {{args}} --config=asan --sandbox_debug
2625

2726
test *args="//...":
28-
bazel test {{args}} --test_env=LLVM_SYMBOLIZER=llvm-symbolizer-{{clang_version}}
27+
bazel test {{args}}
2928

3029
test-asan *args="//...":
3130
just test {{args}} --config=asan
3231

3332
# e.g. just stream-test //src/cloudflare:cloudflare.capnp@eslint
3433
stream-test args:
35-
bazel test {{args}} --test_output=streamed --test_env=LLVM_SYMBOLIZER=llvm-symbolizer-{{clang_version}}
34+
bazel test {{args}} --test_output=streamed
3635

3736
# e.g. just node-test zlib
3837
node-test test_name:

src/workerd/server/BUILD.bazel

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,7 @@ wd_cc_binary(
5757
"//src/workerd/util:autogate",
5858
"//src/workerd/util:perfetto",
5959
"@capnp-cpp//src/capnp:capnpc",
60-
] + select({
61-
"@platforms//os:windows": [],
62-
"//conditions:default": ["@workerd//src/workerd/util:symbolizer"],
63-
}),
60+
],
6461
)
6562

6663
wd_cc_library(

src/workerd/util/BUILD.bazel

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -143,21 +143,6 @@ wd_cc_library(
143143
],
144144
)
145145

146-
wd_cc_library(
147-
name = "symbolizer",
148-
srcs = ["symbolizer.c++"],
149-
target_compatible_with = select({
150-
"@platforms//os:windows": ["@platforms//:incompatible"],
151-
"//conditions:default": [],
152-
}),
153-
visibility = ["//visibility:public"],
154-
deps = [
155-
":sentry",
156-
"@capnp-cpp//src/kj",
157-
],
158-
alwayslink = 1,
159-
)
160-
161146
wd_cc_library(
162147
name = "own-util",
163148
hdrs = ["own-util.h"],

src/workerd/util/symbolizer.c++

Lines changed: 0 additions & 174 deletions
This file was deleted.

0 commit comments

Comments
 (0)