cleanup deps/implementation_deps

Author: anonrig

src/workerd/api/crypto/impl.c++

@@ -4,6 +4,8 @@
 
 #include "impl.h"
 
+#include "simdutf.h"
+
 #include <workerd/api/util.h>
 #include <workerd/jsg/memory.h>
 

src/workerd/api/crypto/rsa.c++

@@ -2,7 +2,6 @@
 
 #include "impl.h"
 #include "keys.h"
-#include "simdutf.h"
 #include "util.h"
 
 #include <openssl/bn.h>

src/workerd/jsg/BUILD.bazel

@@ -48,7 +48,6 @@ wd_cc_library(
         "//src/workerd/util:sentry",
         "//src/workerd/util:thread-scopes",
         "@capnp-cpp//src/kj",
-        "@simdutf",
         "@workerd-v8//:v8",
     ],
 )
@@ -111,6 +110,7 @@ wd_cc_library(
     ],
     # Some JSG headers can't be compiled on their own
     features = ["-parse_headers"],
+    implementation_deps = ["@simdutf"],
     local_defines = ["JSG_IMPLEMENTATION"],
     deps = [
         ":exception",
@@ -126,7 +126,6 @@ wd_cc_library(
         "//src/workerd/util:thread-scopes",
         "//src/workerd/util:uuid",
         "@capnp-cpp//src/kj",
-        "@simdutf",
         "@ssl",
         "@workerd-v8//:v8",
     ],
@@ -156,15 +155,15 @@ wd_cc_library(
     hdrs = [
         "inspector.h",
     ],
-    local_defines = ["JSG_IMPLEMENTATION"],
-    # Some JSG headers can't be compiled on their own
-    visibility = ["//visibility:public"],
-    deps = [
+    implementation_deps = [
         ":jsg-core",
         "@capnp-cpp//src/kj",
         "@simdutf",
         "@workerd-v8//:v8",
     ],
+    local_defines = ["JSG_IMPLEMENTATION"],
+    # Some JSG headers can't be compiled on their own
+    visibility = ["//visibility:public"],
 )
 
 wd_cc_library(

src/workerd/jsg/iterator.h

@@ -4,8 +4,8 @@
 
 #pragma once
 
-#include <workerd/jsg/jsg.h>
 #include <workerd/jsg/memory.h>
+#include <workerd/jsg/promise.h>
 #include <workerd/jsg/struct.h>
 
 #include <concepts>

src/workerd/jsg/jsg.h

@@ -1126,7 +1126,7 @@ class USVString: public kj::String {
   }
 
  private:
-  // This is a seperate method to avoid including simdutf8 in the header file.
+  // This is a seperate method to avoid including simdutf in the header file.
   bool isValidUtf8() const;
 };
 

src/workerd/jsg/value.h

@@ -8,8 +8,6 @@
 // Handling of various basic value types: numbers, booleans, strings, optionals, maybes, variants,
 // arrays, buffers, dicts.
 
-#include "simdutf.h"
-
 #include <workerd/jsg/fast-api.h>
 #include <workerd/jsg/util.h>
 #include <workerd/jsg/web-idl.h>